ARM: 6517/1: kexec: Add missing memory clobber to inline asm in crash_setup_regs()
authorDave Martin <dave.martin@linaro.org>
Wed, 1 Dec 2010 17:05:13 +0000 (18:05 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Sat, 4 Dec 2010 11:00:52 +0000 (11:00 +0000)
commit0946b8c5c5982088a26da7ad99e8bcf57f972fb5
tree2a76931b417a271b132132accee88b58c96dfd94
parentcb5d39b3a1440eca79c742d95f1d78180c272286
ARM: 6517/1: kexec: Add missing memory clobber to inline asm in crash_setup_regs()

Currently, the inline asm is passed &newregs->ARM_r0 as in input,
when modifying multiple fields of newregs.

It's plausible to assume that GCC will assume newregs->ARM_r0 is
modified when passed the address, but unfortunately this assumption
is incorrect.

Also, GCC has no way to guess that the other ARM_r* fields are
modified without the addition of a "memory" clobber.

Signed-off-by: Dave Martin <dave.martin@linaro.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/include/asm/kexec.h