ASoC: davinci-mcasp.c: Return error code in failure
authorJulia Lawall <julia@diku.dk>
Mon, 18 Oct 2010 14:11:13 +0000 (16:11 +0200)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 18 Oct 2010 23:29:24 +0000 (16:29 -0700)
commit02ffc5f3f91c265e110ddd1fdd7019a18426ebe5
tree0243071f64cda3a3a11de7c6a93635e69d49b38f
parentf6765502f8daae3d237a394889276c8987f3e299
ASoC: davinci-mcasp.c: Return error code in failure

In this code, 0 is returned on failure, even though other
failures return -ENOMEM or other similar values.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@a@
identifier alloc;
identifier ret;
constant C;
expression x;
@@

x = alloc(...);
if (x == NULL) { <+... \(ret = -C; \| return -C; \) ...+> }

@@
identifier f, a.alloc;
expression ret;
expression x,e1,e2,e3;
@@

ret = 0
... when != ret = e1
*x = alloc(...)
... when != ret = e2
if (x == NULL) { ... when != ret = e3
  return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/davinci/davinci-mcasp.c