USB: ehci-mxc: Setup portsc register prior to accessing OTG viewport
authorFabio Estevam <festevam@gmail.com>
Thu, 16 Dec 2010 00:31:28 +0000 (22:31 -0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 16 Dec 2010 21:37:48 +0000 (13:37 -0800)
commit0247a7bcd4273fa10c4aba9b3f567c659bab2d2b
tree78316e82037bad3cbfcb329f240181671b6b0f7e
parent2c8245c4990e75d86ab30bb0af9bb90cbe04985d
USB: ehci-mxc: Setup portsc register prior to accessing OTG viewport

In order to read/write to the i.MX OTG viewport register it is necessary to setup
the PORTSCx register first.

By default i.MX OTG port is configured for USB serial PHY. In order to use a ULPI PHY
the PORTSCx register needs to be configured properly.

commit 724c852 (USB: ehci/mxc: compile fix) placed the PORTSC setup after the OTG
viewport is accessed and this causes ULPI read/write to fail.

Revert the PORTSC setup order.

Tested on a MX31PDK board with a ISP1504 transceiver:

ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
mxc-ehci mxc-ehci.0: initializing i.MX USB Controller
ULPI transceiver vendor/product ID 0x04cc/0x1504
Found NXP ISP1504 ULPI transceiver.
ULPI integrity check: passed.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ehci-mxc.c