sparc64: Fix bit twiddling in sparc_pmu_enable_event().
authorDavid S. Miller <davem@davemloft.net>
Tue, 16 Oct 2012 20:05:25 +0000 (13:05 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 30 Oct 2012 23:26:31 +0000 (23:26 +0000)
commit00f784c84afeae6380f6f5c3f993d3da501dc648
tree84742e49794f1d6ac040606daff468b4430c22cb
parent6471fbc6eb71dd615075f58576ad813697700873
sparc64: Fix bit twiddling in sparc_pmu_enable_event().

[ Upstream commit e793d8c6740f8fe704fa216e95685f4d92c4c4b9 ]

There was a serious disconnect in the logic happening in
sparc_pmu_disable_event() vs. sparc_pmu_enable_event().

Event disable is implemented by programming a NOP event into the PCR.

However, event enable was not reversing this operation.  Instead, it
was setting the User/Priv/Hypervisor trace enable bits.

That's not sparc_pmu_enable_event()'s job, that's what
sparc_pmu_enable() and sparc_pmu_disable() do .

The intent of sparc_pmu_enable_event() is clear, since it first clear
out the event type encoding field.  So fix this by OR'ing in the event
encoding rather than the trace enable bits.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/sparc/kernel/perf_event.c