X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-kernel.git;a=blobdiff_plain;f=net%2Fcore%2Fgen_stats.c;h=91080c190c3328c9bff7b7e10fcf63641e647241;hp=0452eb27a2724dcd3782f5acb15be04e7efba47e;hb=24aa85b0d9ef3f2cd3d99be59bbf58fba269ba08;hpb=fd8aa2c1811bf60ccb2d5de0579c6f62aec1772d diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c index 0452eb27a272..91080c190c33 100644 --- a/net/core/gen_stats.c +++ b/net/core/gen_stats.c @@ -31,6 +31,9 @@ gnet_stats_copy(struct gnet_dump *d, int type, void *buf, int size) return 0; nla_put_failure: + kfree(d->xstats); + d->xstats = NULL; + d->xstats_len = 0; spin_unlock_bh(d->lock); return -1; } @@ -204,7 +207,9 @@ int gnet_stats_copy_app(struct gnet_dump *d, void *st, int len) { if (d->compat_xstats) { - d->xstats = st; + d->xstats = kmemdup(st, len, GFP_ATOMIC); + if (!d->xstats) + goto err_out; d->xstats_len = len; } @@ -212,6 +217,11 @@ gnet_stats_copy_app(struct gnet_dump *d, void *st, int len) return gnet_stats_copy(d, TCA_STATS_APP, st, len); return 0; + +err_out: + d->xstats_len = 0; + spin_unlock_bh(d->lock); + return -1; } EXPORT_SYMBOL(gnet_stats_copy_app); @@ -244,6 +254,9 @@ gnet_stats_finish_copy(struct gnet_dump *d) return -1; } + kfree(d->xstats); + d->xstats = NULL; + d->xstats_len = 0; spin_unlock_bh(d->lock); return 0; }