ASoC: Clean up WM8974 PLL configuration
[pandora-kernel.git] / sound / soc / codecs / wm8974.c
index b5f1a70..f30f86b 100644 (file)
@@ -1,9 +1,9 @@
 /*
  * wm8974.c  --  WM8974 ALSA Soc Audio driver
  *
- * Copyright 2006 Wolfson Microelectronics PLC.
+ * Copyright 2006-2009 Wolfson Microelectronics PLC.
  *
- * Author: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
+ * Author: Liam Girdwood <linux@wolfsonmicro.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
 #include <sound/soc.h>
 #include <sound/soc-dapm.h>
 #include <sound/initval.h>
+#include <sound/tlv.h>
 
 #include "wm8974.h"
 
-struct snd_soc_codec_device soc_codec_dev_wm8974;
-
-/*
- * wm8974 register cache
- * We can't read the WM8974 register space when we are
- * using 2 wire for device control, so we cache them instead.
- */
 static const u16 wm8974_reg[WM8974_CACHEREGNUM] = {
        0x0000, 0x0000, 0x0000, 0x0000,
        0x0050, 0x0000, 0x0140, 0x0000,
@@ -53,6 +47,16 @@ static const u16 wm8974_reg[WM8974_CACHEREGNUM] = {
        0x0000,
 };
 
+#define WM8974_POWER1_BIASEN  0x08
+#define WM8974_POWER1_BUFIOEN 0x10
+
+struct wm8974_priv {
+       struct snd_soc_codec codec;
+       u16 reg_cache[WM8974_CACHEREGNUM];
+};
+
+static struct snd_soc_codec *wm8974_codec;
+
 /*
  * read wm8974 register cache
  */
@@ -134,6 +138,16 @@ static const struct soc_enum wm8974_enum[] = {
        SOC_ENUM_SINGLE(WM8974_ALC3,  8, 2, wm8974_alc),
 };
 
+static const char *wm8974_auxmode_text[] = { "Buffer", "Mixer" };
+
+static const struct soc_enum wm8974_auxmode =
+       SOC_ENUM_SINGLE(WM8974_INPUT,  3, 2, wm8974_auxmode_text);
+
+static const DECLARE_TLV_DB_SCALE(digital_tlv, -12750, 50, 1);
+static const DECLARE_TLV_DB_SCALE(eq_tlv, -1200, 100, 0);
+static const DECLARE_TLV_DB_SCALE(inpga_tlv, -1200, 75, 0);
+static const DECLARE_TLV_DB_SCALE(spk_tlv, -5700, 100, 0);
+
 static const struct snd_kcontrol_new wm8974_snd_controls[] = {
 
 SOC_SINGLE("Digital Loopback Switch", WM8974_COMP, 0, 1, 0),
@@ -144,33 +158,33 @@ SOC_ENUM("ADC Companding", wm8974_enum[0]),
 SOC_ENUM("Playback De-emphasis", wm8974_enum[2]),
 SOC_SINGLE("DAC Inversion Switch", WM8974_DAC, 0, 1, 0),
 
-SOC_SINGLE("PCM Volume", WM8974_DACVOL, 0, 127, 0),
+SOC_SINGLE_TLV("PCM Volume", WM8974_DACVOL, 0, 255, 0, digital_tlv),
 
 SOC_SINGLE("High Pass Filter Switch", WM8974_ADC, 8, 1, 0),
 SOC_SINGLE("High Pass Cut Off", WM8974_ADC, 4, 7, 0),
-SOC_SINGLE("ADC Inversion Switch", WM8974_COMP, 0, 1, 0),
+SOC_SINGLE("ADC Inversion Switch", WM8974_ADC, 0, 1, 0),
 
-SOC_SINGLE("Capture Volume", WM8974_ADCVOL,  0, 127, 0),
+SOC_SINGLE_TLV("Capture Volume", WM8974_ADCVOL,  0, 255, 0, digital_tlv),
 
 SOC_ENUM("Equaliser Function", wm8974_enum[3]),
 SOC_ENUM("EQ1 Cut Off", wm8974_enum[4]),
-SOC_SINGLE("EQ1 Volume", WM8974_EQ1,  0, 31, 1),
+SOC_SINGLE_TLV("EQ1 Volume", WM8974_EQ1,  0, 24, 1, eq_tlv),
 
 SOC_ENUM("Equaliser EQ2 Bandwith", wm8974_enum[5]),
 SOC_ENUM("EQ2 Cut Off", wm8974_enum[6]),
-SOC_SINGLE("EQ2 Volume", WM8974_EQ2,  0, 31, 1),
+SOC_SINGLE_TLV("EQ2 Volume", WM8974_EQ2,  0, 24, 1, eq_tlv),
 
 SOC_ENUM("Equaliser EQ3 Bandwith", wm8974_enum[7]),
 SOC_ENUM("EQ3 Cut Off", wm8974_enum[8]),
-SOC_SINGLE("EQ3 Volume", WM8974_EQ3,  0, 31, 1),
+SOC_SINGLE_TLV("EQ3 Volume", WM8974_EQ3,  0, 24, 1, eq_tlv),
 
 SOC_ENUM("Equaliser EQ4 Bandwith", wm8974_enum[9]),
 SOC_ENUM("EQ4 Cut Off", wm8974_enum[10]),
-SOC_SINGLE("EQ4 Volume", WM8974_EQ4,  0, 31, 1),
+SOC_SINGLE_TLV("EQ4 Volume", WM8974_EQ4,  0, 24, 1, eq_tlv),
 
 SOC_ENUM("Equaliser EQ5 Bandwith", wm8974_enum[11]),
 SOC_ENUM("EQ5 Cut Off", wm8974_enum[12]),
-SOC_SINGLE("EQ5 Volume", WM8974_EQ5,  0, 31, 1),
+SOC_SINGLE_TLV("EQ5 Volume", WM8974_EQ5,  0, 24, 1, eq_tlv),
 
 SOC_SINGLE("DAC Playback Limiter Switch", WM8974_DACLIM1,  8, 1, 0),
 SOC_SINGLE("DAC Playback Limiter Decay", WM8974_DACLIM1,  4, 15, 0),
@@ -195,32 +209,18 @@ SOC_SINGLE("ALC Capture Noise Gate Switch", WM8974_NGATE,  3, 1, 0),
 SOC_SINGLE("ALC Capture Noise Gate Threshold", WM8974_NGATE,  0, 7, 0),
 
 SOC_SINGLE("Capture PGA ZC Switch", WM8974_INPPGA,  7, 1, 0),
-SOC_SINGLE("Capture PGA Volume", WM8974_INPPGA,  0, 63, 0),
+SOC_SINGLE_TLV("Capture PGA Volume", WM8974_INPPGA,  0, 63, 0, inpga_tlv),
 
 SOC_SINGLE("Speaker Playback ZC Switch", WM8974_SPKVOL,  7, 1, 0),
 SOC_SINGLE("Speaker Playback Switch", WM8974_SPKVOL,  6, 1, 1),
-SOC_SINGLE("Speaker Playback Volume", WM8974_SPKVOL,  0, 63, 0),
+SOC_SINGLE_TLV("Speaker Playback Volume", WM8974_SPKVOL,  0, 63, 0, spk_tlv),
+
+SOC_ENUM("Aux Mode", wm8974_auxmode),
 
 SOC_SINGLE("Capture Boost(+20dB)", WM8974_ADCBOOST,  8, 1, 0),
-SOC_SINGLE("Mono Playback Switch", WM8974_MONOMIX, 6, 1, 0),
+SOC_SINGLE("Mono Playback Switch", WM8974_MONOMIX, 6, 1, 1),
 };
 
-/* add non dapm controls */
-static int wm8974_add_controls(struct snd_soc_codec *codec)
-{
-       int err, i;
-
-       for (i = 0; i < ARRAY_SIZE(wm8974_snd_controls); i++) {
-               err = snd_ctl_add(codec->card,
-                                 snd_soc_cnew(&wm8974_snd_controls[i],
-                                              codec, NULL));
-               if (err < 0)
-                       return err;
-       }
-
-       return 0;
-}
-
 /* Speaker Output Mixer */
 static const struct snd_kcontrol_new wm8974_speaker_mixer_controls[] = {
 SOC_DAPM_SINGLE("Line Bypass Switch", WM8974_SPKMIX, 1, 1, 0),
@@ -232,7 +232,19 @@ SOC_DAPM_SINGLE("PCM Playback Switch", WM8974_SPKMIX, 0, 1, 1),
 static const struct snd_kcontrol_new wm8974_mono_mixer_controls[] = {
 SOC_DAPM_SINGLE("Line Bypass Switch", WM8974_MONOMIX, 1, 1, 0),
 SOC_DAPM_SINGLE("Aux Playback Switch", WM8974_MONOMIX, 2, 1, 0),
-SOC_DAPM_SINGLE("PCM Playback Switch", WM8974_MONOMIX, 0, 1, 1),
+SOC_DAPM_SINGLE("PCM Playback Switch", WM8974_MONOMIX, 0, 1, 0),
+};
+
+/* Boost mixer */
+static const struct snd_kcontrol_new wm8974_boost_mixer[] = {
+SOC_DAPM_SINGLE("Aux Switch", WM8974_INPPGA, 6, 1, 0),
+};
+
+/* Input PGA */
+static const struct snd_kcontrol_new wm8974_inpga[] = {
+SOC_DAPM_SINGLE("Aux Switch", WM8974_INPUT, 2, 1, 0),
+SOC_DAPM_SINGLE("MicN Switch", WM8974_INPUT, 1, 1, 0),
+SOC_DAPM_SINGLE("MicP Switch", WM8974_INPUT, 0, 1, 0),
 };
 
 /* AUX Input boost vol */
@@ -243,22 +255,6 @@ SOC_DAPM_SINGLE("Aux Volume", WM8974_ADCBOOST, 0, 7, 0);
 static const struct snd_kcontrol_new wm8974_mic_boost_controls =
 SOC_DAPM_SINGLE("Mic Volume", WM8974_ADCBOOST, 4, 7, 0);
 
-/* Capture boost switch */
-static const struct snd_kcontrol_new wm8974_capture_boost_controls =
-SOC_DAPM_SINGLE("Capture Boost Switch", WM8974_INPPGA,  6, 1, 0);
-
-/* Aux In to PGA */
-static const struct snd_kcontrol_new wm8974_aux_capture_boost_controls =
-SOC_DAPM_SINGLE("Aux Capture Boost Switch", WM8974_INPPGA,  2, 1, 0);
-
-/* Mic P In to PGA */
-static const struct snd_kcontrol_new wm8974_micp_capture_boost_controls =
-SOC_DAPM_SINGLE("Mic P Capture Boost Switch", WM8974_INPPGA,  0, 1, 0);
-
-/* Mic N In to PGA */
-static const struct snd_kcontrol_new wm8974_micn_capture_boost_controls =
-SOC_DAPM_SINGLE("Mic N Capture Boost Switch", WM8974_INPPGA,  1, 1, 0);
-
 static const struct snd_soc_dapm_widget wm8974_dapm_widgets[] = {
 SND_SOC_DAPM_MIXER("Speaker Mixer", WM8974_POWER3, 2, 0,
        &wm8974_speaker_mixer_controls[0],
@@ -267,21 +263,16 @@ SND_SOC_DAPM_MIXER("Mono Mixer", WM8974_POWER3, 3, 0,
        &wm8974_mono_mixer_controls[0],
        ARRAY_SIZE(wm8974_mono_mixer_controls)),
 SND_SOC_DAPM_DAC("DAC", "HiFi Playback", WM8974_POWER3, 0, 0),
-SND_SOC_DAPM_ADC("ADC", "HiFi Capture", WM8974_POWER3, 0, 0),
+SND_SOC_DAPM_ADC("ADC", "HiFi Capture", WM8974_POWER2, 0, 0),
 SND_SOC_DAPM_PGA("Aux Input", WM8974_POWER1, 6, 0, NULL, 0),
 SND_SOC_DAPM_PGA("SpkN Out", WM8974_POWER3, 5, 0, NULL, 0),
 SND_SOC_DAPM_PGA("SpkP Out", WM8974_POWER3, 6, 0, NULL, 0),
 SND_SOC_DAPM_PGA("Mono Out", WM8974_POWER3, 7, 0, NULL, 0),
-SND_SOC_DAPM_PGA("Mic PGA", WM8974_POWER2, 2, 0, NULL, 0),
-
-SND_SOC_DAPM_PGA("Aux Boost", SND_SOC_NOPM, 0, 0,
-       &wm8974_aux_boost_controls, 1),
-SND_SOC_DAPM_PGA("Mic Boost", SND_SOC_NOPM, 0, 0,
-       &wm8974_mic_boost_controls, 1),
-SND_SOC_DAPM_SWITCH("Capture Boost", SND_SOC_NOPM, 0, 0,
-       &wm8974_capture_boost_controls),
 
-SND_SOC_DAPM_MIXER("Boost Mixer", WM8974_POWER2, 4, 0, NULL, 0),
+SND_SOC_DAPM_MIXER("Input PGA", WM8974_POWER2, 2, 0, wm8974_inpga,
+                  ARRAY_SIZE(wm8974_inpga)),
+SND_SOC_DAPM_MIXER("Boost Mixer", WM8974_POWER2, 4, 0,
+                  wm8974_boost_mixer, ARRAY_SIZE(wm8974_boost_mixer)),
 
 SND_SOC_DAPM_MICBIAS("Mic Bias", WM8974_POWER1, 4, 0),
 
@@ -313,17 +304,18 @@ static const struct snd_soc_dapm_route audio_map[] = {
        {"SPKOUTP", NULL, "SpkP Out"},
 
        /* Boost Mixer */
-       {"Boost Mixer", NULL, "ADC"},
-       {"Capture Boost Switch", "Aux Capture Boost Switch", "AUX"},
-       {"Aux Boost", "Aux Volume", "Boost Mixer"},
-       {"Capture Boost", "Capture Switch", "Boost Mixer"},
-       {"Mic Boost", "Mic Volume", "Boost Mixer"},
+       {"ADC", NULL, "Boost Mixer"},
+       {"Boost Mixer", "Aux Switch", "Aux Input"},
+       {"Boost Mixer", NULL, "Input PGA"},
+       {"Boost Mixer", NULL, "MICP"},
+
+       /* Input PGA */
+       {"Input PGA", "Aux Switch", "Aux Input"},
+       {"Input PGA", "MicN Switch", "MICN"},
+       {"Input PGA", "MicP Switch", "MICP"},
 
        /* Inputs */
-       {"MICP", NULL, "Mic Boost"},
-       {"MICN", NULL, "Mic PGA"},
-       {"Mic PGA", NULL, "Capture Boost"},
-       {"AUX", NULL, "Aux Input"},
+       {"Aux Input", NULL, "AUX"},
 };
 
 static int wm8974_add_widgets(struct snd_soc_codec *codec)
@@ -338,51 +330,87 @@ static int wm8974_add_widgets(struct snd_soc_codec *codec)
 }
 
 struct pll_ {
-       unsigned int in_hz, out_hz;
-       unsigned int pre:4; /* prescale - 1 */
+       unsigned int pre_div:1;
        unsigned int n:4;
        unsigned int k;
 };
 
-static struct pll_ pll[] = {
-       { 12000000, 11289600, 0, 7, 0x86c220 },
-       { 12000000, 12288000, 0, 8, 0x3126e8 },
-       { 13000000, 11289600, 0, 6, 0xf28bd4 },
-       { 13000000, 12288000, 0, 7, 0x8fd525 },
-       { 12288000, 11289600, 0, 7, 0x59999a },
-       { 11289600, 12288000, 0, 8, 0x80dee9 },
-       { 25000000, 11289600, 1, 7, 0x39B024 },
-       { 25000000, 24576000, 1, 7, 0xdd4413 }
-};
+/* The size in bits of the pll divide multiplied by 10
+ * to allow rounding later */
+#define FIXED_PLL_SIZE ((1 << 24) * 10)
+
+static void pll_factors(struct pll_ *pll_div,
+                       unsigned int target, unsigned int source)
+{
+       unsigned long long Kpart;
+       unsigned int K, Ndiv, Nmod;
+
+       /* There is a fixed divide by 4 in the output path */
+       target *= 4;
+
+       Ndiv = target / source;
+       if (Ndiv < 6) {
+               source /= 2;
+               pll_div->pre_div = 1;
+               Ndiv = target / source;
+       } else
+               pll_div->pre_div = 0;
+
+       if ((Ndiv < 6) || (Ndiv > 12))
+               printk(KERN_WARNING
+                       "WM8974 N value %u outwith recommended range!\n",
+                       Ndiv);
+
+       pll_div->n = Ndiv;
+       Nmod = target % source;
+       Kpart = FIXED_PLL_SIZE * (long long)Nmod;
+
+       do_div(Kpart, source);
+
+       K = Kpart & 0xFFFFFFFF;
+
+       /* Check if we need to round */
+       if ((K % 10) >= 5)
+               K += 5;
+
+       /* Move down to proper range now rounding is done */
+       K /= 10;
+
+       pll_div->k = K;
+}
 
 static int wm8974_set_dai_pll(struct snd_soc_dai *codec_dai,
                int pll_id, unsigned int freq_in, unsigned int freq_out)
 {
        struct snd_soc_codec *codec = codec_dai->codec;
-       int i;
+       struct pll_ pll_div;
        u16 reg;
 
        if (freq_in == 0 || freq_out == 0) {
+               /* Clock CODEC directly from MCLK */
+               reg = wm8974_read_reg_cache(codec, WM8974_CLOCK);
+               wm8974_write(codec, WM8974_CLOCK, reg & 0x0ff);
+
+               /* Turn off PLL */
                reg = wm8974_read_reg_cache(codec, WM8974_POWER1);
                wm8974_write(codec, WM8974_POWER1, reg & 0x1df);
                return 0;
        }
 
-       for (i = 0; i < ARRAY_SIZE(pll); i++) {
-               if (freq_in == pll[i].in_hz && freq_out == pll[i].out_hz) {
-                       wm8974_write(codec, WM8974_PLLN,
-                                    (pll[i].pre << 4) | pll[i].n);
-                       wm8974_write(codec, WM8974_PLLK1, pll[i].k >> 18);
-                       wm8974_write(codec, WM8974_PLLK2,
-                                    (pll[i].k >> 9) & 0x1ff);
-                       wm8974_write(codec, WM8974_PLLK3, pll[i].k & 0x1ff);
-                       reg = wm8974_read_reg_cache(codec, WM8974_POWER1);
-                       wm8974_write(codec, WM8974_POWER1, reg | 0x020);
-                       return 0;
-               }
-       }
+       pll_factors(&pll_div, freq_out, freq_in);
+
+       wm8974_write(codec, WM8974_PLLN, (pll_div.pre_div << 4) | pll_div.n);
+       wm8974_write(codec, WM8974_PLLK1, pll_div.k >> 18);
+       wm8974_write(codec, WM8974_PLLK2, (pll_div.k >> 9) & 0x1ff);
+       wm8974_write(codec, WM8974_PLLK3, pll_div.k & 0x1ff);
+       reg = wm8974_read_reg_cache(codec, WM8974_POWER1);
+       wm8974_write(codec, WM8974_POWER1, reg | 0x020);
 
-       return -EINVAL;
+       /* Run CODEC from PLL instead of MCLK */
+       reg = wm8974_read_reg_cache(codec, WM8974_CLOCK);
+       wm8974_write(codec, WM8974_CLOCK, reg | 0x100);
+
+       return 0;
 }
 
 /*
@@ -520,6 +548,7 @@ static int wm8974_pcm_hw_params(struct snd_pcm_substream *substream,
                adn |= 0x1 << 1;
                break;
        case SNDRV_PCM_RATE_44100:
+       case SNDRV_PCM_RATE_48000:
                break;
        }
 
@@ -544,22 +573,35 @@ static int wm8974_mute(struct snd_soc_dai *dai, int mute)
 static int wm8974_set_bias_level(struct snd_soc_codec *codec,
        enum snd_soc_bias_level level)
 {
+       u16 power1 = wm8974_read_reg_cache(codec, WM8974_POWER1) & ~0x3;
+
        switch (level) {
        case SND_SOC_BIAS_ON:
-               wm8974_write(codec, WM8974_POWER1, 0x1ff);
-               wm8974_write(codec, WM8974_POWER2, 0x1ff);
-               wm8974_write(codec, WM8974_POWER3, 0x1ff);
-               break;
        case SND_SOC_BIAS_PREPARE:
+               power1 |= 0x1;  /* VMID 50k */
+               wm8974_write(codec, WM8974_POWER1, power1);
                break;
+
        case SND_SOC_BIAS_STANDBY:
+               power1 |= WM8974_POWER1_BIASEN | WM8974_POWER1_BUFIOEN;
+
+               if (codec->bias_level == SND_SOC_BIAS_OFF) {
+                       /* Initial cap charge at VMID 5k */
+                       wm8974_write(codec, WM8974_POWER1, power1 | 0x3);
+                       mdelay(100);
+               }
+
+               power1 |= 0x2;  /* VMID 500k */
+               wm8974_write(codec, WM8974_POWER1, power1);
                break;
+
        case SND_SOC_BIAS_OFF:
-               wm8974_write(codec, WM8974_POWER1, 0x0);
-               wm8974_write(codec, WM8974_POWER2, 0x0);
-               wm8974_write(codec, WM8974_POWER3, 0x0);
+               wm8974_write(codec, WM8974_POWER1, 0);
+               wm8974_write(codec, WM8974_POWER2, 0);
+               wm8974_write(codec, WM8974_POWER3, 0);
                break;
        }
+
        codec->bias_level = level;
        return 0;
 }
@@ -582,16 +624,17 @@ struct snd_soc_dai wm8974_dai = {
        .playback = {
                .stream_name = "Playback",
                .channels_min = 1,
-               .channels_max = 1,
+               .channels_max = 2,   /* Only 1 channel of data */
                .rates = WM8974_RATES,
                .formats = WM8974_FORMATS,},
        .capture = {
                .stream_name = "Capture",
                .channels_min = 1,
-               .channels_max = 1,
+               .channels_max = 2,   /* Only 1 channel of data */
                .rates = WM8974_RATES,
                .formats = WM8974_FORMATS,},
        .ops = &wm8974_ops,
+       .symmetric_rates = 1,
 };
 EXPORT_SYMBOL_GPL(wm8974_dai);
 
@@ -623,217 +666,182 @@ static int wm8974_resume(struct platform_device *pdev)
        return 0;
 }
 
-/*
- * initialise the WM8974 driver
- * register the mixer and dsp interfaces with the kernel
- */
-static int wm8974_init(struct snd_soc_device *socdev)
+static int wm8974_probe(struct platform_device *pdev)
 {
-       struct snd_soc_codec *codec = socdev->card->codec;
+       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
+       struct snd_soc_codec *codec;
        int ret = 0;
 
-       codec->name = "WM8974";
-       codec->owner = THIS_MODULE;
-       codec->read = wm8974_read_reg_cache;
-       codec->write = wm8974_write;
-       codec->set_bias_level = wm8974_set_bias_level;
-       codec->dai = &wm8974_dai;
-       codec->num_dai = 1;
-       codec->reg_cache_size = ARRAY_SIZE(wm8974_reg);
-       codec->reg_cache = kmemdup(wm8974_reg, sizeof(wm8974_reg), GFP_KERNEL);
-
-       if (codec->reg_cache == NULL)
-               return -ENOMEM;
+       if (wm8974_codec == NULL) {
+               dev_err(&pdev->dev, "Codec device not registered\n");
+               return -ENODEV;
+       }
 
-       wm8974_reset(codec);
+       socdev->card->codec = wm8974_codec;
+       codec = wm8974_codec;
 
        /* register pcms */
        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
        if (ret < 0) {
-               printk(KERN_ERR "wm8974: failed to create pcms\n");
+               dev_err(codec->dev, "failed to create pcms: %d\n", ret);
                goto pcm_err;
        }
 
-       /* power on device */
-       wm8974_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       wm8974_add_controls(codec);
+       snd_soc_add_controls(codec, wm8974_snd_controls,
+                            ARRAY_SIZE(wm8974_snd_controls));
        wm8974_add_widgets(codec);
        ret = snd_soc_init_card(socdev);
        if (ret < 0) {
-               printk(KERN_ERR "wm8974: failed to register card\n");
+               dev_err(codec->dev, "failed to register card: %d\n", ret);
                goto card_err;
        }
+
        return ret;
 
 card_err:
        snd_soc_free_pcms(socdev);
        snd_soc_dapm_free(socdev);
 pcm_err:
-       kfree(codec->reg_cache);
        return ret;
 }
 
-static struct snd_soc_device *wm8974_socdev;
-
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
-
-/*
- * WM8974 2 wire address is 0x1a
- */
-#define I2C_DRIVERID_WM8974 0xfefe /* liam -  need a proper id */
-
-static unsigned short normal_i2c[] = { 0, I2C_CLIENT_END };
+/* power down chip */
+static int wm8974_remove(struct platform_device *pdev)
+{
+       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
 
-/* Magic definition of all other variables and things */
-I2C_CLIENT_INSMOD;
+       snd_soc_free_pcms(socdev);
+       snd_soc_dapm_free(socdev);
 
-static struct i2c_driver wm8974_i2c_driver;
-static struct i2c_client client_template;
+       return 0;
+}
 
-/* If the i2c layer weren't so broken, we could pass this kind of data
-   around */
+struct snd_soc_codec_device soc_codec_dev_wm8974 = {
+       .probe =        wm8974_probe,
+       .remove =       wm8974_remove,
+       .suspend =      wm8974_suspend,
+       .resume =       wm8974_resume,
+};
+EXPORT_SYMBOL_GPL(soc_codec_dev_wm8974);
 
-static int wm8974_codec_probe(struct i2c_adapter *adap, int addr, int kind)
+static __devinit int wm8974_register(struct wm8974_priv *wm8974)
 {
-       struct snd_soc_device *socdev = wm8974_socdev;
-       struct wm8974_setup_data *setup = socdev->codec_data;
-       struct snd_soc_codec *codec = socdev->card->codec;
-       struct i2c_client *i2c;
        int ret;
+       struct snd_soc_codec *codec = &wm8974->codec;
 
-       if (addr != setup->i2c_address)
-               return -ENODEV;
+       if (wm8974_codec) {
+               dev_err(codec->dev, "Another WM8974 is registered\n");
+               return -EINVAL;
+       }
 
-       client_template.adapter = adap;
-       client_template.addr = addr;
+       mutex_init(&codec->mutex);
+       INIT_LIST_HEAD(&codec->dapm_widgets);
+       INIT_LIST_HEAD(&codec->dapm_paths);
 
-       i2c = kmemdup(&client_template, sizeof(client_template), GFP_KERNEL);
-       if (i2c == NULL) {
-               kfree(codec);
-               return -ENOMEM;
-       }
-       i2c_set_clientdata(i2c, codec);
-       codec->control_data = i2c;
+       codec->private_data = wm8974;
+       codec->name = "WM8974";
+       codec->owner = THIS_MODULE;
+       codec->read = wm8974_read_reg_cache;
+       codec->write = wm8974_write;
+       codec->bias_level = SND_SOC_BIAS_OFF;
+       codec->set_bias_level = wm8974_set_bias_level;
+       codec->dai = &wm8974_dai;
+       codec->num_dai = 1;
+       codec->reg_cache_size = WM8974_CACHEREGNUM;
+       codec->reg_cache = &wm8974->reg_cache;
+
+       memcpy(codec->reg_cache, wm8974_reg, sizeof(wm8974_reg));
 
-       ret = i2c_attach_client(i2c);
+       ret = wm8974_reset(codec);
        if (ret < 0) {
-               pr_err("failed to attach codec at addr %x\n", addr);
-               goto err;
+               dev_err(codec->dev, "Failed to issue reset\n");
+               return ret;
        }
 
-       ret = wm8974_init(socdev);
-       if (ret < 0) {
-               pr_err("failed to initialise WM8974\n");
-               goto err;
+       wm8974_dai.dev = codec->dev;
+
+       wm8974_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+
+       wm8974_codec = codec;
+
+       ret = snd_soc_register_codec(codec);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to register codec: %d\n", ret);
+               return ret;
        }
-       return ret;
 
-err:
-       kfree(codec);
-       kfree(i2c);
-       return ret;
-}
+       ret = snd_soc_register_dai(&wm8974_dai);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to register DAI: %d\n", ret);
+               snd_soc_unregister_codec(codec);
+               return ret;
+       }
 
-static int wm8974_i2c_detach(struct i2c_client *client)
-{
-       struct snd_soc_codec *codec = i2c_get_clientdata(client);
-       i2c_detach_client(client);
-       kfree(codec->reg_cache);
-       kfree(client);
        return 0;
 }
 
-static int wm8974_i2c_attach(struct i2c_adapter *adap)
+static __devexit void wm8974_unregister(struct wm8974_priv *wm8974)
 {
-       return i2c_probe(adap, &addr_data, wm8974_codec_probe);
+       wm8974_set_bias_level(&wm8974->codec, SND_SOC_BIAS_OFF);
+       snd_soc_unregister_dai(&wm8974_dai);
+       snd_soc_unregister_codec(&wm8974->codec);
+       kfree(wm8974);
+       wm8974_codec = NULL;
 }
 
-/* corgi i2c codec control layer */
-static struct i2c_driver wm8974_i2c_driver = {
-       .driver = {
-               .name = "WM8974 I2C Codec",
-               .owner = THIS_MODULE,
-       },
-       .id =             I2C_DRIVERID_WM8974,
-       .attach_adapter = wm8974_i2c_attach,
-       .detach_client =  wm8974_i2c_detach,
-       .command =        NULL,
-};
-
-static struct i2c_client client_template = {
-       .name =   "WM8974",
-       .driver = &wm8974_i2c_driver,
-};
-#endif
-
-static int wm8974_probe(struct platform_device *pdev)
+static __devinit int wm8974_i2c_probe(struct i2c_client *i2c,
+                                     const struct i2c_device_id *id)
 {
-       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct wm8974_setup_data *setup;
+       struct wm8974_priv *wm8974;
        struct snd_soc_codec *codec;
-       int ret = 0;
 
-       setup = socdev->codec_data;
-       codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL);
-       if (codec == NULL)
+       wm8974 = kzalloc(sizeof(struct wm8974_priv), GFP_KERNEL);
+       if (wm8974 == NULL)
                return -ENOMEM;
 
-       socdev->card->codec = codec;
-       mutex_init(&codec->mutex);
-       INIT_LIST_HEAD(&codec->dapm_widgets);
-       INIT_LIST_HEAD(&codec->dapm_paths);
-
-       wm8974_socdev = socdev;
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
-       if (setup->i2c_address) {
-               normal_i2c[0] = setup->i2c_address;
-               codec->hw_write = (hw_write_t)i2c_master_send;
-               ret = i2c_add_driver(&wm8974_i2c_driver);
-               if (ret != 0)
-                       printk(KERN_ERR "can't add i2c driver");
-       }
-#else
-       /* Add other interfaces here */
-#endif
-       return ret;
-}
+       codec = &wm8974->codec;
+       codec->hw_write = (hw_write_t)i2c_master_send;
 
-/* power down chip */
-static int wm8974_remove(struct platform_device *pdev)
-{
-       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct snd_soc_codec *codec = socdev->card->codec;
+       i2c_set_clientdata(i2c, wm8974);
+       codec->control_data = i2c;
 
-       if (codec->control_data)
-               wm8974_set_bias_level(codec, SND_SOC_BIAS_OFF);
+       codec->dev = &i2c->dev;
 
-       snd_soc_free_pcms(socdev);
-       snd_soc_dapm_free(socdev);
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
-       i2c_del_driver(&wm8974_i2c_driver);
-#endif
-       kfree(codec);
+       return wm8974_register(wm8974);
+}
 
+static __devexit int wm8974_i2c_remove(struct i2c_client *client)
+{
+       struct wm8974_priv *wm8974 = i2c_get_clientdata(client);
+       wm8974_unregister(wm8974);
        return 0;
 }
 
-struct snd_soc_codec_device soc_codec_dev_wm8974 = {
-       .probe =        wm8974_probe,
-       .remove =       wm8974_remove,
-       .suspend =      wm8974_suspend,
-       .resume =       wm8974_resume,
+static const struct i2c_device_id wm8974_i2c_id[] = {
+       { "wm8974", 0 },
+       { }
+};
+MODULE_DEVICE_TABLE(i2c, wm8974_i2c_id);
+
+static struct i2c_driver wm8974_i2c_driver = {
+       .driver = {
+               .name = "WM8974",
+               .owner = THIS_MODULE,
+       },
+       .probe =    wm8974_i2c_probe,
+       .remove =   __devexit_p(wm8974_i2c_remove),
+       .id_table = wm8974_i2c_id,
 };
-EXPORT_SYMBOL_GPL(soc_codec_dev_wm8974);
 
 static int __init wm8974_modinit(void)
 {
-       return snd_soc_register_dai(&wm8974_dai);
+       return i2c_add_driver(&wm8974_i2c_driver);
 }
 module_init(wm8974_modinit);
 
 static void __exit wm8974_exit(void)
 {
-       snd_soc_unregister_dai(&wm8974_dai);
+       i2c_del_driver(&wm8974_i2c_driver);
 }
 module_exit(wm8974_exit);