cfg80211: report userspace SME connected event properly
[pandora-kernel.git] / net / wireless / sme.c
index df9173f..6fb6a70 100644 (file)
@@ -8,9 +8,12 @@
 #include <linux/etherdevice.h>
 #include <linux/if_arp.h>
 #include <linux/workqueue.h>
+#include <linux/wireless.h>
+#include <net/iw_handler.h>
 #include <net/cfg80211.h>
 #include <net/rtnetlink.h>
 #include "nl80211.h"
+#include "reg.h"
 
 struct cfg80211_conn {
        struct cfg80211_connect_params params;
@@ -24,10 +27,10 @@ struct cfg80211_conn {
                CFG80211_CONN_ASSOCIATE_NEXT,
                CFG80211_CONN_ASSOCIATING,
        } state;
-       u8 bssid[ETH_ALEN];
+       u8 bssid[ETH_ALEN], prev_bssid[ETH_ALEN];
        u8 *ie;
        size_t ie_len;
-       bool auto_auth;
+       bool auto_auth, prev_bssid_valid;
 };
 
 
@@ -62,7 +65,6 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev)
        if (!request)
                return -ENOMEM;
 
-       request->channels = (void *)((char *)request + sizeof(*request));
        if (wdev->conn->params.channel)
                request->channels[0] = wdev->conn->params.channel;
        else {
@@ -79,14 +81,14 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev)
                }
        }
        request->n_channels = n_channels;
-       request->ssids = (void *)(request->channels + n_channels);
+       request->ssids = (void *)&request->channels[n_channels];
        request->n_ssids = 1;
 
        memcpy(request->ssids[0].ssid, wdev->conn->params.ssid,
                wdev->conn->params.ssid_len);
        request->ssids[0].ssid_len = wdev->conn->params.ssid_len;
 
-       request->ifidx = wdev->netdev->ifindex;
+       request->dev = wdev->netdev;
        request->wiphy = &rdev->wiphy;
 
        rdev->scan_req = request;
@@ -95,6 +97,7 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev)
        if (!err) {
                wdev->conn->state = CFG80211_CONN_SCANNING;
                nl80211_send_scan_start(rdev, wdev->netdev);
+               dev_hold(wdev->netdev);
        } else {
                rdev->scan_req = NULL;
                kfree(request);
@@ -106,6 +109,7 @@ static int cfg80211_conn_do_work(struct wireless_dev *wdev)
 {
        struct cfg80211_registered_device *rdev = wiphy_to_dev(wdev->wiphy);
        struct cfg80211_connect_params *params;
+       const u8 *prev_bssid = NULL;
        int err;
 
        ASSERT_WDEV_LOCK(wdev);
@@ -125,19 +129,17 @@ static int cfg80211_conn_do_work(struct wireless_dev *wdev)
                                            params->channel, params->auth_type,
                                            params->bssid,
                                            params->ssid, params->ssid_len,
-                                           NULL, 0);
+                                           NULL, 0,
+                                           params->key, params->key_len,
+                                           params->key_idx);
        case CFG80211_CONN_ASSOCIATE_NEXT:
                BUG_ON(!rdev->ops->assoc);
                wdev->conn->state = CFG80211_CONN_ASSOCIATING;
-               /*
-                * We could, later, implement roaming here and then actually
-                * set prev_bssid to non-NULL. But then we need to be aware
-                * that some APs don't like that -- so we'd need to retry
-                * the association.
-                */
+               if (wdev->conn->prev_bssid_valid)
+                       prev_bssid = wdev->conn->prev_bssid;
                err = __cfg80211_mlme_assoc(rdev, wdev->netdev,
                                            params->channel, params->bssid,
-                                           NULL,
+                                           prev_bssid,
                                            params->ssid, params->ssid_len,
                                            params->ie, params->ie_len,
                                            false, &params->crypto);
@@ -177,7 +179,7 @@ void cfg80211_conn_work(struct work_struct *work)
                                        wdev->conn->params.bssid,
                                        NULL, 0, NULL, 0,
                                        WLAN_STATUS_UNSPECIFIED_FAILURE,
-                                       false);
+                                       false, NULL);
                wdev_unlock(wdev);
        }
 
@@ -225,7 +227,7 @@ static void __cfg80211_sme_scan_done(struct net_device *dev)
        if (wdev->sme_state != CFG80211_SME_CONNECTING)
                return;
 
-       if (WARN_ON(!wdev->conn))
+       if (!wdev->conn)
                return;
 
        if (wdev->conn->state != CFG80211_CONN_SCANNING &&
@@ -242,7 +244,7 @@ static void __cfg80211_sme_scan_done(struct net_device *dev)
                                        wdev->conn->params.bssid,
                                        NULL, 0, NULL, 0,
                                        WLAN_STATUS_UNSPECIFIED_FAILURE,
-                                       false);
+                                       false, NULL);
        }
 }
 
@@ -250,9 +252,11 @@ void cfg80211_sme_scan_done(struct net_device *dev)
 {
        struct wireless_dev *wdev = dev->ieee80211_ptr;
 
+       mutex_lock(&wiphy_to_dev(wdev->wiphy)->devlist_mtx);
        wdev_lock(wdev);
        __cfg80211_sme_scan_done(dev);
        wdev_unlock(wdev);
+       mutex_unlock(&wiphy_to_dev(wdev->wiphy)->devlist_mtx);
 }
 
 void cfg80211_sme_rx_auth(struct net_device *dev,
@@ -279,8 +283,12 @@ void cfg80211_sme_rx_auth(struct net_device *dev,
                /* select automatically between only open, shared, leap */
                switch (wdev->conn->params.auth_type) {
                case NL80211_AUTHTYPE_OPEN_SYSTEM:
-                       wdev->conn->params.auth_type =
-                               NL80211_AUTHTYPE_SHARED_KEY;
+                       if (wdev->connect_keys)
+                               wdev->conn->params.auth_type =
+                                       NL80211_AUTHTYPE_SHARED_KEY;
+                       else
+                               wdev->conn->params.auth_type =
+                                       NL80211_AUTHTYPE_NETWORK_EAP;
                        break;
                case NL80211_AUTHTYPE_SHARED_KEY:
                        wdev->conn->params.auth_type =
@@ -295,9 +303,8 @@ void cfg80211_sme_rx_auth(struct net_device *dev,
                wdev->conn->state = CFG80211_CONN_AUTHENTICATE_NEXT;
                schedule_work(&rdev->conn_work);
        } else if (status_code != WLAN_STATUS_SUCCESS) {
-               wdev->sme_state = CFG80211_SME_IDLE;
-               kfree(wdev->conn);
-               wdev->conn = NULL;
+               __cfg80211_connect_result(dev, mgmt->bssid, NULL, 0, NULL, 0,
+                                         status_code, false, NULL);
        } else if (wdev->sme_state == CFG80211_SME_CONNECTING &&
                 wdev->conn->state == CFG80211_CONN_AUTHENTICATING) {
                wdev->conn->state = CFG80211_CONN_ASSOCIATE_NEXT;
@@ -305,13 +312,36 @@ void cfg80211_sme_rx_auth(struct net_device *dev,
        }
 }
 
+bool cfg80211_sme_failed_reassoc(struct wireless_dev *wdev)
+{
+       struct wiphy *wiphy = wdev->wiphy;
+       struct cfg80211_registered_device *rdev = wiphy_to_dev(wiphy);
+
+       if (WARN_ON(!wdev->conn))
+               return false;
+
+       if (!wdev->conn->prev_bssid_valid)
+               return false;
+
+       /*
+        * Some stupid APs don't accept reassoc, so we
+        * need to fall back to trying regular assoc.
+        */
+       wdev->conn->prev_bssid_valid = false;
+       wdev->conn->state = CFG80211_CONN_ASSOCIATE_NEXT;
+       schedule_work(&rdev->conn_work);
+
+       return true;
+}
+
 void __cfg80211_connect_result(struct net_device *dev, const u8 *bssid,
                               const u8 *req_ie, size_t req_ie_len,
                               const u8 *resp_ie, size_t resp_ie_len,
-                              u16 status, bool wextev)
+                              u16 status, bool wextev,
+                              struct cfg80211_bss *bss)
 {
        struct wireless_dev *wdev = dev->ieee80211_ptr;
-       struct cfg80211_bss *bss;
+       u8 *country_ie;
 #ifdef CONFIG_WIRELESS_EXT
        union iwreq_data wrqu;
 #endif
@@ -321,22 +351,20 @@ void __cfg80211_connect_result(struct net_device *dev, const u8 *bssid,
        if (WARN_ON(wdev->iftype != NL80211_IFTYPE_STATION))
                return;
 
-       if (wdev->sme_state == CFG80211_SME_CONNECTED)
-               nl80211_send_roamed(wiphy_to_dev(wdev->wiphy), dev,
+       if (WARN_ON(wdev->sme_state != CFG80211_SME_CONNECTING))
+               return;
+
+       nl80211_send_connect_result(wiphy_to_dev(wdev->wiphy), dev,
                                    bssid, req_ie, req_ie_len,
-                                   resp_ie, resp_ie_len, GFP_KERNEL);
-       else
-               nl80211_send_connect_result(wiphy_to_dev(wdev->wiphy), dev,
-                                           bssid, req_ie, req_ie_len,
-                                           resp_ie, resp_ie_len,
-                                           status, GFP_KERNEL);
+                                   resp_ie, resp_ie_len,
+                                   status, GFP_KERNEL);
 
 #ifdef CONFIG_WIRELESS_EXT
        if (wextev) {
                if (req_ie && status == WLAN_STATUS_SUCCESS) {
                        memset(&wrqu, 0, sizeof(wrqu));
                        wrqu.data.length = req_ie_len;
-                       wireless_send_event(dev, IWEVASSOCRESPIE, &wrqu, req_ie);
+                       wireless_send_event(dev, IWEVASSOCREQIE, &wrqu, req_ie);
                }
 
                if (resp_ie && status == WLAN_STATUS_SUCCESS) {
@@ -347,21 +375,15 @@ void __cfg80211_connect_result(struct net_device *dev, const u8 *bssid,
 
                memset(&wrqu, 0, sizeof(wrqu));
                wrqu.ap_addr.sa_family = ARPHRD_ETHER;
-               if (bssid && status == WLAN_STATUS_SUCCESS)
+               if (bssid && status == WLAN_STATUS_SUCCESS) {
                        memcpy(wrqu.ap_addr.sa_data, bssid, ETH_ALEN);
+                       memcpy(wdev->wext.prev_bssid, bssid, ETH_ALEN);
+                       wdev->wext.prev_bssid_valid = true;
+               }
                wireless_send_event(dev, SIOCGIWAP, &wrqu, NULL);
        }
 #endif
 
-       if (status == WLAN_STATUS_SUCCESS &&
-           wdev->sme_state == CFG80211_SME_IDLE) {
-               wdev->sme_state = CFG80211_SME_CONNECTED;
-               return;
-       }
-
-       if (wdev->sme_state != CFG80211_SME_CONNECTING)
-               return;
-
        if (wdev->current_bss) {
                cfg80211_unhold_bss(wdev->current_bss);
                cfg80211_put_bss(&wdev->current_bss->pub);
@@ -371,24 +393,44 @@ void __cfg80211_connect_result(struct net_device *dev, const u8 *bssid,
        if (wdev->conn)
                wdev->conn->state = CFG80211_CONN_IDLE;
 
-       if (status == WLAN_STATUS_SUCCESS) {
+       if (status != WLAN_STATUS_SUCCESS) {
+               wdev->sme_state = CFG80211_SME_IDLE;
+               kfree(wdev->conn);
+               wdev->conn = NULL;
+               kfree(wdev->connect_keys);
+               wdev->connect_keys = NULL;
+               wdev->ssid_len = 0;
+               return;
+       }
+
+       if (!bss)
                bss = cfg80211_get_bss(wdev->wiphy, NULL, bssid,
                                       wdev->ssid, wdev->ssid_len,
                                       WLAN_CAPABILITY_ESS,
                                       WLAN_CAPABILITY_ESS);
 
-               if (WARN_ON(!bss))
-                       return;
+       if (WARN_ON(!bss))
+               return;
 
-               cfg80211_hold_bss(bss_from_pub(bss));
-               wdev->current_bss = bss_from_pub(bss);
+       cfg80211_hold_bss(bss_from_pub(bss));
+       wdev->current_bss = bss_from_pub(bss);
 
-               wdev->sme_state = CFG80211_SME_CONNECTED;
-       } else {
-               wdev->sme_state = CFG80211_SME_IDLE;
-               kfree(wdev->conn);
-               wdev->conn = NULL;
-       }
+       wdev->sme_state = CFG80211_SME_CONNECTED;
+       cfg80211_upload_connect_keys(wdev);
+
+       country_ie = (u8 *) ieee80211_bss_get_ie(bss, WLAN_EID_COUNTRY);
+
+       if (!country_ie)
+               return;
+
+       /*
+        * ieee80211_bss_get_ie() ensures we can access:
+        * - country_ie + 2, the start of the country ie data, and
+        * - and country_ie[1] which is the IE length
+        */
+       regulatory_hint_11d(wdev->wiphy,
+                           country_ie + 2,
+                           country_ie[1]);
 }
 
 void cfg80211_connect_result(struct net_device *dev, const u8 *bssid,
@@ -466,7 +508,7 @@ void __cfg80211_roamed(struct wireless_dev *wdev, const u8 *bssid,
        if (req_ie) {
                memset(&wrqu, 0, sizeof(wrqu));
                wrqu.data.length = req_ie_len;
-               wireless_send_event(wdev->netdev, IWEVASSOCRESPIE,
+               wireless_send_event(wdev->netdev, IWEVASSOCREQIE,
                                    &wrqu, req_ie);
        }
 
@@ -480,6 +522,8 @@ void __cfg80211_roamed(struct wireless_dev *wdev, const u8 *bssid,
        memset(&wrqu, 0, sizeof(wrqu));
        wrqu.ap_addr.sa_family = ARPHRD_ETHER;
        memcpy(wrqu.ap_addr.sa_data, bssid, ETH_ALEN);
+       memcpy(wdev->wext.prev_bssid, bssid, ETH_ALEN);
+       wdev->wext.prev_bssid_valid = true;
        wireless_send_event(wdev->netdev, SIOCGIWAP, &wrqu, NULL);
 #endif
 }
@@ -517,6 +561,8 @@ void __cfg80211_disconnected(struct net_device *dev, const u8 *ie,
                             size_t ie_len, u16 reason, bool from_ap)
 {
        struct wireless_dev *wdev = dev->ieee80211_ptr;
+       struct cfg80211_registered_device *rdev = wiphy_to_dev(wdev->wiphy);
+       int i;
 #ifdef CONFIG_WIRELESS_EXT
        union iwreq_data wrqu;
 #endif
@@ -536,16 +582,44 @@ void __cfg80211_disconnected(struct net_device *dev, const u8 *ie,
 
        wdev->current_bss = NULL;
        wdev->sme_state = CFG80211_SME_IDLE;
+       wdev->ssid_len = 0;
 
        if (wdev->conn) {
+               const u8 *bssid;
+               int ret;
+
                kfree(wdev->conn->ie);
                wdev->conn->ie = NULL;
                kfree(wdev->conn);
                wdev->conn = NULL;
+
+               /*
+                * If this disconnect was due to a disassoc, we
+                * we might still have an auth BSS around. For
+                * the userspace SME that's currently expected,
+                * but for the kernel SME (nl80211 CONNECT or
+                * wireless extensions) we want to clear up all
+                * state.
+                */
+               for (i = 0; i < MAX_AUTH_BSSES; i++) {
+                       if (!wdev->auth_bsses[i])
+                               continue;
+                       bssid = wdev->auth_bsses[i]->pub.bssid;
+                       ret = __cfg80211_mlme_deauth(rdev, dev, bssid, NULL, 0,
+                                               WLAN_REASON_DEAUTH_LEAVING);
+                       WARN(ret, "deauth failed: %d\n", ret);
+               }
        }
 
-       nl80211_send_disconnected(wiphy_to_dev(wdev->wiphy), dev,
-                                 reason, ie, ie_len, from_ap);
+       nl80211_send_disconnected(rdev, dev, reason, ie, ie_len, from_ap);
+
+       /*
+        * Delete all the keys ... pairwise keys can't really
+        * exist any more anyway, but default keys might.
+        */
+       if (rdev->ops->del_key)
+               for (i = 0; i < 6; i++)
+                       rdev->ops->del_key(wdev->wiphy, dev, i, NULL);
 
 #ifdef CONFIG_WIRELESS_EXT
        memset(&wrqu, 0, sizeof(wrqu));
@@ -581,9 +655,12 @@ EXPORT_SYMBOL(cfg80211_disconnected);
 
 int __cfg80211_connect(struct cfg80211_registered_device *rdev,
                       struct net_device *dev,
-                      struct cfg80211_connect_params *connect)
+                      struct cfg80211_connect_params *connect,
+                      struct cfg80211_cached_keys *connkeys,
+                      const u8 *prev_bssid)
 {
        struct wireless_dev *wdev = dev->ieee80211_ptr;
+       struct ieee80211_channel *chan;
        int err;
 
        ASSERT_WDEV_LOCK(wdev);
@@ -591,6 +668,42 @@ int __cfg80211_connect(struct cfg80211_registered_device *rdev,
        if (wdev->sme_state != CFG80211_SME_IDLE)
                return -EALREADY;
 
+       chan = rdev_fixed_channel(rdev, wdev);
+       if (chan && chan != connect->channel)
+               return -EBUSY;
+
+       if (WARN_ON(wdev->connect_keys)) {
+               kfree(wdev->connect_keys);
+               wdev->connect_keys = NULL;
+       }
+
+       if (connkeys && connkeys->def >= 0) {
+               int idx;
+               u32 cipher;
+
+               idx = connkeys->def;
+               cipher = connkeys->params[idx].cipher;
+               /* If given a WEP key we may need it for shared key auth */
+               if (cipher == WLAN_CIPHER_SUITE_WEP40 ||
+                   cipher == WLAN_CIPHER_SUITE_WEP104) {
+                       connect->key_idx = idx;
+                       connect->key = connkeys->params[idx].key;
+                       connect->key_len = connkeys->params[idx].key_len;
+
+                       /*
+                        * If ciphers are not set (e.g. when going through
+                        * iwconfig), we have to set them appropriately here.
+                        */
+                       if (connect->crypto.cipher_group == 0)
+                               connect->crypto.cipher_group = cipher;
+
+                       if (connect->crypto.n_ciphers_pairwise == 0) {
+                               connect->crypto.n_ciphers_pairwise = 1;
+                               connect->crypto.ciphers_pairwise[0] = cipher;
+                       }
+               }
+       }
+
        if (!rdev->ops->connect) {
                if (!rdev->ops->auth || !rdev->ops->assoc)
                        return -EOPNOTSUPP;
@@ -641,6 +754,12 @@ int __cfg80211_connect(struct cfg80211_registered_device *rdev,
                        cfg80211_get_conn_bss(wdev);
 
                wdev->sme_state = CFG80211_SME_CONNECTING;
+               wdev->connect_keys = connkeys;
+
+               if (prev_bssid) {
+                       memcpy(wdev->conn->prev_bssid, prev_bssid, ETH_ALEN);
+                       wdev->conn->prev_bssid_valid = true;
+               }
 
                /* we're good if we have both BSSID and channel */
                if (wdev->conn->params.bssid && wdev->conn->params.channel) {
@@ -663,13 +782,17 @@ int __cfg80211_connect(struct cfg80211_registered_device *rdev,
                        kfree(wdev->conn);
                        wdev->conn = NULL;
                        wdev->sme_state = CFG80211_SME_IDLE;
+                       wdev->connect_keys = NULL;
+                       wdev->ssid_len = 0;
                }
 
                return err;
        } else {
                wdev->sme_state = CFG80211_SME_CONNECTING;
+               wdev->connect_keys = connkeys;
                err = rdev->ops->connect(&rdev->wiphy, dev, connect);
                if (err) {
+                       wdev->connect_keys = NULL;
                        wdev->sme_state = CFG80211_SME_IDLE;
                        return err;
                }
@@ -683,13 +806,16 @@ int __cfg80211_connect(struct cfg80211_registered_device *rdev,
 
 int cfg80211_connect(struct cfg80211_registered_device *rdev,
                     struct net_device *dev,
-                    struct cfg80211_connect_params *connect)
+                    struct cfg80211_connect_params *connect,
+                    struct cfg80211_cached_keys *connkeys)
 {
        int err;
 
+       mutex_lock(&rdev->devlist_mtx);
        wdev_lock(dev->ieee80211_ptr);
-       err = __cfg80211_connect(rdev, dev, connect);
+       err = __cfg80211_connect(rdev, dev, connect, connkeys, NULL);
        wdev_unlock(dev->ieee80211_ptr);
+       mutex_unlock(&rdev->devlist_mtx);
 
        return err;
 }
@@ -705,6 +831,9 @@ int __cfg80211_disconnect(struct cfg80211_registered_device *rdev,
        if (wdev->sme_state == CFG80211_SME_IDLE)
                return -EINVAL;
 
+       kfree(wdev->connect_keys);
+       wdev->connect_keys = NULL;
+
        if (!rdev->ops->disconnect) {
                if (!rdev->ops->deauth)
                        return -EOPNOTSUPP;
@@ -721,6 +850,7 @@ int __cfg80211_disconnect(struct cfg80211_registered_device *rdev,
                        wdev->sme_state = CFG80211_SME_IDLE;
                        kfree(wdev->conn);
                        wdev->conn = NULL;
+                       wdev->ssid_len = 0;
                        return 0;
                }
 
@@ -741,7 +871,7 @@ int __cfg80211_disconnect(struct cfg80211_registered_device *rdev,
        else if (wdev->sme_state == CFG80211_SME_CONNECTING)
                __cfg80211_connect_result(dev, NULL, NULL, 0, NULL, 0,
                                          WLAN_STATUS_UNSPECIFIED_FAILURE,
-                                         wextev);
+                                         wextev, NULL);
 
        return 0;
 }
@@ -782,8 +912,8 @@ void cfg80211_sme_disassoc(struct net_device *dev, int idx)
                return;
 
        memcpy(bssid, wdev->auth_bsses[idx]->pub.bssid, ETH_ALEN);
-       if (cfg80211_mlme_deauth(rdev, dev, bssid,
-                                NULL, 0, WLAN_REASON_DEAUTH_LEAVING)) {
+       if (__cfg80211_mlme_deauth(rdev, dev, bssid,
+                                  NULL, 0, WLAN_REASON_DEAUTH_LEAVING)) {
                /* whatever -- assume gone anyway */
                cfg80211_unhold_bss(wdev->auth_bsses[idx]);
                cfg80211_put_bss(&wdev->auth_bsses[idx]->pub);