cfg80211: fix deadlock
[pandora-kernel.git] / net / wireless / core.c
index 6891cd0..69a185b 100644 (file)
@@ -19,6 +19,7 @@
 #include "core.h"
 #include "sysfs.h"
 #include "debugfs.h"
+#include "wext-compat.h"
 
 /* name for sysfs, %d is appended */
 #define PHY_NAME "phy"
@@ -31,11 +32,10 @@ MODULE_DESCRIPTION("wireless configuration support");
  * only read the list, and that can happen quite
  * often because we need to do it for each command */
 LIST_HEAD(cfg80211_rdev_list);
+int cfg80211_rdev_list_generation;
 
 /*
- * This is used to protect the cfg80211_rdev_list, cfg80211_regdomain,
- * country_ie_regdomain, the reg_beacon_list and the the last regulatory
- * request receipt (last_request).
+ * This is used to protect the cfg80211_rdev_list
  */
 DEFINE_MUTEX(cfg80211_mutex);
 
@@ -106,7 +106,7 @@ __cfg80211_rdev_from_info(struct genl_info *info)
 
        if (info->attrs[NL80211_ATTR_IFINDEX]) {
                ifindex = nla_get_u32(info->attrs[NL80211_ATTR_IFINDEX]);
-               dev = dev_get_by_index(&init_net, ifindex);
+               dev = dev_get_by_index(genl_info_net(info), ifindex);
                if (dev) {
                        if (dev->ieee80211_ptr)
                                byifidx =
@@ -151,13 +151,13 @@ cfg80211_get_dev_from_info(struct genl_info *info)
 }
 
 struct cfg80211_registered_device *
-cfg80211_get_dev_from_ifindex(int ifindex)
+cfg80211_get_dev_from_ifindex(struct net *net, int ifindex)
 {
        struct cfg80211_registered_device *rdev = ERR_PTR(-ENODEV);
        struct net_device *dev;
 
        mutex_lock(&cfg80211_mutex);
-       dev = dev_get_by_index(&init_net, ifindex);
+       dev = dev_get_by_index(net, ifindex);
        if (!dev)
                goto out;
        if (dev->ieee80211_ptr) {
@@ -222,6 +222,42 @@ int cfg80211_dev_rename(struct cfg80211_registered_device *rdev,
        return 0;
 }
 
+int cfg80211_switch_netns(struct cfg80211_registered_device *rdev,
+                         struct net *net)
+{
+       struct wireless_dev *wdev;
+       int err = 0;
+
+       if (!rdev->wiphy.netnsok)
+               return -EOPNOTSUPP;
+
+       list_for_each_entry(wdev, &rdev->netdev_list, list) {
+               wdev->netdev->features &= ~NETIF_F_NETNS_LOCAL;
+               err = dev_change_net_namespace(wdev->netdev, net, "wlan%d");
+               if (err)
+                       break;
+               wdev->netdev->features |= NETIF_F_NETNS_LOCAL;
+       }
+
+       if (err) {
+               /* failed -- clean up to old netns */
+               net = wiphy_net(&rdev->wiphy);
+
+               list_for_each_entry_continue_reverse(wdev, &rdev->netdev_list,
+                                                    list) {
+                       wdev->netdev->features &= ~NETIF_F_NETNS_LOCAL;
+                       err = dev_change_net_namespace(wdev->netdev, net,
+                                                       "wlan%d");
+                       WARN_ON(err);
+                       wdev->netdev->features |= NETIF_F_NETNS_LOCAL;
+               }
+       }
+
+       wiphy_net_set(&rdev->wiphy, net);
+
+       return err;
+}
+
 static void cfg80211_rfkill_poll(struct rfkill *rfkill, void *data)
 {
        struct cfg80211_registered_device *rdev = data;
@@ -277,7 +313,8 @@ static void cfg80211_process_events(struct wireless_dev *wdev)
                                ev->cr.req_ie, ev->cr.req_ie_len,
                                ev->cr.resp_ie, ev->cr.resp_ie_len,
                                ev->cr.status,
-                               ev->cr.status == WLAN_STATUS_SUCCESS);
+                               ev->cr.status == WLAN_STATUS_SUCCESS,
+                               NULL);
                        break;
                case EVENT_ROAMED:
                        __cfg80211_roamed(wdev, ev->rm.bssid,
@@ -375,6 +412,10 @@ struct wiphy *wiphy_new(const struct cfg80211_ops *ops, int sizeof_priv)
        rdev->wiphy.dev.class = &ieee80211_class;
        rdev->wiphy.dev.platform_data = rdev;
 
+       rdev->wiphy.ps_default = CONFIG_CFG80211_DEFAULT_PS_VALUE;
+
+       wiphy_net_set(&rdev->wiphy, &init_net);
+
        rdev->rfkill_ops.set_block = cfg80211_rfkill_set_block;
        rdev->rfkill = rfkill_alloc(dev_name(&rdev->wiphy.dev),
                                   &rdev->wiphy.dev, RFKILL_TYPE_WLAN,
@@ -473,6 +514,7 @@ int wiphy_register(struct wiphy *wiphy)
        wiphy_update_regulatory(wiphy, NL80211_REGDOM_SET_BY_CORE);
 
        list_add(&rdev->list, &cfg80211_rdev_list);
+       cfg80211_rdev_list_generation++;
 
        mutex_unlock(&cfg80211_mutex);
 
@@ -544,9 +586,14 @@ void wiphy_unregister(struct wiphy *wiphy)
         * get to lock contention here if userspace issues a command
         * that identified the hardware by wiphy index.
         */
-       mutex_lock(&rdev->mtx);
-       /* unlock again before freeing */
-       mutex_unlock(&rdev->mtx);
+       cfg80211_lock_rdev(rdev);
+
+       if (WARN_ON(rdev->scan_req)) {
+               rdev->scan_req->aborted = true;
+               ___cfg80211_scan_done(rdev);
+       }
+
+       cfg80211_unlock_rdev(rdev);
 
        cfg80211_debugfs_rdev_del(rdev);
 
@@ -555,14 +602,14 @@ void wiphy_unregister(struct wiphy *wiphy)
        reg_device_remove(wiphy);
 
        list_del(&rdev->list);
+       cfg80211_rdev_list_generation++;
        device_del(&rdev->wiphy.dev);
        debugfs_remove(rdev->wiphy.debugfsdir);
 
        mutex_unlock(&cfg80211_mutex);
 
+       flush_work(&rdev->scan_done_wk);
        cancel_work_sync(&rdev->conn_work);
-       cancel_work_sync(&rdev->scan_done_wk);
-       kfree(rdev->scan_req);
        flush_work(&rdev->event_work);
 }
 EXPORT_SYMBOL(wiphy_unregister);
@@ -610,11 +657,20 @@ static int cfg80211_netdev_notifier_call(struct notifier_block * nb,
 
        switch (state) {
        case NETDEV_REGISTER:
+               /*
+                * NB: cannot take rdev->mtx here because this may be
+                * called within code protected by it when interfaces
+                * are added with nl80211.
+                */
                mutex_init(&wdev->mtx);
                INIT_LIST_HEAD(&wdev->event_list);
                spin_lock_init(&wdev->event_lock);
                mutex_lock(&rdev->devlist_mtx);
                list_add(&wdev->list, &rdev->netdev_list);
+               rdev->devlist_generation++;
+               /* can only change netns with wiphy */
+               dev->features |= NETIF_F_NETNS_LOCAL;
+
                if (sysfs_create_link(&dev->dev.kobj, &rdev->wiphy.dev.kobj,
                                      "phy80211")) {
                        printk(KERN_ERR "wireless: failed to add phy80211 "
@@ -624,11 +680,13 @@ static int cfg80211_netdev_notifier_call(struct notifier_block * nb,
                wdev->sme_state = CFG80211_SME_IDLE;
                mutex_unlock(&rdev->devlist_mtx);
 #ifdef CONFIG_WIRELESS_EXT
+               if (!dev->wireless_handlers)
+                       dev->wireless_handlers = &cfg80211_wext_handler;
                wdev->wext.default_key = -1;
                wdev->wext.default_mgmt_key = -1;
                wdev->wext.connect.auth_type = NL80211_AUTHTYPE_AUTOMATIC;
-               wdev->wext.ps = CONFIG_CFG80211_DEFAULT_PS_VALUE;
-               wdev->wext.ps_timeout = 500;
+               wdev->wext.ps = wdev->wiphy->ps_default;
+               wdev->wext.ps_timeout = 100;
                if (rdev->ops->set_power_mgmt)
                        if (rdev->ops->set_power_mgmt(wdev->wiphy, dev,
                                                      wdev->wext.ps,
@@ -663,6 +721,7 @@ static int cfg80211_netdev_notifier_call(struct notifier_block * nb,
        case NETDEV_UP:
 #ifdef CONFIG_WIRELESS_EXT
                cfg80211_lock_rdev(rdev);
+               mutex_lock(&rdev->devlist_mtx);
                wdev_lock(wdev);
                switch (wdev->iftype) {
                case NL80211_IFTYPE_ADHOC:
@@ -675,20 +734,34 @@ static int cfg80211_netdev_notifier_call(struct notifier_block * nb,
                        break;
                }
                wdev_unlock(wdev);
+               mutex_unlock(&rdev->devlist_mtx);
                cfg80211_unlock_rdev(rdev);
 #endif
                break;
        case NETDEV_UNREGISTER:
+               /*
+                * NB: cannot take rdev->mtx here because this may be
+                * called within code protected by it when interfaces
+                * are removed with nl80211.
+                */
                mutex_lock(&rdev->devlist_mtx);
+               /*
+                * It is possible to get NETDEV_UNREGISTER
+                * multiple times. To detect that, check
+                * that the interface is still on the list
+                * of registered interfaces, and only then
+                * remove and clean it up.
+                */
                if (!list_empty(&wdev->list)) {
                        sysfs_remove_link(&dev->dev.kobj, "phy80211");
                        list_del_init(&wdev->list);
-               }
-               mutex_unlock(&rdev->devlist_mtx);
-               mutex_destroy(&wdev->mtx);
+                       rdev->devlist_generation++;
+                       mutex_destroy(&wdev->mtx);
 #ifdef CONFIG_WIRELESS_EXT
-               kfree(wdev->wext.keys);
+                       kfree(wdev->wext.keys);
 #endif
+               }
+               mutex_unlock(&rdev->devlist_mtx);
                break;
        case NETDEV_PRE_UP:
                if (!(wdev->wiphy->interface_modes & BIT(wdev->iftype)))
@@ -705,10 +778,32 @@ static struct notifier_block cfg80211_netdev_notifier = {
        .notifier_call = cfg80211_netdev_notifier_call,
 };
 
-static int cfg80211_init(void)
+static void __net_exit cfg80211_pernet_exit(struct net *net)
+{
+       struct cfg80211_registered_device *rdev;
+
+       rtnl_lock();
+       mutex_lock(&cfg80211_mutex);
+       list_for_each_entry(rdev, &cfg80211_rdev_list, list) {
+               if (net_eq(wiphy_net(&rdev->wiphy), net))
+                       WARN_ON(cfg80211_switch_netns(rdev, &init_net));
+       }
+       mutex_unlock(&cfg80211_mutex);
+       rtnl_unlock();
+}
+
+static struct pernet_operations cfg80211_pernet_ops = {
+       .exit = cfg80211_pernet_exit,
+};
+
+static int __init cfg80211_init(void)
 {
        int err;
 
+       err = register_pernet_device(&cfg80211_pernet_ops);
+       if (err)
+               goto out_fail_pernet;
+
        err = wiphy_sysfs_init();
        if (err)
                goto out_fail_sysfs;
@@ -736,9 +831,10 @@ out_fail_nl80211:
 out_fail_notifier:
        wiphy_sysfs_exit();
 out_fail_sysfs:
+       unregister_pernet_device(&cfg80211_pernet_ops);
+out_fail_pernet:
        return err;
 }
-
 subsys_initcall(cfg80211_init);
 
 static void cfg80211_exit(void)
@@ -748,5 +844,6 @@ static void cfg80211_exit(void)
        unregister_netdevice_notifier(&cfg80211_netdev_notifier);
        wiphy_sysfs_exit();
        regulatory_exit();
+       unregister_pernet_device(&cfg80211_pernet_ops);
 }
 module_exit(cfg80211_exit);