b43: LP-PHY: Initialize TX power control
[pandora-kernel.git] / drivers / net / wireless / b43 / phy_lp.c
index e68644d..996b7ec 100644 (file)
@@ -59,9 +59,126 @@ static void b43_lpphy_op_free(struct b43_wldev *dev)
        dev->phy.lp = NULL;
 }
 
+static void lpphy_read_band_sprom(struct b43_wldev *dev)
+{
+       struct b43_phy_lp *lpphy = dev->phy.lp;
+       struct ssb_bus *bus = dev->dev->bus;
+       u16 cckpo, maxpwr;
+       u32 ofdmpo;
+       int i;
+
+       if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ) {
+               lpphy->tx_isolation_med_band = bus->sprom.tri2g;
+               lpphy->bx_arch = bus->sprom.bxa2g;
+               lpphy->rx_pwr_offset = bus->sprom.rxpo2g;
+               lpphy->rssi_vf = bus->sprom.rssismf2g;
+               lpphy->rssi_vc = bus->sprom.rssismc2g;
+               lpphy->rssi_gs = bus->sprom.rssisav2g;
+               lpphy->txpa[0] = bus->sprom.pa0b0;
+               lpphy->txpa[1] = bus->sprom.pa0b1;
+               lpphy->txpa[2] = bus->sprom.pa0b2;
+               maxpwr = bus->sprom.maxpwr_bg;
+               lpphy->max_tx_pwr_med_band = maxpwr;
+               cckpo = bus->sprom.cck2gpo;
+               ofdmpo = bus->sprom.ofdm2gpo;
+               if (cckpo) {
+                       for (i = 0; i < 4; i++) {
+                               lpphy->tx_max_rate[i] =
+                                       maxpwr - (ofdmpo & 0xF) * 2;
+                               ofdmpo >>= 4;
+                       }
+                       ofdmpo = bus->sprom.ofdm2gpo;
+                       for (i = 4; i < 15; i++) {
+                               lpphy->tx_max_rate[i] =
+                                       maxpwr - (ofdmpo & 0xF) * 2;
+                               ofdmpo >>= 4;
+                       }
+               } else {
+                       ofdmpo &= 0xFF;
+                       for (i = 0; i < 4; i++)
+                               lpphy->tx_max_rate[i] = maxpwr;
+                       for (i = 4; i < 15; i++)
+                               lpphy->tx_max_rate[i] = maxpwr - ofdmpo;
+               }
+       } else { /* 5GHz */
+               lpphy->tx_isolation_low_band = bus->sprom.tri5gl;
+               lpphy->tx_isolation_med_band = bus->sprom.tri5g;
+               lpphy->tx_isolation_hi_band = bus->sprom.tri5gh;
+               lpphy->bx_arch = bus->sprom.bxa5g;
+               lpphy->rx_pwr_offset = bus->sprom.rxpo5g;
+               lpphy->rssi_vf = bus->sprom.rssismf5g;
+               lpphy->rssi_vc = bus->sprom.rssismc5g;
+               lpphy->rssi_gs = bus->sprom.rssisav5g;
+               lpphy->txpa[0] = bus->sprom.pa1b0;
+               lpphy->txpa[1] = bus->sprom.pa1b1;
+               lpphy->txpa[2] = bus->sprom.pa1b2;
+               lpphy->txpal[0] = bus->sprom.pa1lob0;
+               lpphy->txpal[1] = bus->sprom.pa1lob1;
+               lpphy->txpal[2] = bus->sprom.pa1lob2;
+               lpphy->txpah[0] = bus->sprom.pa1hib0;
+               lpphy->txpah[1] = bus->sprom.pa1hib1;
+               lpphy->txpah[2] = bus->sprom.pa1hib2;
+               maxpwr = bus->sprom.maxpwr_al;
+               ofdmpo = bus->sprom.ofdm5glpo;
+               lpphy->max_tx_pwr_low_band = maxpwr;
+               for (i = 4; i < 12; i++) {
+                       lpphy->tx_max_ratel[i] = maxpwr - (ofdmpo & 0xF) * 2;
+                       ofdmpo >>= 4;
+               }
+               maxpwr = bus->sprom.maxpwr_a;
+               ofdmpo = bus->sprom.ofdm5gpo;
+               lpphy->max_tx_pwr_med_band = maxpwr;
+               for (i = 4; i < 12; i++) {
+                       lpphy->tx_max_rate[i] = maxpwr - (ofdmpo & 0xF) * 2;
+                       ofdmpo >>= 4;
+               }
+               maxpwr = bus->sprom.maxpwr_ah;
+               ofdmpo = bus->sprom.ofdm5ghpo;
+               lpphy->max_tx_pwr_hi_band = maxpwr;
+               for (i = 4; i < 12; i++) {
+                       lpphy->tx_max_rateh[i] = maxpwr - (ofdmpo & 0xF) * 2;
+                       ofdmpo >>= 4;
+               }
+       }
+}
+
+static void lpphy_adjust_gain_table(struct b43_wldev *dev)
+{
+       struct b43_phy_lp *lpphy = dev->phy.lp;
+       u32 freq = dev->wl->hw->conf.channel->center_freq;
+       u16 temp[3];
+       u16 isolation;
+
+       B43_WARN_ON(dev->phy.rev >= 2);
+
+       if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ)
+               isolation = lpphy->tx_isolation_med_band;
+       else if (freq <= 5320)
+               isolation = lpphy->tx_isolation_low_band;
+       else if (freq <= 5700)
+               isolation = lpphy->tx_isolation_med_band;
+       else
+               isolation = lpphy->tx_isolation_hi_band;
+
+       temp[0] = ((isolation - 26) / 12) << 12;
+       temp[1] = temp[0] + 0x1000;
+       temp[2] = temp[0] + 0x2000;
+
+       b43_lptab_write_bulk(dev, B43_LPTAB16(12, 0), 3, temp);
+       b43_lptab_write_bulk(dev, B43_LPTAB16(13, 0), 3, temp);
+}
+
 static void lpphy_table_init(struct b43_wldev *dev)
 {
-       //TODO
+       if (dev->phy.rev < 2)
+               lpphy_rev0_1_table_init(dev);
+       else
+               lpphy_rev2plus_table_init(dev);
+
+       lpphy_init_tx_gain_table(dev);
+
+       if (dev->phy.rev < 2)
+               lpphy_adjust_gain_table(dev);
 }
 
 static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev)
@@ -161,6 +278,56 @@ static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev)
        }
 }
 
+static void lpphy_save_dig_flt_state(struct b43_wldev *dev)
+{
+       static const u16 addr[] = {
+               B43_PHY_OFDM(0xC1),
+               B43_PHY_OFDM(0xC2),
+               B43_PHY_OFDM(0xC3),
+               B43_PHY_OFDM(0xC4),
+               B43_PHY_OFDM(0xC5),
+               B43_PHY_OFDM(0xC6),
+               B43_PHY_OFDM(0xC7),
+               B43_PHY_OFDM(0xC8),
+               B43_PHY_OFDM(0xCF),
+       };
+
+       static const u16 coefs[] = {
+               0xDE5E, 0xE832, 0xE331, 0x4D26,
+               0x0026, 0x1420, 0x0020, 0xFE08,
+               0x0008,
+       };
+
+       struct b43_phy_lp *lpphy = dev->phy.lp;
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(addr); i++) {
+               lpphy->dig_flt_state[i] = b43_phy_read(dev, addr[i]);
+               b43_phy_write(dev, addr[i], coefs[i]);
+       }
+}
+
+static void lpphy_restore_dig_flt_state(struct b43_wldev *dev)
+{
+       static const u16 addr[] = {
+               B43_PHY_OFDM(0xC1),
+               B43_PHY_OFDM(0xC2),
+               B43_PHY_OFDM(0xC3),
+               B43_PHY_OFDM(0xC4),
+               B43_PHY_OFDM(0xC5),
+               B43_PHY_OFDM(0xC6),
+               B43_PHY_OFDM(0xC7),
+               B43_PHY_OFDM(0xC8),
+               B43_PHY_OFDM(0xCF),
+       };
+
+       struct b43_phy_lp *lpphy = dev->phy.lp;
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(addr); i++)
+               b43_phy_write(dev, addr[i], lpphy->dig_flt_state[i]);
+}
+
 static void lpphy_baseband_rev2plus_init(struct b43_wldev *dev)
 {
        struct ssb_bus *bus = dev->dev->bus;
@@ -175,7 +342,7 @@ static void lpphy_baseband_rev2plus_init(struct b43_wldev *dev)
        b43_phy_write(dev, B43_PHY_OFDM(0xF9), 0);
        b43_phy_write(dev, B43_LPPHY_TR_LOOKUP_1, 0);
        b43_phy_set(dev, B43_LPPHY_ADC_COMPENSATION_CTL, 0x10);
-       b43_phy_maskset(dev, B43_LPPHY_OFDMSYNCTHRESH0, 0xFF00, 0x78);
+       b43_phy_maskset(dev, B43_LPPHY_OFDMSYNCTHRESH0, 0xFF00, 0xB4);
        b43_phy_maskset(dev, B43_LPPHY_DCOFFSETTRANSIENT, 0xF8FF, 0x200);
        b43_phy_maskset(dev, B43_LPPHY_DCOFFSETTRANSIENT, 0xFF00, 0x7F);
        b43_phy_maskset(dev, B43_LPPHY_GAINDIRECTMISMATCH, 0xFF0F, 0x40);
@@ -183,7 +350,12 @@ static void lpphy_baseband_rev2plus_init(struct b43_wldev *dev)
        b43_phy_mask(dev, B43_LPPHY_CRSGAIN_CTL, ~0x4000);
        b43_phy_mask(dev, B43_LPPHY_CRSGAIN_CTL, ~0x2000);
        b43_phy_set(dev, B43_PHY_OFDM(0x10A), 0x1);
-       b43_phy_maskset(dev, B43_PHY_OFDM(0x10A), 0xFF01, 0x10);
+       if (bus->boardinfo.rev >= 0x18) {
+               b43_lptab_write(dev, B43_LPTAB32(17, 65), 0xEC);
+               b43_phy_maskset(dev, B43_PHY_OFDM(0x10A), 0xFF01, 0x14);
+       } else {
+               b43_phy_maskset(dev, B43_PHY_OFDM(0x10A), 0xFF01, 0x10);
+       }
        b43_phy_maskset(dev, B43_PHY_OFDM(0xDF), 0xFF00, 0xF4);
        b43_phy_maskset(dev, B43_PHY_OFDM(0xDF), 0x00FF, 0xF100);
        b43_phy_write(dev, B43_LPPHY_CLIPTHRESH, 0x48);
@@ -213,8 +385,10 @@ static void lpphy_baseband_rev2plus_init(struct b43_wldev *dev)
        b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0xFFE0, 0x12);
        b43_phy_maskset(dev, B43_LPPHY_GAINMISMATCH, 0x0FFF, 0x9000);
 
-       b43_lptab_write(dev, B43_LPTAB16(0x08, 0x14), 0);
-       b43_lptab_write(dev, B43_LPTAB16(0x08, 0x12), 0x40);
+       if ((bus->chip_id == 0x4325) && (bus->chip_rev == 1)) {
+               b43_lptab_write(dev, B43_LPTAB16(0x08, 0x14), 0);
+               b43_lptab_write(dev, B43_LPTAB16(0x08, 0x12), 0x40);
+       }
 
        if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ) {
                b43_phy_set(dev, B43_LPPHY_CRSGAIN_CTL, 0x40);
@@ -234,6 +408,14 @@ static void lpphy_baseband_rev2plus_init(struct b43_wldev *dev)
        b43_phy_write(dev, B43_LPPHY_AFE_RSSI_CTL_1,
                      0x2000 | ((u16)lpphy->rssi_gs << 10) |
                      ((u16)lpphy->rssi_vc << 4) | lpphy->rssi_vf);
+
+       if ((bus->chip_id == 0x4325) && (bus->chip_rev == 0)) {
+               b43_phy_set(dev, B43_LPPHY_AFE_ADC_CTL_0, 0x1C);
+               b43_phy_maskset(dev, B43_LPPHY_AFE_CTL, 0x00FF, 0x8800);
+               b43_phy_maskset(dev, B43_LPPHY_AFE_ADC_CTL_1, 0xFC3C, 0x0400);
+       }
+
+       lpphy_save_dig_flt_state(dev);
 }
 
 static void lpphy_baseband_init(struct b43_wldev *dev)
@@ -398,7 +580,7 @@ static void lpphy_sync_stx(struct b43_wldev *dev)
                tmp >>= e->rf_shift;
                tmp <<= e->phy_shift;
                b43_phy_maskset(dev, B43_PHY_OFDM(0xF2 + e->phy_offset),
-                               e->mask << e->phy_shift, tmp);
+                               ~(e->mask << e->phy_shift), tmp);
        }
 }
 
@@ -423,6 +605,339 @@ static void lpphy_radio_init(struct b43_wldev *dev)
        }
 }
 
+struct lpphy_iq_est { u32 iq_prod, i_pwr, q_pwr; };
+
+static void lpphy_set_rc_cap(struct b43_wldev *dev)
+{
+       u8 rc_cap = dev->phy.lp->rc_cap;
+
+       b43_radio_write(dev, B2062_N_RXBB_CALIB2, max_t(u8, rc_cap-4, 0x80));
+       b43_radio_write(dev, B2062_N_TX_CTL_A, ((rc_cap & 0x1F) >> 1) | 0x80);
+       b43_radio_write(dev, B2062_S_RXG_CNT16, ((rc_cap & 0x1F) >> 2) | 0x80);
+}
+
+static u8 lpphy_get_bb_mult(struct b43_wldev *dev)
+{
+       return (b43_lptab_read(dev, B43_LPTAB16(0, 87)) & 0xFF00) >> 8;
+}
+
+static void lpphy_set_bb_mult(struct b43_wldev *dev, u8 bb_mult)
+{
+       b43_lptab_write(dev, B43_LPTAB16(0, 87), (u16)bb_mult << 8);
+}
+
+static void lpphy_disable_crs(struct b43_wldev *dev)
+{
+       b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL, 0xFF1F, 0x80);
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFC, 0x1);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x3);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFB);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x4);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFF7);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x8);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0x10);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x10);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFDF);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x20);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFBF);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x40);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0x7);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0x38);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0xFF3F);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0x100);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0xFDFF);
+       b43_phy_write(dev, B43_LPPHY_PS_CTL_OVERRIDE_VAL0, 0);
+       b43_phy_write(dev, B43_LPPHY_PS_CTL_OVERRIDE_VAL1, 1);
+       b43_phy_write(dev, B43_LPPHY_PS_CTL_OVERRIDE_VAL2, 0x20);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0xFBFF);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0xF7FF);
+       b43_phy_write(dev, B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL, 0);
+       b43_phy_write(dev, B43_LPPHY_RX_GAIN_CTL_OVERRIDE_VAL, 0x45AF);
+       b43_phy_write(dev, B43_LPPHY_RF_OVERRIDE_2, 0x3FF);
+}
+
+static void lpphy_restore_crs(struct b43_wldev *dev)
+{
+       if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ)
+               b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL, 0xFF1F, 0x60);
+       else
+               b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL, 0xFF1F, 0x20);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFF80);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFC00);
+}
+
+struct lpphy_tx_gains { u16 gm, pga, pad, dac; };
+
+static struct lpphy_tx_gains lpphy_get_tx_gains(struct b43_wldev *dev)
+{
+       struct lpphy_tx_gains gains;
+       u16 tmp;
+
+       gains.dac = (b43_phy_read(dev, B43_LPPHY_AFE_DAC_CTL) & 0x380) >> 7;
+       if (dev->phy.rev < 2) {
+               tmp = b43_phy_read(dev,
+                                  B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL) & 0x7FF;
+               gains.gm = tmp & 0x0007;
+               gains.pga = (tmp & 0x0078) >> 3;
+               gains.pad = (tmp & 0x780) >> 7;
+       } else {
+               tmp = b43_phy_read(dev, B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL);
+               gains.pad = b43_phy_read(dev, B43_PHY_OFDM(0xFB)) & 0xFF;
+               gains.gm = tmp & 0xFF;
+               gains.pga = (tmp >> 8) & 0xFF;
+       }
+
+       return gains;
+}
+
+static void lpphy_set_dac_gain(struct b43_wldev *dev, u16 dac)
+{
+       u16 ctl = b43_phy_read(dev, B43_LPPHY_AFE_DAC_CTL) & 0xC7F;
+       ctl |= dac << 7;
+       b43_phy_maskset(dev, B43_LPPHY_AFE_DAC_CTL, 0xF000, ctl);
+}
+
+static void lpphy_set_tx_gains(struct b43_wldev *dev,
+                              struct lpphy_tx_gains gains)
+{
+       u16 rf_gain, pa_gain;
+
+       if (dev->phy.rev < 2) {
+               rf_gain = (gains.pad << 7) | (gains.pga << 3) | gains.gm;
+               b43_phy_maskset(dev, B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL,
+                               0xF800, rf_gain);
+       } else {
+               pa_gain = b43_phy_read(dev, B43_PHY_OFDM(0xFB)) & 0x7F00;
+               b43_phy_write(dev, B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL,
+                             (gains.pga << 8) | gains.gm);
+               b43_phy_maskset(dev, B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL,
+                               0x8000, gains.pad | pa_gain);
+               b43_phy_write(dev, B43_PHY_OFDM(0xFC),
+                             (gains.pga << 8) | gains.gm);
+               b43_phy_maskset(dev, B43_PHY_OFDM(0xFD),
+                               0x8000, gains.pad | pa_gain);
+       }
+       lpphy_set_dac_gain(dev, gains.dac);
+       if (dev->phy.rev < 2) {
+               b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFEFF, 1 << 8);
+       } else {
+               b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFF7F, 1 << 7);
+               b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xBFFF, 1 << 14);
+       }
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFFBF, 1 << 4);
+}
+
+static void lpphy_rev0_1_set_rx_gain(struct b43_wldev *dev, u32 gain)
+{
+       u16 trsw = gain & 0x1;
+       u16 lna = (gain & 0xFFFC) | ((gain & 0xC) >> 2);
+       u16 ext_lna = (gain & 2) >> 1;
+
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFE, trsw);
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2_VAL,
+                       0xFBFF, ext_lna << 10);
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2_VAL,
+                       0xF7FF, ext_lna << 11);
+       b43_phy_write(dev, B43_LPPHY_RX_GAIN_CTL_OVERRIDE_VAL, lna);
+}
+
+static void lpphy_rev2plus_set_rx_gain(struct b43_wldev *dev, u32 gain)
+{
+       u16 low_gain = gain & 0xFFFF;
+       u16 high_gain = (gain >> 16) & 0xF;
+       u16 ext_lna = (gain >> 21) & 0x1;
+       u16 trsw = ~(gain >> 20) & 0x1;
+       u16 tmp;
+
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFE, trsw);
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2_VAL,
+                       0xFDFF, ext_lna << 9);
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2_VAL,
+                       0xFBFF, ext_lna << 10);
+       b43_phy_write(dev, B43_LPPHY_RX_GAIN_CTL_OVERRIDE_VAL, low_gain);
+       b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS, 0xFFF0, high_gain);
+       if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ) {
+               tmp = (gain >> 2) & 0x3;
+               b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2_VAL,
+                               0xE7FF, tmp<<11);
+               b43_phy_maskset(dev, B43_PHY_OFDM(0xE6), 0xFFE7, tmp << 3);
+       }
+}
+
+static void lpphy_enable_rx_gain_override(struct b43_wldev *dev)
+{
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFFE);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFEF);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFBF);
+       if (dev->phy.rev >= 2) {
+               b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFEFF);
+               if (b43_current_band(dev->wl) != IEEE80211_BAND_2GHZ)
+                       return;
+               b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFBFF);
+               b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFFF7);
+       } else {
+               b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFDFF);
+       }
+}
+
+static void lpphy_disable_rx_gain_override(struct b43_wldev *dev)
+{
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x1);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x10);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x40);
+       if (dev->phy.rev >= 2) {
+               b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x100);
+               if (b43_current_band(dev->wl) != IEEE80211_BAND_2GHZ)
+                       return;
+               b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x400);
+               b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x8);
+       } else {
+               b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x200);
+       }
+}
+
+static void lpphy_set_rx_gain(struct b43_wldev *dev, u32 gain)
+{
+       if (dev->phy.rev < 2)
+               lpphy_rev0_1_set_rx_gain(dev, gain);
+       else
+               lpphy_rev2plus_set_rx_gain(dev, gain);
+       lpphy_enable_rx_gain_override(dev);
+}
+
+static void lpphy_set_rx_gain_by_index(struct b43_wldev *dev, u16 idx)
+{
+       u32 gain = b43_lptab_read(dev, B43_LPTAB16(12, idx));
+       lpphy_set_rx_gain(dev, gain);
+}
+
+static void lpphy_stop_ddfs(struct b43_wldev *dev)
+{
+       b43_phy_mask(dev, B43_LPPHY_AFE_DDFS, 0xFFFD);
+       b43_phy_mask(dev, B43_LPPHY_LP_PHY_CTL, 0xFFDF);
+}
+
+static void lpphy_run_ddfs(struct b43_wldev *dev, int i_on, int q_on,
+                          int incr1, int incr2, int scale_idx)
+{
+       lpphy_stop_ddfs(dev);
+       b43_phy_mask(dev, B43_LPPHY_AFE_DDFS_POINTER_INIT, 0xFF80);
+       b43_phy_mask(dev, B43_LPPHY_AFE_DDFS_POINTER_INIT, 0x80FF);
+       b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0xFF80, incr1);
+       b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0x80FF, incr2 << 8);
+       b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS, 0xFFF7, i_on << 3);
+       b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS, 0xFFEF, q_on << 4);
+       b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS, 0xFF9F, scale_idx << 5);
+       b43_phy_mask(dev, B43_LPPHY_AFE_DDFS, 0xFFFB);
+       b43_phy_set(dev, B43_LPPHY_AFE_DDFS, 0x2);
+       b43_phy_set(dev, B43_LPPHY_AFE_DDFS, 0x20);
+}
+
+static bool lpphy_rx_iq_est(struct b43_wldev *dev, u16 samples, u8 time,
+                          struct lpphy_iq_est *iq_est)
+{
+       int i;
+
+       b43_phy_mask(dev, B43_LPPHY_CRSGAIN_CTL, 0xFFF7);
+       b43_phy_write(dev, B43_LPPHY_IQ_NUM_SMPLS_ADDR, samples);
+       b43_phy_maskset(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFF00, time);
+       b43_phy_mask(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFEFF);
+       b43_phy_set(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFDFF);
+
+       for (i = 0; i < 500; i++) {
+               if (!(b43_phy_read(dev,
+                               B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR) & 0x200))
+                       break;
+               msleep(1);
+       }
+
+       if ((b43_phy_read(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR) & 0x200)) {
+               b43_phy_set(dev, B43_LPPHY_CRSGAIN_CTL, 0x8);
+               return false;
+       }
+
+       iq_est->iq_prod = b43_phy_read(dev, B43_LPPHY_IQ_ACC_HI_ADDR);
+       iq_est->iq_prod <<= 16;
+       iq_est->iq_prod |= b43_phy_read(dev, B43_LPPHY_IQ_ACC_LO_ADDR);
+
+       iq_est->i_pwr = b43_phy_read(dev, B43_LPPHY_IQ_I_PWR_ACC_HI_ADDR);
+       iq_est->i_pwr <<= 16;
+       iq_est->i_pwr |= b43_phy_read(dev, B43_LPPHY_IQ_I_PWR_ACC_LO_ADDR);
+
+       iq_est->q_pwr = b43_phy_read(dev, B43_LPPHY_IQ_Q_PWR_ACC_HI_ADDR);
+       iq_est->q_pwr <<= 16;
+       iq_est->q_pwr |= b43_phy_read(dev, B43_LPPHY_IQ_Q_PWR_ACC_LO_ADDR);
+
+       b43_phy_set(dev, B43_LPPHY_CRSGAIN_CTL, 0x8);
+       return true;
+}
+
+static int lpphy_loopback(struct b43_wldev *dev)
+{
+       struct lpphy_iq_est iq_est;
+       int i, index = -1;
+       u32 tmp;
+
+       memset(&iq_est, 0, sizeof(iq_est));
+
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFC, 0x3);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x3);
+       b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0xFFFE);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x800);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0x800);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x8);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0x8);
+       b43_radio_write(dev, B2062_N_TX_CTL_A, 0x80);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x80);
+       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0x80);
+       for (i = 0; i < 32; i++) {
+               lpphy_set_rx_gain_by_index(dev, i);
+               lpphy_run_ddfs(dev, 1, 1, 5, 5, 0);
+               if (!(lpphy_rx_iq_est(dev, 1000, 32, &iq_est)))
+                       continue;
+               tmp = (iq_est.i_pwr + iq_est.q_pwr) / 1000;
+               if ((tmp > 4000) && (tmp < 10000)) {
+                       index = i;
+                       break;
+               }
+       }
+       lpphy_stop_ddfs(dev);
+       return index;
+}
+
+static u32 lpphy_qdiv_roundup(u32 dividend, u32 divisor, u8 precision)
+{
+       u32 quotient, remainder, rbit, roundup, tmp;
+
+       if (divisor == 0) {
+               quotient = 0;
+               remainder = 0;
+       } else {
+               quotient = dividend / divisor;
+               remainder = dividend % divisor;
+       }
+
+       rbit = divisor & 0x1;
+       roundup = (divisor >> 1) + rbit;
+       precision--;
+
+       while (precision != 0xFF) {
+               tmp = remainder - roundup;
+               quotient <<= 1;
+               remainder <<= 1;
+               if (remainder >= roundup) {
+                       remainder = (tmp << 1) + rbit;
+                       quotient--;
+               }
+               precision--;
+       }
+
+       if (remainder >= roundup)
+               quotient++;
+
+       return quotient;
+}
+
 /* Read the TX power control mode from hardware. */
 static void lpphy_read_tx_pctl_mode_from_hardware(struct b43_wldev *dev)
 {
@@ -507,6 +1022,170 @@ static void lpphy_set_tx_power_control(struct b43_wldev *dev,
        lpphy_write_tx_pctl_mode_to_hardware(dev);
 }
 
+static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev)
+{
+       struct b43_phy_lp *lpphy = dev->phy.lp;
+       struct lpphy_iq_est iq_est;
+       struct lpphy_tx_gains tx_gains;
+       static const u32 ideal_pwr_table[22] = {
+               0x10000, 0x10557, 0x10e2d, 0x113e0, 0x10f22, 0x0ff64,
+               0x0eda2, 0x0e5d4, 0x0efd1, 0x0fbe8, 0x0b7b8, 0x04b35,
+               0x01a5e, 0x00a0b, 0x00444, 0x001fd, 0x000ff, 0x00088,
+               0x0004c, 0x0002c, 0x0001a, 0xc0006,
+       };
+       bool old_txg_ovr;
+       u8 old_bbmult;
+       u16 old_rf_ovr, old_rf_ovrval, old_afe_ovr, old_afe_ovrval,
+           old_rf2_ovr, old_rf2_ovrval, old_phy_ctl, old_txpctl;
+       u32 normal_pwr, ideal_pwr, mean_sq_pwr, tmp = 0, mean_sq_pwr_min = 0;
+       int loopback, i, j, inner_sum;
+
+       memset(&iq_est, 0, sizeof(iq_est));
+
+       b43_switch_channel(dev, 7);
+       old_txg_ovr = (b43_phy_read(dev, B43_LPPHY_AFE_CTL_OVR) >> 6) & 1;
+       old_bbmult = lpphy_get_bb_mult(dev);
+       if (old_txg_ovr)
+               tx_gains = lpphy_get_tx_gains(dev);
+       old_rf_ovr = b43_phy_read(dev, B43_LPPHY_RF_OVERRIDE_0);
+       old_rf_ovrval = b43_phy_read(dev, B43_LPPHY_RF_OVERRIDE_VAL_0);
+       old_afe_ovr = b43_phy_read(dev, B43_LPPHY_AFE_CTL_OVR);
+       old_afe_ovrval = b43_phy_read(dev, B43_LPPHY_AFE_CTL_OVRVAL);
+       old_rf2_ovr = b43_phy_read(dev, B43_LPPHY_RF_OVERRIDE_2);
+       old_rf2_ovrval = b43_phy_read(dev, B43_LPPHY_RF_OVERRIDE_2_VAL);
+       old_phy_ctl = b43_phy_read(dev, B43_LPPHY_LP_PHY_CTL);
+       old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) &
+                                       B43_LPPHY_TX_PWR_CTL_CMD_MODE;
+
+       lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF);
+       lpphy_disable_crs(dev);
+       loopback = lpphy_loopback(dev);
+       if (loopback == -1)
+               goto finish;
+       lpphy_set_rx_gain_by_index(dev, loopback);
+       b43_phy_maskset(dev, B43_LPPHY_LP_PHY_CTL, 0xFFBF, 0x40);
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0xFFF8, 0x1);
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0xFFC7, 0x8);
+       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, 0xFF3F, 0xC0);
+       for (i = 128; i <= 159; i++) {
+               b43_radio_write(dev, B2062_N_RXBB_CALIB2, i);
+               inner_sum = 0;
+               for (j = 5; j <= 25; j++) {
+                       lpphy_run_ddfs(dev, 1, 1, j, j, 0);
+                       if (!(lpphy_rx_iq_est(dev, 1000, 32, &iq_est)))
+                               goto finish;
+                       mean_sq_pwr = iq_est.i_pwr + iq_est.q_pwr;
+                       if (j == 5)
+                               tmp = mean_sq_pwr;
+                       ideal_pwr = ((ideal_pwr_table[j-5] >> 3) + 1) >> 1;
+                       normal_pwr = lpphy_qdiv_roundup(mean_sq_pwr, tmp, 12);
+                       mean_sq_pwr = ideal_pwr - normal_pwr;
+                       mean_sq_pwr *= mean_sq_pwr;
+                       inner_sum += mean_sq_pwr;
+                       if ((i = 128) || (inner_sum < mean_sq_pwr_min)) {
+                               lpphy->rc_cap = i;
+                               mean_sq_pwr_min = inner_sum;
+                       }
+               }
+       }
+       lpphy_stop_ddfs(dev);
+
+finish:
+       lpphy_restore_crs(dev);
+       b43_phy_write(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, old_rf_ovrval);
+       b43_phy_write(dev, B43_LPPHY_RF_OVERRIDE_0, old_rf_ovr);
+       b43_phy_write(dev, B43_LPPHY_AFE_CTL_OVRVAL, old_afe_ovrval);
+       b43_phy_write(dev, B43_LPPHY_AFE_CTL_OVR, old_afe_ovr);
+       b43_phy_write(dev, B43_LPPHY_RF_OVERRIDE_2_VAL, old_rf2_ovrval);
+       b43_phy_write(dev, B43_LPPHY_RF_OVERRIDE_2, old_rf2_ovr);
+       b43_phy_write(dev, B43_LPPHY_LP_PHY_CTL, old_phy_ctl);
+
+       lpphy_set_bb_mult(dev, old_bbmult);
+       if (old_txg_ovr) {
+               /*
+                * SPEC FIXME: The specs say "get_tx_gains" here, which is
+                * illogical. According to lwfinger, vendor driver v4.150.10.5
+                * has a Set here, while v4.174.64.19 has a Get - regression in
+                * the vendor driver? This should be tested this once the code
+                * is testable.
+                */
+               lpphy_set_tx_gains(dev, tx_gains);
+       }
+       lpphy_set_tx_power_control(dev, old_txpctl);
+       if (lpphy->rc_cap)
+               lpphy_set_rc_cap(dev);
+}
+
+static void lpphy_rev2plus_rc_calib(struct b43_wldev *dev)
+{
+       struct ssb_bus *bus = dev->dev->bus;
+       u32 crystal_freq = bus->chipco.pmu.crystalfreq * 1000;
+       u8 tmp = b43_radio_read(dev, B2063_RX_BB_SP8) & 0xFF;
+       int i;
+
+       b43_radio_write(dev, B2063_RX_BB_SP8, 0x0);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL1, 0x7E);
+       b43_radio_mask(dev, B2063_PLL_SP1, 0xF7);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL1, 0x7C);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL2, 0x15);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL3, 0x70);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL4, 0x52);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL5, 0x1);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL1, 0x7D);
+
+       for (i = 0; i < 10000; i++) {
+               if (b43_radio_read(dev, B2063_RC_CALIB_CTL6) & 0x2)
+                       break;
+               msleep(1);
+       }
+
+       if (!(b43_radio_read(dev, B2063_RC_CALIB_CTL6) & 0x2))
+               b43_radio_write(dev, B2063_RX_BB_SP8, tmp);
+
+       tmp = b43_radio_read(dev, B2063_TX_BB_SP3) & 0xFF;
+
+       b43_radio_write(dev, B2063_TX_BB_SP3, 0x0);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL1, 0x7E);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL1, 0x7C);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL2, 0x55);
+       b43_radio_write(dev, B2063_RC_CALIB_CTL3, 0x76);
+
+       if (crystal_freq == 24000000) {
+               b43_radio_write(dev, B2063_RC_CALIB_CTL4, 0xFC);
+               b43_radio_write(dev, B2063_RC_CALIB_CTL5, 0x0);
+       } else {
+               b43_radio_write(dev, B2063_RC_CALIB_CTL4, 0x13);
+               b43_radio_write(dev, B2063_RC_CALIB_CTL5, 0x1);
+       }
+
+       b43_radio_write(dev, B2063_PA_SP7, 0x7D);
+
+       for (i = 0; i < 10000; i++) {
+               if (b43_radio_read(dev, B2063_RC_CALIB_CTL6) & 0x2)
+                       break;
+               msleep(1);
+       }
+
+       if (!(b43_radio_read(dev, B2063_RC_CALIB_CTL6) & 0x2))
+               b43_radio_write(dev, B2063_TX_BB_SP3, tmp);
+
+       b43_radio_write(dev, B2063_RC_CALIB_CTL1, 0x7E);
+}
+
+static void lpphy_calibrate_rc(struct b43_wldev *dev)
+{
+       struct b43_phy_lp *lpphy = dev->phy.lp;
+
+       if (dev->phy.rev >= 2) {
+               lpphy_rev2plus_rc_calib(dev);
+       } else if (!lpphy->rc_cap) {
+               if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ)
+                       lpphy_rev0_1_rc_calib(dev);
+       } else {
+               lpphy_set_rc_cap(dev);
+       }
+}
+
 static void lpphy_set_tx_power_by_index(struct b43_wldev *dev, u8 index)
 {
        struct b43_phy_lp *lpphy = dev->phy.lp;
@@ -578,31 +1257,122 @@ static void lpphy_calibration(struct b43_wldev *dev)
        b43_mac_enable(dev);
 }
 
+static void lpphy_set_tssi_mux(struct b43_wldev *dev, enum tssi_mux_mode mode)
+{
+       if (mode != TSSI_MUX_EXT) {
+               b43_radio_set(dev, B2063_PA_SP1, 0x2);
+               b43_phy_set(dev, B43_PHY_OFDM(0xF3), 0x1000);
+               b43_radio_write(dev, B2063_PA_CTL10, 0x51);
+               if (mode == TSSI_MUX_POSTPA) {
+                       b43_radio_mask(dev, B2063_PA_SP1, 0xFFFE);
+                       b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0xFFC7);
+               } else {
+                       b43_radio_maskset(dev, B2063_PA_SP1, 0xFFFE, 0x1);
+                       b43_phy_maskset(dev, B43_LPPHY_AFE_CTL_OVRVAL,
+                                       0xFFC7, 0x20);
+               }
+       } else {
+               B43_WARN_ON(1);
+       }
+}
+
+static void lpphy_tx_pctl_init_hw(struct b43_wldev *dev)
+{
+       u16 tmp;
+       int i;
+
+       //SPEC TODO Call LP PHY Clear TX Power offsets
+       for (i = 0; i < 64; i++) {
+               if (dev->phy.rev >= 2)
+                       b43_lptab_write(dev, B43_LPTAB32(7, i + 1), i);
+               else
+                       b43_lptab_write(dev, B43_LPTAB32(10, i + 1), i);
+       }
+
+       b43_phy_maskset(dev, B43_LPPHY_TX_PWR_CTL_NNUM, 0xFF00, 0xFF);
+       b43_phy_maskset(dev, B43_LPPHY_TX_PWR_CTL_NNUM, 0x8FFF, 0x5000);
+       b43_phy_maskset(dev, B43_LPPHY_TX_PWR_CTL_IDLETSSI, 0xFFC0, 0x1F);
+       if (dev->phy.rev < 2) {
+               b43_phy_mask(dev, B43_LPPHY_LP_PHY_CTL, 0xEFFF);
+               b43_phy_maskset(dev, B43_LPPHY_LP_PHY_CTL, 0xDFFF, 0x2000);
+       } else {
+               b43_phy_mask(dev, B43_PHY_OFDM(0x103), 0xFFFE);
+               b43_phy_maskset(dev, B43_PHY_OFDM(0x103), 0xFFFB, 0x4);
+               b43_phy_maskset(dev, B43_PHY_OFDM(0x103), 0xFFEF, 0x10);
+               b43_radio_maskset(dev, B2063_IQ_CALIB_CTL2, 0xF3, 0x1);
+               lpphy_set_tssi_mux(dev, TSSI_MUX_POSTPA);
+       }
+       b43_phy_maskset(dev, B43_LPPHY_TX_PWR_CTL_IDLETSSI, 0x7FFF, 0x8000);
+       b43_phy_mask(dev, B43_LPPHY_TX_PWR_CTL_DELTAPWR_LIMIT, 0xFF);
+       b43_phy_write(dev, B43_LPPHY_TX_PWR_CTL_DELTAPWR_LIMIT, 0xA);
+       b43_phy_maskset(dev, B43_LPPHY_TX_PWR_CTL_CMD,
+                       (u16)~B43_LPPHY_TX_PWR_CTL_CMD_MODE,
+                       B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF);
+       b43_phy_mask(dev, B43_LPPHY_TX_PWR_CTL_NNUM, 0xF8FF);
+       b43_phy_maskset(dev, B43_LPPHY_TX_PWR_CTL_CMD,
+                       (u16)~B43_LPPHY_TX_PWR_CTL_CMD_MODE,
+                       B43_LPPHY_TX_PWR_CTL_CMD_MODE_SW);
+
+       if (dev->phy.rev < 2) {
+               b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_0, 0xEFFF, 0x1000);
+               b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xEFFF);
+       } else {
+               lpphy_set_tx_power_by_index(dev, 0x7F);
+       }
+
+       b43_dummy_transmission(dev, true, true);
+
+       tmp = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_STAT);
+       if (tmp & 0x8000) {
+               b43_phy_maskset(dev, B43_LPPHY_TX_PWR_CTL_IDLETSSI,
+                               0xFFC0, (tmp & 0xFF) - 32);
+       }
+
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xEFFF);
+
+       // (SPEC?) TODO Set "Target TX frequency" variable to 0
+       // SPEC FIXME "Set BB Multiplier to 0xE000" impossible - bb_mult is u8!
+}
+
+static void lpphy_tx_pctl_init_sw(struct b43_wldev *dev)
+{
+       struct lpphy_tx_gains gains;
+
+       if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ) {
+               gains.gm = 4;
+               gains.pad = 12;
+               gains.pga = 12;
+               gains.dac = 0;
+       } else {
+               gains.gm = 7;
+               gains.pad = 14;
+               gains.pga = 15;
+               gains.dac = 0;
+       }
+       lpphy_set_tx_gains(dev, gains);
+       lpphy_set_bb_mult(dev, 150);
+}
+
 /* Initialize TX power control */
 static void lpphy_tx_pctl_init(struct b43_wldev *dev)
 {
        if (0/*FIXME HWPCTL capable */) {
-               //TODO
+               lpphy_tx_pctl_init_hw(dev);
        } else { /* This device is only software TX power control capable. */
-               if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ) {
-                       //TODO
-               } else {
-                       //TODO
-               }
-               //TODO set BB multiplier to 0x0096
+               lpphy_tx_pctl_init_sw(dev);
        }
 }
 
 static int b43_lpphy_op_init(struct b43_wldev *dev)
 {
-       /* TODO: band SPROM */
-       /* TODO: tables init */
+       lpphy_read_band_sprom(dev); //FIXME should this be in prepare_structs?
        lpphy_baseband_init(dev);
        lpphy_radio_init(dev);
-       //TODO calibrate RC
+       lpphy_calibrate_rc(dev);
        //TODO set channel
        lpphy_tx_pctl_init(dev);
-       //TODO full calib
+       lpphy_calibration(dev);
+       //TODO ACI init
 
        return 0;
 }
@@ -680,7 +1450,6 @@ static enum b43_txpwr_result b43_lpphy_op_recalc_txpower(struct b43_wldev *dev,
        return B43_TXPWR_RES_DONE;
 }
 
-
 const struct b43_phy_operations b43_phyops_lp = {
        .allocate               = b43_lpphy_op_allocate,
        .free                   = b43_lpphy_op_free,