drivers/gpu/drm/radeon/radeon_connectors.c

   1 /*
   2  * Copyright 2007-8 Advanced Micro Devices, Inc.
   3  * Copyright 2008 Red Hat Inc.
   4  *
   5  * Permission is hereby granted, free of charge, to any person obtaining a
   6  * copy of this software and associated documentation files (the "Software"),
   7  * to deal in the Software without restriction, including without limitation
   8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   9  * and/or sell copies of the Software, and to permit persons to whom the
  10  * Software is furnished to do so, subject to the following conditions:
  11  *
  12  * The above copyright notice and this permission notice shall be included in
  13  * all copies or substantial portions of the Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
  19  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
  20  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
  21  * OTHER DEALINGS IN THE SOFTWARE.
  22  *
  23  * Authors: Dave Airlie
  24  *          Alex Deucher
  25  */
  26 #include "drmP.h"
  27 #include "drm_edid.h"
  28 #include "drm_crtc_helper.h"
  29 #include "drm_fb_helper.h"
  30 #include "radeon_drm.h"
  31 #include "radeon.h"
  32 #include "atom.h"
  33
  34 extern void
  35 radeon_combios_connected_scratch_regs(struct drm_connector *connector,
  36                                       struct drm_encoder *encoder,
  37                                       bool connected);
  38 extern void
  39 radeon_atombios_connected_scratch_regs(struct drm_connector *connector,
  40                                        struct drm_encoder *encoder,
  41                                        bool connected);
  42
  43 void radeon_connector_hotplug(struct drm_connector *connector)
  44 {
  45         struct drm_device *dev = connector->dev;
  46         struct radeon_device *rdev = dev->dev_private;
  47         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
  48
  49         if (radeon_connector->hpd.hpd != RADEON_HPD_NONE)
  50                 radeon_hpd_set_polarity(rdev, radeon_connector->hpd.hpd);
  51
  52         if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
  53                 if (radeon_dp_getsinktype(radeon_connector) == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
  54                         if (radeon_dp_needs_link_train(radeon_connector)) {
  55                                 if (connector->encoder)
  56                                         dp_link_train(connector->encoder, connector);
  57                         }
  58                 }
  59         }
  60
  61 }
  62
  63 static void radeon_property_change_mode(struct drm_encoder *encoder)
  64 {
  65         struct drm_crtc *crtc = encoder->crtc;
  66
  67         if (crtc && crtc->enabled) {
  68                 drm_crtc_helper_set_mode(crtc, &crtc->mode,
  69                                          crtc->x, crtc->y, crtc->fb);
  70         }
  71 }
  72 static void
  73 radeon_connector_update_scratch_regs(struct drm_connector *connector, enum drm_connector_status status)
  74 {
  75         struct drm_device *dev = connector->dev;
  76         struct radeon_device *rdev = dev->dev_private;
  77         struct drm_encoder *best_encoder = NULL;
  78         struct drm_encoder *encoder = NULL;
  79         struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
  80         struct drm_mode_object *obj;
  81         bool connected;
  82         int i;
  83
  84         best_encoder = connector_funcs->best_encoder(connector);
  85
  86         for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
  87                 if (connector->encoder_ids[i] == 0)
  88                         break;
  89
  90                 obj = drm_mode_object_find(connector->dev,
  91                                            connector->encoder_ids[i],
  92                                            DRM_MODE_OBJECT_ENCODER);
  93                 if (!obj)
  94                         continue;
  95
  96                 encoder = obj_to_encoder(obj);
  97
  98                 if ((encoder == best_encoder) && (status == connector_status_connected))
  99                         connected = true;
 100                 else
 101                         connected = false;
 102
 103                 if (rdev->is_atom_bios)
 104                         radeon_atombios_connected_scratch_regs(connector, encoder, connected);
 105                 else
 106                         radeon_combios_connected_scratch_regs(connector, encoder, connected);
 107
 108         }
 109 }
 110
 111 struct drm_encoder *radeon_find_encoder(struct drm_connector *connector, int encoder_type)
 112 {
 113         struct drm_mode_object *obj;
 114         struct drm_encoder *encoder;
 115         int i;
 116
 117         for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
 118                 if (connector->encoder_ids[i] == 0)
 119                         break;
 120
 121                 obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
 122                 if (!obj)
 123                         continue;
 124
 125                 encoder = obj_to_encoder(obj);
 126                 if (encoder->encoder_type == encoder_type)
 127                         return encoder;
 128         }
 129         return NULL;
 130 }
 131
 132 struct drm_encoder *radeon_best_single_encoder(struct drm_connector *connector)
 133 {
 134         int enc_id = connector->encoder_ids[0];
 135         struct drm_mode_object *obj;
 136         struct drm_encoder *encoder;
 137
 138         /* pick the encoder ids */
 139         if (enc_id) {
 140                 obj = drm_mode_object_find(connector->dev, enc_id, DRM_MODE_OBJECT_ENCODER);
 141                 if (!obj)
 142                         return NULL;
 143                 encoder = obj_to_encoder(obj);
 144                 return encoder;
 145         }
 146         return NULL;
 147 }
 148
 149 /*
 150  * radeon_connector_analog_encoder_conflict_solve
 151  * - search for other connectors sharing this encoder
 152  *   if priority is true, then set them disconnected if this is connected
 153  *   if priority is false, set us disconnected if they are connected
 154  */
 155 static enum drm_connector_status
 156 radeon_connector_analog_encoder_conflict_solve(struct drm_connector *connector,
 157                                                struct drm_encoder *encoder,
 158                                                enum drm_connector_status current_status,
 159                                                bool priority)
 160 {
 161         struct drm_device *dev = connector->dev;
 162         struct drm_connector *conflict;
 163         int i;
 164
 165         list_for_each_entry(conflict, &dev->mode_config.connector_list, head) {
 166                 if (conflict == connector)
 167                         continue;
 168
 169                 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
 170                         if (conflict->encoder_ids[i] == 0)
 171                                 break;
 172
 173                         /* if the IDs match */
 174                         if (conflict->encoder_ids[i] == encoder->base.id) {
 175                                 if (conflict->status != connector_status_connected)
 176                                         continue;
 177
 178                                 if (priority == true) {
 179                                         DRM_INFO("1: conflicting encoders switching off %s\n", drm_get_connector_name(conflict));
 180                                         DRM_INFO("in favor of %s\n", drm_get_connector_name(connector));
 181                                         conflict->status = connector_status_disconnected;
 182                                         radeon_connector_update_scratch_regs(conflict, connector_status_disconnected);
 183                                 } else {
 184                                         DRM_INFO("2: conflicting encoders switching off %s\n", drm_get_connector_name(connector));
 185                                         DRM_INFO("in favor of %s\n", drm_get_connector_name(conflict));
 186                                         current_status = connector_status_disconnected;
 187                                 }
 188                                 break;
 189                         }
 190                 }
 191         }
 192         return current_status;
 193
 194 }
 195
 196 static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encoder)
 197 {
 198         struct drm_device *dev = encoder->dev;
 199         struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
 200         struct drm_display_mode *mode = NULL;
 201         struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
 202
 203         if (native_mode->hdisplay != 0 &&
 204             native_mode->vdisplay != 0 &&
 205             native_mode->clock != 0) {
 206                 mode = drm_mode_duplicate(dev, native_mode);
 207                 mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
 208                 drm_mode_set_name(mode);
 209
 210                 DRM_DEBUG("Adding native panel mode %s\n", mode->name);
 211         } else if (native_mode->hdisplay != 0 &&
 212                    native_mode->vdisplay != 0) {
 213                 /* mac laptops without an edid */
 214                 /* Note that this is not necessarily the exact panel mode,
 215                  * but an approximation based on the cvt formula.  For these
 216                  * systems we should ideally read the mode info out of the
 217                  * registers or add a mode table, but this works and is much
 218                  * simpler.
 219                  */
 220                 mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);
 221                 mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
 222                 DRM_DEBUG("Adding cvt approximation of native panel mode %s\n", mode->name);
 223         }
 224         return mode;
 225 }
 226
 227 static void radeon_add_common_modes(struct drm_encoder *encoder, struct drm_connector *connector)
 228 {
 229         struct drm_device *dev = encoder->dev;
 230         struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
 231         struct drm_display_mode *mode = NULL;
 232         struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
 233         int i;
 234         struct mode_size {
 235                 int w;
 236                 int h;
 237         } common_modes[17] = {
 238                 { 640,  480},
 239                 { 720,  480},
 240                 { 800,  600},
 241                 { 848,  480},
 242                 {1024,  768},
 243                 {1152,  768},
 244                 {1280,  720},
 245                 {1280,  800},
 246                 {1280,  854},
 247                 {1280,  960},
 248                 {1280, 1024},
 249                 {1440,  900},
 250                 {1400, 1050},
 251                 {1680, 1050},
 252                 {1600, 1200},
 253                 {1920, 1080},
 254                 {1920, 1200}
 255         };
 256
 257         for (i = 0; i < 17; i++) {
 258                 if (radeon_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {
 259                         if (common_modes[i].w > 1024 ||
 260                             common_modes[i].h > 768)
 261                                 continue;
 262                 }
 263                 if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
 264                         if (common_modes[i].w > native_mode->hdisplay ||
 265                             common_modes[i].h > native_mode->vdisplay ||
 266                             (common_modes[i].w == native_mode->hdisplay &&
 267                              common_modes[i].h == native_mode->vdisplay))
 268                                 continue;
 269                 }
 270                 if (common_modes[i].w < 320 || common_modes[i].h < 200)
 271                         continue;
 272
 273                 mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
 274                 drm_mode_probed_add(connector, mode);
 275         }
 276 }
 277
 278 int radeon_connector_set_property(struct drm_connector *connector, struct drm_property *property,
 279                                   uint64_t val)
 280 {
 281         struct drm_device *dev = connector->dev;
 282         struct radeon_device *rdev = dev->dev_private;
 283         struct drm_encoder *encoder;
 284         struct radeon_encoder *radeon_encoder;
 285
 286         if (property == rdev->mode_info.coherent_mode_property) {
 287                 struct radeon_encoder_atom_dig *dig;
 288
 289                 /* need to find digital encoder on connector */
 290                 encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 291                 if (!encoder)
 292                         return 0;
 293
 294                 radeon_encoder = to_radeon_encoder(encoder);
 295
 296                 if (!radeon_encoder->enc_priv)
 297                         return 0;
 298
 299                 dig = radeon_encoder->enc_priv;
 300                 dig->coherent_mode = val ? true : false;
 301                 radeon_property_change_mode(&radeon_encoder->base);
 302         }
 303
 304         if (property == rdev->mode_info.tv_std_property) {
 305                 encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TVDAC);
 306                 if (!encoder) {
 307                         encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_DAC);
 308                 }
 309
 310                 if (!encoder)
 311                         return 0;
 312
 313                 radeon_encoder = to_radeon_encoder(encoder);
 314                 if (!radeon_encoder->enc_priv)
 315                         return 0;
 316                 if (rdev->is_atom_bios) {
 317                         struct radeon_encoder_atom_dac *dac_int;
 318                         dac_int = radeon_encoder->enc_priv;
 319                         dac_int->tv_std = val;
 320                 } else {
 321                         struct radeon_encoder_tv_dac *dac_int;
 322                         dac_int = radeon_encoder->enc_priv;
 323                         dac_int->tv_std = val;
 324                 }
 325                 radeon_property_change_mode(&radeon_encoder->base);
 326         }
 327
 328         if (property == rdev->mode_info.load_detect_property) {
 329                 struct radeon_connector *radeon_connector =
 330                         to_radeon_connector(connector);
 331
 332                 if (val == 0)
 333                         radeon_connector->dac_load_detect = false;
 334                 else
 335                         radeon_connector->dac_load_detect = true;
 336         }
 337
 338         if (property == rdev->mode_info.tmds_pll_property) {
 339                 struct radeon_encoder_int_tmds *tmds = NULL;
 340                 bool ret = false;
 341                 /* need to find digital encoder on connector */
 342                 encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 343                 if (!encoder)
 344                         return 0;
 345
 346                 radeon_encoder = to_radeon_encoder(encoder);
 347
 348                 tmds = radeon_encoder->enc_priv;
 349                 if (!tmds)
 350                         return 0;
 351
 352                 if (val == 0) {
 353                         if (rdev->is_atom_bios)
 354                                 ret = radeon_atombios_get_tmds_info(radeon_encoder, tmds);
 355                         else
 356                                 ret = radeon_legacy_get_tmds_info_from_combios(radeon_encoder, tmds);
 357                 }
 358                 if (val == 1 || ret == false) {
 359                         radeon_legacy_get_tmds_info_from_table(radeon_encoder, tmds);
 360                 }
 361                 radeon_property_change_mode(&radeon_encoder->base);
 362         }
 363
 364         return 0;
 365 }
 366
 367 static void radeon_fixup_lvds_native_mode(struct drm_encoder *encoder,
 368                                           struct drm_connector *connector)
 369 {
 370         struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
 371         struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
 372
 373         /* Try to get native mode details from EDID if necessary */
 374         if (!native_mode->clock) {
 375                 struct drm_display_mode *t, *mode;
 376
 377                 list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
 378                         if (mode->hdisplay == native_mode->hdisplay &&
 379                             mode->vdisplay == native_mode->vdisplay) {
 380                                 *native_mode = *mode;
 381                                 drm_mode_set_crtcinfo(native_mode, CRTC_INTERLACE_HALVE_V);
 382                                 DRM_INFO("Determined LVDS native mode details from EDID\n");
 383                                 break;
 384                         }
 385                 }
 386         }
 387         if (!native_mode->clock) {
 388                 DRM_INFO("No LVDS native mode details, disabling RMX\n");
 389                 radeon_encoder->rmx_type = RMX_OFF;
 390         }
 391 }
 392
 393 static int radeon_lvds_get_modes(struct drm_connector *connector)
 394 {
 395         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 396         struct drm_encoder *encoder;
 397         int ret = 0;
 398         struct drm_display_mode *mode;
 399
 400         if (radeon_connector->ddc_bus) {
 401                 ret = radeon_ddc_get_modes(radeon_connector);
 402                 if (ret > 0) {
 403                         encoder = radeon_best_single_encoder(connector);
 404                         if (encoder) {
 405                                 radeon_fixup_lvds_native_mode(encoder, connector);
 406                                 /* add scaled modes */
 407                                 radeon_add_common_modes(encoder, connector);
 408                         }
 409                         return ret;
 410                 }
 411         }
 412
 413         encoder = radeon_best_single_encoder(connector);
 414         if (!encoder)
 415                 return 0;
 416
 417         /* we have no EDID modes */
 418         mode = radeon_fp_native_mode(encoder);
 419         if (mode) {
 420                 ret = 1;
 421                 drm_mode_probed_add(connector, mode);
 422                 /* add scaled modes */
 423                 radeon_add_common_modes(encoder, connector);
 424         }
 425
 426         return ret;
 427 }
 428
 429 static int radeon_lvds_mode_valid(struct drm_connector *connector,
 430                                   struct drm_display_mode *mode)
 431 {
 432         struct drm_encoder *encoder = radeon_best_single_encoder(connector);
 433
 434         if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
 435                 return MODE_PANEL;
 436
 437         if (encoder) {
 438                 struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
 439                 struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
 440
 441                 /* AVIVO hardware supports downscaling modes larger than the panel
 442                  * to the panel size, but I'm not sure this is desirable.
 443                  */
 444                 if ((mode->hdisplay > native_mode->hdisplay) ||
 445                     (mode->vdisplay > native_mode->vdisplay))
 446                         return MODE_PANEL;
 447
 448                 /* if scaling is disabled, block non-native modes */
 449                 if (radeon_encoder->rmx_type == RMX_OFF) {
 450                         if ((mode->hdisplay != native_mode->hdisplay) ||
 451                             (mode->vdisplay != native_mode->vdisplay))
 452                                 return MODE_PANEL;
 453                 }
 454         }
 455
 456         return MODE_OK;
 457 }
 458
 459 static enum drm_connector_status radeon_lvds_detect(struct drm_connector *connector)
 460 {
 461         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 462         struct drm_encoder *encoder = radeon_best_single_encoder(connector);
 463         enum drm_connector_status ret = connector_status_disconnected;
 464
 465         if (encoder) {
 466                 struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
 467                 struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
 468
 469                 /* check if panel is valid */
 470                 if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
 471                         ret = connector_status_connected;
 472
 473         }
 474
 475         /* check for edid as well */
 476         if (radeon_connector->edid)
 477                 ret = connector_status_connected;
 478         else {
 479                 if (radeon_connector->ddc_bus) {
 480                         radeon_i2c_do_lock(radeon_connector->ddc_bus, 1);
 481                         radeon_connector->edid = drm_get_edid(&radeon_connector->base,
 482                                                               &radeon_connector->ddc_bus->adapter);
 483                         radeon_i2c_do_lock(radeon_connector->ddc_bus, 0);
 484                         if (radeon_connector->edid)
 485                                 ret = connector_status_connected;
 486                 }
 487         }
 488         /* check acpi lid status ??? */
 489
 490         radeon_connector_update_scratch_regs(connector, ret);
 491         return ret;
 492 }
 493
 494 static void radeon_connector_destroy(struct drm_connector *connector)
 495 {
 496         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 497
 498         if (radeon_connector->ddc_bus)
 499                 radeon_i2c_destroy(radeon_connector->ddc_bus);
 500         if (radeon_connector->edid)
 501                 kfree(radeon_connector->edid);
 502         kfree(radeon_connector->con_priv);
 503         drm_sysfs_connector_remove(connector);
 504         drm_connector_cleanup(connector);
 505         kfree(connector);
 506 }
 507
 508 static int radeon_lvds_set_property(struct drm_connector *connector,
 509                                     struct drm_property *property,
 510                                     uint64_t value)
 511 {
 512         struct drm_device *dev = connector->dev;
 513         struct radeon_encoder *radeon_encoder;
 514         enum radeon_rmx_type rmx_type;
 515
 516         DRM_DEBUG("\n");
 517         if (property != dev->mode_config.scaling_mode_property)
 518                 return 0;
 519
 520         if (connector->encoder)
 521                 radeon_encoder = to_radeon_encoder(connector->encoder);
 522         else {
 523                 struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
 524                 radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
 525         }
 526
 527         switch (value) {
 528         case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
 529         case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
 530         case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
 531         default:
 532         case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
 533         }
 534         if (radeon_encoder->rmx_type == rmx_type)
 535                 return 0;
 536
 537         radeon_encoder->rmx_type = rmx_type;
 538
 539         radeon_property_change_mode(&radeon_encoder->base);
 540         return 0;
 541 }
 542
 543
 544 struct drm_connector_helper_funcs radeon_lvds_connector_helper_funcs = {
 545         .get_modes = radeon_lvds_get_modes,
 546         .mode_valid = radeon_lvds_mode_valid,
 547         .best_encoder = radeon_best_single_encoder,
 548 };
 549
 550 struct drm_connector_funcs radeon_lvds_connector_funcs = {
 551         .dpms = drm_helper_connector_dpms,
 552         .detect = radeon_lvds_detect,
 553         .fill_modes = drm_helper_probe_single_connector_modes,
 554         .destroy = radeon_connector_destroy,
 555         .set_property = radeon_lvds_set_property,
 556 };
 557
 558 static int radeon_vga_get_modes(struct drm_connector *connector)
 559 {
 560         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 561         int ret;
 562
 563         ret = radeon_ddc_get_modes(radeon_connector);
 564
 565         return ret;
 566 }
 567
 568 static int radeon_vga_mode_valid(struct drm_connector *connector,
 569                                   struct drm_display_mode *mode)
 570 {
 571         /* XXX check mode bandwidth */
 572         /* XXX verify against max DAC output frequency */
 573         return MODE_OK;
 574 }
 575
 576 static enum drm_connector_status radeon_vga_detect(struct drm_connector *connector)
 577 {
 578         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 579         struct drm_encoder *encoder;
 580         struct drm_encoder_helper_funcs *encoder_funcs;
 581         bool dret;
 582         enum drm_connector_status ret = connector_status_disconnected;
 583
 584         encoder = radeon_best_single_encoder(connector);
 585         if (!encoder)
 586                 ret = connector_status_disconnected;
 587
 588         radeon_i2c_do_lock(radeon_connector->ddc_bus, 1);
 589         dret = radeon_ddc_probe(radeon_connector);
 590         radeon_i2c_do_lock(radeon_connector->ddc_bus, 0);
 591         if (dret) {
 592                 if (radeon_connector->edid) {
 593                         kfree(radeon_connector->edid);
 594                         radeon_connector->edid = NULL;
 595                 }
 596                 radeon_i2c_do_lock(radeon_connector->ddc_bus, 1);
 597                 radeon_connector->edid = drm_get_edid(&radeon_connector->base, &radeon_connector->ddc_bus->adapter);
 598                 radeon_i2c_do_lock(radeon_connector->ddc_bus, 0);
 599
 600                 if (!radeon_connector->edid) {
 601                         DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
 602                                         drm_get_connector_name(connector));
 603                         ret = connector_status_connected;
 604                 } else {
 605                         radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
 606
 607                         /* some oems have boards with separate digital and analog connectors
 608                          * with a shared ddc line (often vga + hdmi)
 609                          */
 610                         if (radeon_connector->use_digital && radeon_connector->shared_ddc) {
 611                                 kfree(radeon_connector->edid);
 612                                 radeon_connector->edid = NULL;
 613                                 ret = connector_status_disconnected;
 614                         } else
 615                                 ret = connector_status_connected;
 616                 }
 617         } else {
 618                 if (radeon_connector->dac_load_detect) {
 619                         encoder_funcs = encoder->helper_private;
 620                         ret = encoder_funcs->detect(encoder, connector);
 621                 }
 622         }
 623
 624         if (ret == connector_status_connected)
 625                 ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
 626         radeon_connector_update_scratch_regs(connector, ret);
 627         return ret;
 628 }
 629
 630 struct drm_connector_helper_funcs radeon_vga_connector_helper_funcs = {
 631         .get_modes = radeon_vga_get_modes,
 632         .mode_valid = radeon_vga_mode_valid,
 633         .best_encoder = radeon_best_single_encoder,
 634 };
 635
 636 struct drm_connector_funcs radeon_vga_connector_funcs = {
 637         .dpms = drm_helper_connector_dpms,
 638         .detect = radeon_vga_detect,
 639         .fill_modes = drm_helper_probe_single_connector_modes,
 640         .destroy = radeon_connector_destroy,
 641         .set_property = radeon_connector_set_property,
 642 };
 643
 644 static int radeon_tv_get_modes(struct drm_connector *connector)
 645 {
 646         struct drm_device *dev = connector->dev;
 647         struct radeon_device *rdev = dev->dev_private;
 648         struct drm_display_mode *tv_mode;
 649         struct drm_encoder *encoder;
 650
 651         encoder = radeon_best_single_encoder(connector);
 652         if (!encoder)
 653                 return 0;
 654
 655         /* avivo chips can scale any mode */
 656         if (rdev->family >= CHIP_RS600)
 657                 /* add scaled modes */
 658                 radeon_add_common_modes(encoder, connector);
 659         else {
 660                 /* only 800x600 is supported right now on pre-avivo chips */
 661                 tv_mode = drm_cvt_mode(dev, 800, 600, 60, false, false, false);
 662                 tv_mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
 663                 drm_mode_probed_add(connector, tv_mode);
 664         }
 665         return 1;
 666 }
 667
 668 static int radeon_tv_mode_valid(struct drm_connector *connector,
 669                                 struct drm_display_mode *mode)
 670 {
 671         if ((mode->hdisplay > 1024) || (mode->vdisplay > 768))
 672                 return MODE_CLOCK_RANGE;
 673         return MODE_OK;
 674 }
 675
 676 static enum drm_connector_status radeon_tv_detect(struct drm_connector *connector)
 677 {
 678         struct drm_encoder *encoder;
 679         struct drm_encoder_helper_funcs *encoder_funcs;
 680         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 681         enum drm_connector_status ret = connector_status_disconnected;
 682
 683         if (!radeon_connector->dac_load_detect)
 684                 return ret;
 685
 686         encoder = radeon_best_single_encoder(connector);
 687         if (!encoder)
 688                 ret = connector_status_disconnected;
 689         else {
 690                 encoder_funcs = encoder->helper_private;
 691                 ret = encoder_funcs->detect(encoder, connector);
 692         }
 693         if (ret == connector_status_connected)
 694                 ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, false);
 695         radeon_connector_update_scratch_regs(connector, ret);
 696         return ret;
 697 }
 698
 699 struct drm_connector_helper_funcs radeon_tv_connector_helper_funcs = {
 700         .get_modes = radeon_tv_get_modes,
 701         .mode_valid = radeon_tv_mode_valid,
 702         .best_encoder = radeon_best_single_encoder,
 703 };
 704
 705 struct drm_connector_funcs radeon_tv_connector_funcs = {
 706         .dpms = drm_helper_connector_dpms,
 707         .detect = radeon_tv_detect,
 708         .fill_modes = drm_helper_probe_single_connector_modes,
 709         .destroy = radeon_connector_destroy,
 710         .set_property = radeon_connector_set_property,
 711 };
 712
 713 static int radeon_dvi_get_modes(struct drm_connector *connector)
 714 {
 715         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 716         int ret;
 717
 718         ret = radeon_ddc_get_modes(radeon_connector);
 719         return ret;
 720 }
 721
 722 /*
 723  * DVI is complicated
 724  * Do a DDC probe, if DDC probe passes, get the full EDID so
 725  * we can do analog/digital monitor detection at this point.
 726  * If the monitor is an analog monitor or we got no DDC,
 727  * we need to find the DAC encoder object for this connector.
 728  * If we got no DDC, we do load detection on the DAC encoder object.
 729  * If we got analog DDC or load detection passes on the DAC encoder
 730  * we have to check if this analog encoder is shared with anyone else (TV)
 731  * if its shared we have to set the other connector to disconnected.
 732  */
 733 static enum drm_connector_status radeon_dvi_detect(struct drm_connector *connector)
 734 {
 735         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 736         struct drm_encoder *encoder = NULL;
 737         struct drm_encoder_helper_funcs *encoder_funcs;
 738         struct drm_mode_object *obj;
 739         int i;
 740         enum drm_connector_status ret = connector_status_disconnected;
 741         bool dret;
 742
 743         radeon_i2c_do_lock(radeon_connector->ddc_bus, 1);
 744         dret = radeon_ddc_probe(radeon_connector);
 745         radeon_i2c_do_lock(radeon_connector->ddc_bus, 0);
 746         if (dret) {
 747                 if (radeon_connector->edid) {
 748                         kfree(radeon_connector->edid);
 749                         radeon_connector->edid = NULL;
 750                 }
 751                 radeon_i2c_do_lock(radeon_connector->ddc_bus, 1);
 752                 radeon_connector->edid = drm_get_edid(&radeon_connector->base, &radeon_connector->ddc_bus->adapter);
 753                 radeon_i2c_do_lock(radeon_connector->ddc_bus, 0);
 754
 755                 if (!radeon_connector->edid) {
 756                         DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
 757                                         drm_get_connector_name(connector));
 758                 } else {
 759                         radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
 760
 761                         /* some oems have boards with separate digital and analog connectors
 762                          * with a shared ddc line (often vga + hdmi)
 763                          */
 764                         if ((!radeon_connector->use_digital) && radeon_connector->shared_ddc) {
 765                                 kfree(radeon_connector->edid);
 766                                 radeon_connector->edid = NULL;
 767                                 ret = connector_status_disconnected;
 768                         } else
 769                                 ret = connector_status_connected;
 770
 771                         /* multiple connectors on the same encoder with the same ddc line
 772                          * This tends to be HDMI and DVI on the same encoder with the
 773                          * same ddc line.  If the edid says HDMI, consider the HDMI port
 774                          * connected and the DVI port disconnected.  If the edid doesn't
 775                          * say HDMI, vice versa.
 776                          */
 777                         if (radeon_connector->shared_ddc && connector_status_connected) {
 778                                 struct drm_device *dev = connector->dev;
 779                                 struct drm_connector *list_connector;
 780                                 struct radeon_connector *list_radeon_connector;
 781                                 list_for_each_entry(list_connector, &dev->mode_config.connector_list, head) {
 782                                         if (connector == list_connector)
 783                                                 continue;
 784                                         list_radeon_connector = to_radeon_connector(list_connector);
 785                                         if (radeon_connector->devices == list_radeon_connector->devices) {
 786                                                 if (drm_detect_hdmi_monitor(radeon_connector->edid)) {
 787                                                         if (connector->connector_type == DRM_MODE_CONNECTOR_DVID) {
 788                                                                 kfree(radeon_connector->edid);
 789                                                                 radeon_connector->edid = NULL;
 790                                                                 ret = connector_status_disconnected;
 791                                                         }
 792                                                 } else {
 793                                                         if ((connector->connector_type == DRM_MODE_CONNECTOR_HDMIA) ||
 794                                                             (connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)) {
 795                                                                 kfree(radeon_connector->edid);
 796                                                                 radeon_connector->edid = NULL;
 797                                                                 ret = connector_status_disconnected;
 798                                                         }
 799                                                 }
 800                                         }
 801                                 }
 802                         }
 803                 }
 804         }
 805
 806         if ((ret == connector_status_connected) && (radeon_connector->use_digital == true))
 807                 goto out;
 808
 809         /* find analog encoder */
 810         if (radeon_connector->dac_load_detect) {
 811                 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
 812                         if (connector->encoder_ids[i] == 0)
 813                                 break;
 814
 815                         obj = drm_mode_object_find(connector->dev,
 816                                                    connector->encoder_ids[i],
 817                                                    DRM_MODE_OBJECT_ENCODER);
 818                         if (!obj)
 819                                 continue;
 820
 821                         encoder = obj_to_encoder(obj);
 822
 823                         encoder_funcs = encoder->helper_private;
 824                         if (encoder_funcs->detect) {
 825                                 if (ret != connector_status_connected) {
 826                                         ret = encoder_funcs->detect(encoder, connector);
 827                                         if (ret == connector_status_connected) {
 828                                                 radeon_connector->use_digital = false;
 829                                         }
 830                                 }
 831                                 break;
 832                         }
 833                 }
 834         }
 835
 836         if ((ret == connector_status_connected) && (radeon_connector->use_digital == false) &&
 837             encoder) {
 838                 ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
 839         }
 840
 841 out:
 842         /* updated in get modes as well since we need to know if it's analog or digital */
 843         radeon_connector_update_scratch_regs(connector, ret);
 844         return ret;
 845 }
 846
 847 /* okay need to be smart in here about which encoder to pick */
 848 struct drm_encoder *radeon_dvi_encoder(struct drm_connector *connector)
 849 {
 850         int enc_id = connector->encoder_ids[0];
 851         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 852         struct drm_mode_object *obj;
 853         struct drm_encoder *encoder;
 854         int i;
 855         for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
 856                 if (connector->encoder_ids[i] == 0)
 857                         break;
 858
 859                 obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
 860                 if (!obj)
 861                         continue;
 862
 863                 encoder = obj_to_encoder(obj);
 864
 865                 if (radeon_connector->use_digital == true) {
 866                         if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
 867                                 return encoder;
 868                 } else {
 869                         if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
 870                             encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
 871                                 return encoder;
 872                 }
 873         }
 874
 875         /* see if we have a default encoder  TODO */
 876
 877         /* then check use digitial */
 878         /* pick the first one */
 879         if (enc_id) {
 880                 obj = drm_mode_object_find(connector->dev, enc_id, DRM_MODE_OBJECT_ENCODER);
 881                 if (!obj)
 882                         return NULL;
 883                 encoder = obj_to_encoder(obj);
 884                 return encoder;
 885         }
 886         return NULL;
 887 }
 888
 889 static void radeon_dvi_force(struct drm_connector *connector)
 890 {
 891         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 892         if (connector->force == DRM_FORCE_ON)
 893                 radeon_connector->use_digital = false;
 894         if (connector->force == DRM_FORCE_ON_DIGITAL)
 895                 radeon_connector->use_digital = true;
 896 }
 897
 898 static int radeon_dvi_mode_valid(struct drm_connector *connector,
 899                                   struct drm_display_mode *mode)
 900 {
 901         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 902
 903         /* XXX check mode bandwidth */
 904
 905         if (radeon_connector->use_digital && (mode->clock > 165000)) {
 906                 if ((radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I) ||
 907                     (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D) ||
 908                     (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_HDMI_TYPE_B))
 909                         return MODE_OK;
 910                 else
 911                         return MODE_CLOCK_HIGH;
 912         }
 913         return MODE_OK;
 914 }
 915
 916 struct drm_connector_helper_funcs radeon_dvi_connector_helper_funcs = {
 917         .get_modes = radeon_dvi_get_modes,
 918         .mode_valid = radeon_dvi_mode_valid,
 919         .best_encoder = radeon_dvi_encoder,
 920 };
 921
 922 struct drm_connector_funcs radeon_dvi_connector_funcs = {
 923         .dpms = drm_helper_connector_dpms,
 924         .detect = radeon_dvi_detect,
 925         .fill_modes = drm_helper_probe_single_connector_modes,
 926         .set_property = radeon_connector_set_property,
 927         .destroy = radeon_connector_destroy,
 928         .force = radeon_dvi_force,
 929 };
 930
 931 static void radeon_dp_connector_destroy(struct drm_connector *connector)
 932 {
 933         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 934         struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
 935
 936         if (radeon_connector->ddc_bus)
 937                 radeon_i2c_destroy(radeon_connector->ddc_bus);
 938         if (radeon_connector->edid)
 939                 kfree(radeon_connector->edid);
 940         if (radeon_dig_connector->dp_i2c_bus)
 941                 radeon_i2c_destroy(radeon_dig_connector->dp_i2c_bus);
 942         kfree(radeon_connector->con_priv);
 943         drm_sysfs_connector_remove(connector);
 944         drm_connector_cleanup(connector);
 945         kfree(connector);
 946 }
 947
 948 static int radeon_dp_get_modes(struct drm_connector *connector)
 949 {
 950         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 951         int ret;
 952
 953         ret = radeon_ddc_get_modes(radeon_connector);
 954         return ret;
 955 }
 956
 957 static enum drm_connector_status radeon_dp_detect(struct drm_connector *connector)
 958 {
 959         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 960         enum drm_connector_status ret = connector_status_disconnected;
 961         struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
 962         u8 sink_type;
 963
 964         if (radeon_connector->edid) {
 965                 kfree(radeon_connector->edid);
 966                 radeon_connector->edid = NULL;
 967         }
 968
 969         sink_type = radeon_dp_getsinktype(radeon_connector);
 970         if (sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
 971                 if (radeon_dp_getdpcd(radeon_connector)) {
 972                         radeon_dig_connector->dp_sink_type = sink_type;
 973                         ret = connector_status_connected;
 974                 }
 975         } else {
 976                 radeon_i2c_do_lock(radeon_connector->ddc_bus, 1);
 977                 if (radeon_ddc_probe(radeon_connector)) {
 978                         radeon_dig_connector->dp_sink_type = sink_type;
 979                         ret = connector_status_connected;
 980                 }
 981                 radeon_i2c_do_lock(radeon_connector->ddc_bus, 0);
 982         }
 983
 984         return ret;
 985 }
 986
 987 static int radeon_dp_mode_valid(struct drm_connector *connector,
 988                                   struct drm_display_mode *mode)
 989 {
 990         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 991         struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
 992
 993         /* XXX check mode bandwidth */
 994
 995         if (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT)
 996                 return radeon_dp_mode_valid_helper(radeon_connector, mode);
 997         else
 998                 return MODE_OK;
 999 }
1000
1001 struct drm_connector_helper_funcs radeon_dp_connector_helper_funcs = {
1002         .get_modes = radeon_dp_get_modes,
1003         .mode_valid = radeon_dp_mode_valid,
1004         .best_encoder = radeon_dvi_encoder,
1005 };
1006
1007 struct drm_connector_funcs radeon_dp_connector_funcs = {
1008         .dpms = drm_helper_connector_dpms,
1009         .detect = radeon_dp_detect,
1010         .fill_modes = drm_helper_probe_single_connector_modes,
1011         .set_property = radeon_connector_set_property,
1012         .destroy = radeon_dp_connector_destroy,
1013         .force = radeon_dvi_force,
1014 };
1015
1016 void
1017 radeon_add_atom_connector(struct drm_device *dev,
1018                           uint32_t connector_id,
1019                           uint32_t supported_device,
1020                           int connector_type,
1021                           struct radeon_i2c_bus_rec *i2c_bus,
1022                           bool linkb,
1023                           uint32_t igp_lane_info,
1024                           uint16_t connector_object_id,
1025                           struct radeon_hpd *hpd)
1026 {
1027         struct radeon_device *rdev = dev->dev_private;
1028         struct drm_connector *connector;
1029         struct radeon_connector *radeon_connector;
1030         struct radeon_connector_atom_dig *radeon_dig_connector;
1031         uint32_t subpixel_order = SubPixelNone;
1032         bool shared_ddc = false;
1033         int ret;
1034
1035         /* fixme - tv/cv/din */
1036         if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1037                 return;
1038
1039         /* see if we already added it */
1040         list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1041                 radeon_connector = to_radeon_connector(connector);
1042                 if (radeon_connector->connector_id == connector_id) {
1043                         radeon_connector->devices |= supported_device;
1044                         return;
1045                 }
1046                 if (radeon_connector->ddc_bus && i2c_bus->valid) {
1047                         if (memcmp(&radeon_connector->ddc_bus->rec, i2c_bus,
1048                                     sizeof(struct radeon_i2c_bus_rec)) == 0) {
1049                                 radeon_connector->shared_ddc = true;
1050                                 shared_ddc = true;
1051                         }
1052                 }
1053         }
1054
1055         radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
1056         if (!radeon_connector)
1057                 return;
1058
1059         connector = &radeon_connector->base;
1060
1061         radeon_connector->connector_id = connector_id;
1062         radeon_connector->devices = supported_device;
1063         radeon_connector->shared_ddc = shared_ddc;
1064         radeon_connector->connector_object_id = connector_object_id;
1065         radeon_connector->hpd = *hpd;
1066         switch (connector_type) {
1067         case DRM_MODE_CONNECTOR_VGA:
1068                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1069                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1070                 if (ret)
1071                         goto failed;
1072                 if (i2c_bus->valid) {
1073                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "VGA");
1074                         if (!radeon_connector->ddc_bus)
1075                                 goto failed;
1076                 }
1077                 radeon_connector->dac_load_detect = true;
1078                 drm_connector_attach_property(&radeon_connector->base,
1079                                               rdev->mode_info.load_detect_property,
1080                                               1);
1081                 break;
1082         case DRM_MODE_CONNECTOR_DVIA:
1083                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1084                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1085                 if (ret)
1086                         goto failed;
1087                 if (i2c_bus->valid) {
1088                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
1089                         if (!radeon_connector->ddc_bus)
1090                                 goto failed;
1091                 }
1092                 radeon_connector->dac_load_detect = true;
1093                 drm_connector_attach_property(&radeon_connector->base,
1094                                               rdev->mode_info.load_detect_property,
1095                                               1);
1096                 break;
1097         case DRM_MODE_CONNECTOR_DVII:
1098         case DRM_MODE_CONNECTOR_DVID:
1099                 radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1100                 if (!radeon_dig_connector)
1101                         goto failed;
1102                 radeon_dig_connector->linkb = linkb;
1103                 radeon_dig_connector->igp_lane_info = igp_lane_info;
1104                 radeon_connector->con_priv = radeon_dig_connector;
1105                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
1106                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
1107                 if (ret)
1108                         goto failed;
1109                 if (i2c_bus->valid) {
1110                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
1111                         if (!radeon_connector->ddc_bus)
1112                                 goto failed;
1113                 }
1114                 subpixel_order = SubPixelHorizontalRGB;
1115                 drm_connector_attach_property(&radeon_connector->base,
1116                                               rdev->mode_info.coherent_mode_property,
1117                                               1);
1118                 if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1119                         radeon_connector->dac_load_detect = true;
1120                         drm_connector_attach_property(&radeon_connector->base,
1121                                                       rdev->mode_info.load_detect_property,
1122                                                       1);
1123                 }
1124                 break;
1125         case DRM_MODE_CONNECTOR_HDMIA:
1126         case DRM_MODE_CONNECTOR_HDMIB:
1127                 radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1128                 if (!radeon_dig_connector)
1129                         goto failed;
1130                 radeon_dig_connector->linkb = linkb;
1131                 radeon_dig_connector->igp_lane_info = igp_lane_info;
1132                 radeon_connector->con_priv = radeon_dig_connector;
1133                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
1134                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
1135                 if (ret)
1136                         goto failed;
1137                 if (i2c_bus->valid) {
1138                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "HDMI");
1139                         if (!radeon_connector->ddc_bus)
1140                                 goto failed;
1141                 }
1142                 drm_connector_attach_property(&radeon_connector->base,
1143                                               rdev->mode_info.coherent_mode_property,
1144                                               1);
1145                 subpixel_order = SubPixelHorizontalRGB;
1146                 break;
1147         case DRM_MODE_CONNECTOR_DisplayPort:
1148                 radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1149                 if (!radeon_dig_connector)
1150                         goto failed;
1151                 radeon_dig_connector->linkb = linkb;
1152                 radeon_dig_connector->igp_lane_info = igp_lane_info;
1153                 radeon_connector->con_priv = radeon_dig_connector;
1154                 drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type);
1155                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
1156                 if (ret)
1157                         goto failed;
1158                 if (i2c_bus->valid) {
1159                         /* add DP i2c bus */
1160                         radeon_dig_connector->dp_i2c_bus = radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch");
1161                         if (!radeon_dig_connector->dp_i2c_bus)
1162                                 goto failed;
1163                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DP");
1164                         if (!radeon_connector->ddc_bus)
1165                                 goto failed;
1166                 }
1167                 subpixel_order = SubPixelHorizontalRGB;
1168                 drm_connector_attach_property(&radeon_connector->base,
1169                                               rdev->mode_info.coherent_mode_property,
1170                                               1);
1171                 break;
1172         case DRM_MODE_CONNECTOR_SVIDEO:
1173         case DRM_MODE_CONNECTOR_Composite:
1174         case DRM_MODE_CONNECTOR_9PinDIN:
1175                 if (radeon_tv == 1) {
1176                         drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
1177                         ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
1178                         if (ret)
1179                                 goto failed;
1180                         radeon_connector->dac_load_detect = true;
1181                         drm_connector_attach_property(&radeon_connector->base,
1182                                                       rdev->mode_info.load_detect_property,
1183                                                       1);
1184                         drm_connector_attach_property(&radeon_connector->base,
1185                                                       rdev->mode_info.tv_std_property,
1186                                                       radeon_atombios_get_tv_info(rdev));
1187                 }
1188                 break;
1189         case DRM_MODE_CONNECTOR_LVDS:
1190                 radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1191                 if (!radeon_dig_connector)
1192                         goto failed;
1193                 radeon_dig_connector->linkb = linkb;
1194                 radeon_dig_connector->igp_lane_info = igp_lane_info;
1195                 radeon_connector->con_priv = radeon_dig_connector;
1196                 drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
1197                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
1198                 if (ret)
1199                         goto failed;
1200                 if (i2c_bus->valid) {
1201                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "LVDS");
1202                         if (!radeon_connector->ddc_bus)
1203                                 goto failed;
1204                 }
1205                 drm_connector_attach_property(&radeon_connector->base,
1206                                               dev->mode_config.scaling_mode_property,
1207                                               DRM_MODE_SCALE_FULLSCREEN);
1208                 subpixel_order = SubPixelHorizontalRGB;
1209                 break;
1210         }
1211
1212         connector->display_info.subpixel_order = subpixel_order;
1213         drm_sysfs_connector_add(connector);
1214         return;
1215
1216 failed:
1217         if (radeon_connector->ddc_bus)
1218                 radeon_i2c_destroy(radeon_connector->ddc_bus);
1219         drm_connector_cleanup(connector);
1220         kfree(connector);
1221 }
1222
1223 void
1224 radeon_add_legacy_connector(struct drm_device *dev,
1225                             uint32_t connector_id,
1226                             uint32_t supported_device,
1227                             int connector_type,
1228                             struct radeon_i2c_bus_rec *i2c_bus,
1229                             uint16_t connector_object_id,
1230                             struct radeon_hpd *hpd)
1231 {
1232         struct radeon_device *rdev = dev->dev_private;
1233         struct drm_connector *connector;
1234         struct radeon_connector *radeon_connector;
1235         uint32_t subpixel_order = SubPixelNone;
1236         int ret;
1237
1238         /* fixme - tv/cv/din */
1239         if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1240                 return;
1241
1242         /* see if we already added it */
1243         list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1244                 radeon_connector = to_radeon_connector(connector);
1245                 if (radeon_connector->connector_id == connector_id) {
1246                         radeon_connector->devices |= supported_device;
1247                         return;
1248                 }
1249         }
1250
1251         radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
1252         if (!radeon_connector)
1253                 return;
1254
1255         connector = &radeon_connector->base;
1256
1257         radeon_connector->connector_id = connector_id;
1258         radeon_connector->devices = supported_device;
1259         radeon_connector->connector_object_id = connector_object_id;
1260         radeon_connector->hpd = *hpd;
1261         switch (connector_type) {
1262         case DRM_MODE_CONNECTOR_VGA:
1263                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1264                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1265                 if (ret)
1266                         goto failed;
1267                 if (i2c_bus->valid) {
1268                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "VGA");
1269                         if (!radeon_connector->ddc_bus)
1270                                 goto failed;
1271                 }
1272                 radeon_connector->dac_load_detect = true;
1273                 drm_connector_attach_property(&radeon_connector->base,
1274                                               rdev->mode_info.load_detect_property,
1275                                               1);
1276                 break;
1277         case DRM_MODE_CONNECTOR_DVIA:
1278                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1279                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1280                 if (ret)
1281                         goto failed;
1282                 if (i2c_bus->valid) {
1283                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
1284                         if (!radeon_connector->ddc_bus)
1285                                 goto failed;
1286                 }
1287                 radeon_connector->dac_load_detect = true;
1288                 drm_connector_attach_property(&radeon_connector->base,
1289                                               rdev->mode_info.load_detect_property,
1290                                               1);
1291                 break;
1292         case DRM_MODE_CONNECTOR_DVII:
1293         case DRM_MODE_CONNECTOR_DVID:
1294                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
1295                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
1296                 if (ret)
1297                         goto failed;
1298                 if (i2c_bus->valid) {
1299                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
1300                         if (!radeon_connector->ddc_bus)
1301                                 goto failed;
1302                         radeon_connector->dac_load_detect = true;
1303                         drm_connector_attach_property(&radeon_connector->base,
1304                                                       rdev->mode_info.load_detect_property,
1305                                                       1);
1306                 }
1307                 subpixel_order = SubPixelHorizontalRGB;
1308                 break;
1309         case DRM_MODE_CONNECTOR_SVIDEO:
1310         case DRM_MODE_CONNECTOR_Composite:
1311         case DRM_MODE_CONNECTOR_9PinDIN:
1312                 if (radeon_tv == 1) {
1313                         drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
1314                         ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
1315                         if (ret)
1316                                 goto failed;
1317                         radeon_connector->dac_load_detect = true;
1318                         /* RS400,RC410,RS480 chipset seems to report a lot
1319                          * of false positive on load detect, we haven't yet
1320                          * found a way to make load detect reliable on those
1321                          * chipset, thus just disable it for TV.
1322                          */
1323                         if (rdev->family == CHIP_RS400 || rdev->family == CHIP_RS480)
1324                                 radeon_connector->dac_load_detect = false;
1325                         drm_connector_attach_property(&radeon_connector->base,
1326                                                       rdev->mode_info.load_detect_property,
1327                                                       1);
1328                         drm_connector_attach_property(&radeon_connector->base,
1329                                                       rdev->mode_info.tv_std_property,
1330                                                       radeon_combios_get_tv_info(rdev));
1331                 }
1332                 break;
1333         case DRM_MODE_CONNECTOR_LVDS:
1334                 drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
1335                 ret = drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
1336                 if (ret)
1337                         goto failed;
1338                 if (i2c_bus->valid) {
1339                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "LVDS");
1340                         if (!radeon_connector->ddc_bus)
1341                                 goto failed;
1342                 }
1343                 drm_connector_attach_property(&radeon_connector->base,
1344                                               dev->mode_config.scaling_mode_property,
1345                                               DRM_MODE_SCALE_FULLSCREEN);
1346                 subpixel_order = SubPixelHorizontalRGB;
1347                 break;
1348         }
1349
1350         connector->display_info.subpixel_order = subpixel_order;
1351         drm_sysfs_connector_add(connector);
1352         return;
1353
1354 failed:
1355         if (radeon_connector->ddc_bus)
1356                 radeon_i2c_destroy(radeon_connector->ddc_bus);
1357         drm_connector_cleanup(connector);
1358         kfree(connector);
1359 }