Merge branch 'drm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied...
[pandora-kernel.git] / drivers / gpu / drm / radeon / radeon_connectors.c
1 /*
2  * Copyright 2007-8 Advanced Micro Devices, Inc.
3  * Copyright 2008 Red Hat Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice shall be included in
13  * all copies or substantial portions of the Software.
14  *
15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
18  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21  * OTHER DEALINGS IN THE SOFTWARE.
22  *
23  * Authors: Dave Airlie
24  *          Alex Deucher
25  */
26 #include "drmP.h"
27 #include "drm_edid.h"
28 #include "drm_crtc_helper.h"
29 #include "drm_fb_helper.h"
30 #include "radeon_drm.h"
31 #include "radeon.h"
32 #include "atom.h"
33
34 extern void
35 radeon_combios_connected_scratch_regs(struct drm_connector *connector,
36                                       struct drm_encoder *encoder,
37                                       bool connected);
38 extern void
39 radeon_atombios_connected_scratch_regs(struct drm_connector *connector,
40                                        struct drm_encoder *encoder,
41                                        bool connected);
42
43 void radeon_connector_hotplug(struct drm_connector *connector)
44 {
45         struct drm_device *dev = connector->dev;
46         struct radeon_device *rdev = dev->dev_private;
47         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
48
49         if (radeon_connector->hpd.hpd != RADEON_HPD_NONE)
50                 radeon_hpd_set_polarity(rdev, radeon_connector->hpd.hpd);
51
52         if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) ||
53             (connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
54                 if ((radeon_dp_getsinktype(radeon_connector) == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
55                     (radeon_dp_getsinktype(radeon_connector) == CONNECTOR_OBJECT_ID_eDP)) {
56                         if (radeon_dp_needs_link_train(radeon_connector)) {
57                                 if (connector->encoder)
58                                         dp_link_train(connector->encoder, connector);
59                         }
60                 }
61         }
62
63 }
64
65 static void radeon_property_change_mode(struct drm_encoder *encoder)
66 {
67         struct drm_crtc *crtc = encoder->crtc;
68
69         if (crtc && crtc->enabled) {
70                 drm_crtc_helper_set_mode(crtc, &crtc->mode,
71                                          crtc->x, crtc->y, crtc->fb);
72         }
73 }
74 static void
75 radeon_connector_update_scratch_regs(struct drm_connector *connector, enum drm_connector_status status)
76 {
77         struct drm_device *dev = connector->dev;
78         struct radeon_device *rdev = dev->dev_private;
79         struct drm_encoder *best_encoder = NULL;
80         struct drm_encoder *encoder = NULL;
81         struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
82         struct drm_mode_object *obj;
83         bool connected;
84         int i;
85
86         best_encoder = connector_funcs->best_encoder(connector);
87
88         for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
89                 if (connector->encoder_ids[i] == 0)
90                         break;
91
92                 obj = drm_mode_object_find(connector->dev,
93                                            connector->encoder_ids[i],
94                                            DRM_MODE_OBJECT_ENCODER);
95                 if (!obj)
96                         continue;
97
98                 encoder = obj_to_encoder(obj);
99
100                 if ((encoder == best_encoder) && (status == connector_status_connected))
101                         connected = true;
102                 else
103                         connected = false;
104
105                 if (rdev->is_atom_bios)
106                         radeon_atombios_connected_scratch_regs(connector, encoder, connected);
107                 else
108                         radeon_combios_connected_scratch_regs(connector, encoder, connected);
109
110         }
111 }
112
113 struct drm_encoder *radeon_find_encoder(struct drm_connector *connector, int encoder_type)
114 {
115         struct drm_mode_object *obj;
116         struct drm_encoder *encoder;
117         int i;
118
119         for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
120                 if (connector->encoder_ids[i] == 0)
121                         break;
122
123                 obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
124                 if (!obj)
125                         continue;
126
127                 encoder = obj_to_encoder(obj);
128                 if (encoder->encoder_type == encoder_type)
129                         return encoder;
130         }
131         return NULL;
132 }
133
134 struct drm_encoder *radeon_best_single_encoder(struct drm_connector *connector)
135 {
136         int enc_id = connector->encoder_ids[0];
137         struct drm_mode_object *obj;
138         struct drm_encoder *encoder;
139
140         /* pick the encoder ids */
141         if (enc_id) {
142                 obj = drm_mode_object_find(connector->dev, enc_id, DRM_MODE_OBJECT_ENCODER);
143                 if (!obj)
144                         return NULL;
145                 encoder = obj_to_encoder(obj);
146                 return encoder;
147         }
148         return NULL;
149 }
150
151 /*
152  * radeon_connector_analog_encoder_conflict_solve
153  * - search for other connectors sharing this encoder
154  *   if priority is true, then set them disconnected if this is connected
155  *   if priority is false, set us disconnected if they are connected
156  */
157 static enum drm_connector_status
158 radeon_connector_analog_encoder_conflict_solve(struct drm_connector *connector,
159                                                struct drm_encoder *encoder,
160                                                enum drm_connector_status current_status,
161                                                bool priority)
162 {
163         struct drm_device *dev = connector->dev;
164         struct drm_connector *conflict;
165         struct radeon_connector *radeon_conflict;
166         int i;
167
168         list_for_each_entry(conflict, &dev->mode_config.connector_list, head) {
169                 if (conflict == connector)
170                         continue;
171
172                 radeon_conflict = to_radeon_connector(conflict);
173                 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
174                         if (conflict->encoder_ids[i] == 0)
175                                 break;
176
177                         /* if the IDs match */
178                         if (conflict->encoder_ids[i] == encoder->base.id) {
179                                 if (conflict->status != connector_status_connected)
180                                         continue;
181
182                                 if (radeon_conflict->use_digital)
183                                         continue;
184
185                                 if (priority == true) {
186                                         DRM_INFO("1: conflicting encoders switching off %s\n", drm_get_connector_name(conflict));
187                                         DRM_INFO("in favor of %s\n", drm_get_connector_name(connector));
188                                         conflict->status = connector_status_disconnected;
189                                         radeon_connector_update_scratch_regs(conflict, connector_status_disconnected);
190                                 } else {
191                                         DRM_INFO("2: conflicting encoders switching off %s\n", drm_get_connector_name(connector));
192                                         DRM_INFO("in favor of %s\n", drm_get_connector_name(conflict));
193                                         current_status = connector_status_disconnected;
194                                 }
195                                 break;
196                         }
197                 }
198         }
199         return current_status;
200
201 }
202
203 static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encoder)
204 {
205         struct drm_device *dev = encoder->dev;
206         struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
207         struct drm_display_mode *mode = NULL;
208         struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
209
210         if (native_mode->hdisplay != 0 &&
211             native_mode->vdisplay != 0 &&
212             native_mode->clock != 0) {
213                 mode = drm_mode_duplicate(dev, native_mode);
214                 mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
215                 drm_mode_set_name(mode);
216
217                 DRM_DEBUG_KMS("Adding native panel mode %s\n", mode->name);
218         } else if (native_mode->hdisplay != 0 &&
219                    native_mode->vdisplay != 0) {
220                 /* mac laptops without an edid */
221                 /* Note that this is not necessarily the exact panel mode,
222                  * but an approximation based on the cvt formula.  For these
223                  * systems we should ideally read the mode info out of the
224                  * registers or add a mode table, but this works and is much
225                  * simpler.
226                  */
227                 mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);
228                 mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
229                 DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name);
230         }
231         return mode;
232 }
233
234 static void radeon_add_common_modes(struct drm_encoder *encoder, struct drm_connector *connector)
235 {
236         struct drm_device *dev = encoder->dev;
237         struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
238         struct drm_display_mode *mode = NULL;
239         struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
240         int i;
241         struct mode_size {
242                 int w;
243                 int h;
244         } common_modes[17] = {
245                 { 640,  480},
246                 { 720,  480},
247                 { 800,  600},
248                 { 848,  480},
249                 {1024,  768},
250                 {1152,  768},
251                 {1280,  720},
252                 {1280,  800},
253                 {1280,  854},
254                 {1280,  960},
255                 {1280, 1024},
256                 {1440,  900},
257                 {1400, 1050},
258                 {1680, 1050},
259                 {1600, 1200},
260                 {1920, 1080},
261                 {1920, 1200}
262         };
263
264         for (i = 0; i < 17; i++) {
265                 if (radeon_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {
266                         if (common_modes[i].w > 1024 ||
267                             common_modes[i].h > 768)
268                                 continue;
269                 }
270                 if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
271                         if (common_modes[i].w > native_mode->hdisplay ||
272                             common_modes[i].h > native_mode->vdisplay ||
273                             (common_modes[i].w == native_mode->hdisplay &&
274                              common_modes[i].h == native_mode->vdisplay))
275                                 continue;
276                 }
277                 if (common_modes[i].w < 320 || common_modes[i].h < 200)
278                         continue;
279
280                 mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
281                 drm_mode_probed_add(connector, mode);
282         }
283 }
284
285 int radeon_connector_set_property(struct drm_connector *connector, struct drm_property *property,
286                                   uint64_t val)
287 {
288         struct drm_device *dev = connector->dev;
289         struct radeon_device *rdev = dev->dev_private;
290         struct drm_encoder *encoder;
291         struct radeon_encoder *radeon_encoder;
292
293         if (property == rdev->mode_info.coherent_mode_property) {
294                 struct radeon_encoder_atom_dig *dig;
295                 bool new_coherent_mode;
296
297                 /* need to find digital encoder on connector */
298                 encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
299                 if (!encoder)
300                         return 0;
301
302                 radeon_encoder = to_radeon_encoder(encoder);
303
304                 if (!radeon_encoder->enc_priv)
305                         return 0;
306
307                 dig = radeon_encoder->enc_priv;
308                 new_coherent_mode = val ? true : false;
309                 if (dig->coherent_mode != new_coherent_mode) {
310                         dig->coherent_mode = new_coherent_mode;
311                         radeon_property_change_mode(&radeon_encoder->base);
312                 }
313         }
314
315         if (property == rdev->mode_info.underscan_property) {
316                 /* need to find digital encoder on connector */
317                 encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
318                 if (!encoder)
319                         return 0;
320
321                 radeon_encoder = to_radeon_encoder(encoder);
322
323                 if (radeon_encoder->underscan_type != val) {
324                         radeon_encoder->underscan_type = val;
325                         radeon_property_change_mode(&radeon_encoder->base);
326                 }
327         }
328
329         if (property == rdev->mode_info.tv_std_property) {
330                 encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TVDAC);
331                 if (!encoder) {
332                         encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_DAC);
333                 }
334
335                 if (!encoder)
336                         return 0;
337
338                 radeon_encoder = to_radeon_encoder(encoder);
339                 if (!radeon_encoder->enc_priv)
340                         return 0;
341                 if (ASIC_IS_AVIVO(rdev) || radeon_r4xx_atom) {
342                         struct radeon_encoder_atom_dac *dac_int;
343                         dac_int = radeon_encoder->enc_priv;
344                         dac_int->tv_std = val;
345                 } else {
346                         struct radeon_encoder_tv_dac *dac_int;
347                         dac_int = radeon_encoder->enc_priv;
348                         dac_int->tv_std = val;
349                 }
350                 radeon_property_change_mode(&radeon_encoder->base);
351         }
352
353         if (property == rdev->mode_info.load_detect_property) {
354                 struct radeon_connector *radeon_connector =
355                         to_radeon_connector(connector);
356
357                 if (val == 0)
358                         radeon_connector->dac_load_detect = false;
359                 else
360                         radeon_connector->dac_load_detect = true;
361         }
362
363         if (property == rdev->mode_info.tmds_pll_property) {
364                 struct radeon_encoder_int_tmds *tmds = NULL;
365                 bool ret = false;
366                 /* need to find digital encoder on connector */
367                 encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
368                 if (!encoder)
369                         return 0;
370
371                 radeon_encoder = to_radeon_encoder(encoder);
372
373                 tmds = radeon_encoder->enc_priv;
374                 if (!tmds)
375                         return 0;
376
377                 if (val == 0) {
378                         if (rdev->is_atom_bios)
379                                 ret = radeon_atombios_get_tmds_info(radeon_encoder, tmds);
380                         else
381                                 ret = radeon_legacy_get_tmds_info_from_combios(radeon_encoder, tmds);
382                 }
383                 if (val == 1 || ret == false) {
384                         radeon_legacy_get_tmds_info_from_table(radeon_encoder, tmds);
385                 }
386                 radeon_property_change_mode(&radeon_encoder->base);
387         }
388
389         return 0;
390 }
391
392 static void radeon_fixup_lvds_native_mode(struct drm_encoder *encoder,
393                                           struct drm_connector *connector)
394 {
395         struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
396         struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
397
398         /* Try to get native mode details from EDID if necessary */
399         if (!native_mode->clock) {
400                 struct drm_display_mode *t, *mode;
401
402                 list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
403                         if (mode->hdisplay == native_mode->hdisplay &&
404                             mode->vdisplay == native_mode->vdisplay) {
405                                 *native_mode = *mode;
406                                 drm_mode_set_crtcinfo(native_mode, CRTC_INTERLACE_HALVE_V);
407                                 DRM_INFO("Determined LVDS native mode details from EDID\n");
408                                 break;
409                         }
410                 }
411         }
412         if (!native_mode->clock) {
413                 DRM_INFO("No LVDS native mode details, disabling RMX\n");
414                 radeon_encoder->rmx_type = RMX_OFF;
415         }
416 }
417
418 static int radeon_lvds_get_modes(struct drm_connector *connector)
419 {
420         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
421         struct drm_encoder *encoder;
422         int ret = 0;
423         struct drm_display_mode *mode;
424
425         if (radeon_connector->ddc_bus) {
426                 ret = radeon_ddc_get_modes(radeon_connector);
427                 if (ret > 0) {
428                         encoder = radeon_best_single_encoder(connector);
429                         if (encoder) {
430                                 radeon_fixup_lvds_native_mode(encoder, connector);
431                                 /* add scaled modes */
432                                 radeon_add_common_modes(encoder, connector);
433                         }
434                         return ret;
435                 }
436         }
437
438         encoder = radeon_best_single_encoder(connector);
439         if (!encoder)
440                 return 0;
441
442         /* we have no EDID modes */
443         mode = radeon_fp_native_mode(encoder);
444         if (mode) {
445                 ret = 1;
446                 drm_mode_probed_add(connector, mode);
447                 /* add scaled modes */
448                 radeon_add_common_modes(encoder, connector);
449         }
450
451         return ret;
452 }
453
454 static int radeon_lvds_mode_valid(struct drm_connector *connector,
455                                   struct drm_display_mode *mode)
456 {
457         struct drm_encoder *encoder = radeon_best_single_encoder(connector);
458
459         if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
460                 return MODE_PANEL;
461
462         if (encoder) {
463                 struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
464                 struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
465
466                 /* AVIVO hardware supports downscaling modes larger than the panel
467                  * to the panel size, but I'm not sure this is desirable.
468                  */
469                 if ((mode->hdisplay > native_mode->hdisplay) ||
470                     (mode->vdisplay > native_mode->vdisplay))
471                         return MODE_PANEL;
472
473                 /* if scaling is disabled, block non-native modes */
474                 if (radeon_encoder->rmx_type == RMX_OFF) {
475                         if ((mode->hdisplay != native_mode->hdisplay) ||
476                             (mode->vdisplay != native_mode->vdisplay))
477                                 return MODE_PANEL;
478                 }
479         }
480
481         return MODE_OK;
482 }
483
484 static enum drm_connector_status radeon_lvds_detect(struct drm_connector *connector)
485 {
486         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
487         struct drm_encoder *encoder = radeon_best_single_encoder(connector);
488         enum drm_connector_status ret = connector_status_disconnected;
489
490         if (encoder) {
491                 struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
492                 struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
493
494                 /* check if panel is valid */
495                 if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
496                         ret = connector_status_connected;
497
498         }
499
500         /* check for edid as well */
501         if (radeon_connector->edid)
502                 ret = connector_status_connected;
503         else {
504                 if (radeon_connector->ddc_bus) {
505                         radeon_connector->edid = drm_get_edid(&radeon_connector->base,
506                                                               &radeon_connector->ddc_bus->adapter);
507                         if (radeon_connector->edid)
508                                 ret = connector_status_connected;
509                 }
510         }
511         /* check acpi lid status ??? */
512
513         radeon_connector_update_scratch_regs(connector, ret);
514         return ret;
515 }
516
517 static void radeon_connector_destroy(struct drm_connector *connector)
518 {
519         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
520
521         if (radeon_connector->edid)
522                 kfree(radeon_connector->edid);
523         kfree(radeon_connector->con_priv);
524         drm_sysfs_connector_remove(connector);
525         drm_connector_cleanup(connector);
526         kfree(connector);
527 }
528
529 static int radeon_lvds_set_property(struct drm_connector *connector,
530                                     struct drm_property *property,
531                                     uint64_t value)
532 {
533         struct drm_device *dev = connector->dev;
534         struct radeon_encoder *radeon_encoder;
535         enum radeon_rmx_type rmx_type;
536
537         DRM_DEBUG_KMS("\n");
538         if (property != dev->mode_config.scaling_mode_property)
539                 return 0;
540
541         if (connector->encoder)
542                 radeon_encoder = to_radeon_encoder(connector->encoder);
543         else {
544                 struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
545                 radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
546         }
547
548         switch (value) {
549         case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
550         case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
551         case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
552         default:
553         case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
554         }
555         if (radeon_encoder->rmx_type == rmx_type)
556                 return 0;
557
558         radeon_encoder->rmx_type = rmx_type;
559
560         radeon_property_change_mode(&radeon_encoder->base);
561         return 0;
562 }
563
564
565 struct drm_connector_helper_funcs radeon_lvds_connector_helper_funcs = {
566         .get_modes = radeon_lvds_get_modes,
567         .mode_valid = radeon_lvds_mode_valid,
568         .best_encoder = radeon_best_single_encoder,
569 };
570
571 struct drm_connector_funcs radeon_lvds_connector_funcs = {
572         .dpms = drm_helper_connector_dpms,
573         .detect = radeon_lvds_detect,
574         .fill_modes = drm_helper_probe_single_connector_modes,
575         .destroy = radeon_connector_destroy,
576         .set_property = radeon_lvds_set_property,
577 };
578
579 static int radeon_vga_get_modes(struct drm_connector *connector)
580 {
581         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
582         int ret;
583
584         ret = radeon_ddc_get_modes(radeon_connector);
585
586         return ret;
587 }
588
589 static int radeon_vga_mode_valid(struct drm_connector *connector,
590                                   struct drm_display_mode *mode)
591 {
592         /* XXX check mode bandwidth */
593         /* XXX verify against max DAC output frequency */
594         return MODE_OK;
595 }
596
597 static enum drm_connector_status radeon_vga_detect(struct drm_connector *connector)
598 {
599         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
600         struct drm_encoder *encoder;
601         struct drm_encoder_helper_funcs *encoder_funcs;
602         bool dret = false;
603         enum drm_connector_status ret = connector_status_disconnected;
604
605         encoder = radeon_best_single_encoder(connector);
606         if (!encoder)
607                 ret = connector_status_disconnected;
608
609         if (radeon_connector->ddc_bus)
610                 dret = radeon_ddc_probe(radeon_connector);
611         if (dret) {
612                 if (radeon_connector->edid) {
613                         kfree(radeon_connector->edid);
614                         radeon_connector->edid = NULL;
615                 }
616                 radeon_connector->edid = drm_get_edid(&radeon_connector->base, &radeon_connector->ddc_bus->adapter);
617
618                 if (!radeon_connector->edid) {
619                         DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
620                                         drm_get_connector_name(connector));
621                         ret = connector_status_connected;
622                 } else {
623                         radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
624
625                         /* some oems have boards with separate digital and analog connectors
626                          * with a shared ddc line (often vga + hdmi)
627                          */
628                         if (radeon_connector->use_digital && radeon_connector->shared_ddc) {
629                                 kfree(radeon_connector->edid);
630                                 radeon_connector->edid = NULL;
631                                 ret = connector_status_disconnected;
632                         } else
633                                 ret = connector_status_connected;
634                 }
635         } else {
636                 if (radeon_connector->dac_load_detect && encoder) {
637                         encoder_funcs = encoder->helper_private;
638                         ret = encoder_funcs->detect(encoder, connector);
639                 }
640         }
641
642         if (ret == connector_status_connected)
643                 ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
644         radeon_connector_update_scratch_regs(connector, ret);
645         return ret;
646 }
647
648 struct drm_connector_helper_funcs radeon_vga_connector_helper_funcs = {
649         .get_modes = radeon_vga_get_modes,
650         .mode_valid = radeon_vga_mode_valid,
651         .best_encoder = radeon_best_single_encoder,
652 };
653
654 struct drm_connector_funcs radeon_vga_connector_funcs = {
655         .dpms = drm_helper_connector_dpms,
656         .detect = radeon_vga_detect,
657         .fill_modes = drm_helper_probe_single_connector_modes,
658         .destroy = radeon_connector_destroy,
659         .set_property = radeon_connector_set_property,
660 };
661
662 static int radeon_tv_get_modes(struct drm_connector *connector)
663 {
664         struct drm_device *dev = connector->dev;
665         struct radeon_device *rdev = dev->dev_private;
666         struct drm_display_mode *tv_mode;
667         struct drm_encoder *encoder;
668
669         encoder = radeon_best_single_encoder(connector);
670         if (!encoder)
671                 return 0;
672
673         /* avivo chips can scale any mode */
674         if (rdev->family >= CHIP_RS600)
675                 /* add scaled modes */
676                 radeon_add_common_modes(encoder, connector);
677         else {
678                 /* only 800x600 is supported right now on pre-avivo chips */
679                 tv_mode = drm_cvt_mode(dev, 800, 600, 60, false, false, false);
680                 tv_mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
681                 drm_mode_probed_add(connector, tv_mode);
682         }
683         return 1;
684 }
685
686 static int radeon_tv_mode_valid(struct drm_connector *connector,
687                                 struct drm_display_mode *mode)
688 {
689         if ((mode->hdisplay > 1024) || (mode->vdisplay > 768))
690                 return MODE_CLOCK_RANGE;
691         return MODE_OK;
692 }
693
694 static enum drm_connector_status radeon_tv_detect(struct drm_connector *connector)
695 {
696         struct drm_encoder *encoder;
697         struct drm_encoder_helper_funcs *encoder_funcs;
698         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
699         enum drm_connector_status ret = connector_status_disconnected;
700
701         if (!radeon_connector->dac_load_detect)
702                 return ret;
703
704         encoder = radeon_best_single_encoder(connector);
705         if (!encoder)
706                 ret = connector_status_disconnected;
707         else {
708                 encoder_funcs = encoder->helper_private;
709                 ret = encoder_funcs->detect(encoder, connector);
710         }
711         if (ret == connector_status_connected)
712                 ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, false);
713         radeon_connector_update_scratch_regs(connector, ret);
714         return ret;
715 }
716
717 struct drm_connector_helper_funcs radeon_tv_connector_helper_funcs = {
718         .get_modes = radeon_tv_get_modes,
719         .mode_valid = radeon_tv_mode_valid,
720         .best_encoder = radeon_best_single_encoder,
721 };
722
723 struct drm_connector_funcs radeon_tv_connector_funcs = {
724         .dpms = drm_helper_connector_dpms,
725         .detect = radeon_tv_detect,
726         .fill_modes = drm_helper_probe_single_connector_modes,
727         .destroy = radeon_connector_destroy,
728         .set_property = radeon_connector_set_property,
729 };
730
731 static int radeon_dvi_get_modes(struct drm_connector *connector)
732 {
733         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
734         int ret;
735
736         ret = radeon_ddc_get_modes(radeon_connector);
737         return ret;
738 }
739
740 /*
741  * DVI is complicated
742  * Do a DDC probe, if DDC probe passes, get the full EDID so
743  * we can do analog/digital monitor detection at this point.
744  * If the monitor is an analog monitor or we got no DDC,
745  * we need to find the DAC encoder object for this connector.
746  * If we got no DDC, we do load detection on the DAC encoder object.
747  * If we got analog DDC or load detection passes on the DAC encoder
748  * we have to check if this analog encoder is shared with anyone else (TV)
749  * if its shared we have to set the other connector to disconnected.
750  */
751 static enum drm_connector_status radeon_dvi_detect(struct drm_connector *connector)
752 {
753         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
754         struct drm_encoder *encoder = NULL;
755         struct drm_encoder_helper_funcs *encoder_funcs;
756         struct drm_mode_object *obj;
757         int i;
758         enum drm_connector_status ret = connector_status_disconnected;
759         bool dret = false;
760
761         if (radeon_connector->ddc_bus)
762                 dret = radeon_ddc_probe(radeon_connector);
763         if (dret) {
764                 if (radeon_connector->edid) {
765                         kfree(radeon_connector->edid);
766                         radeon_connector->edid = NULL;
767                 }
768                 radeon_connector->edid = drm_get_edid(&radeon_connector->base, &radeon_connector->ddc_bus->adapter);
769
770                 if (!radeon_connector->edid) {
771                         DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
772                                         drm_get_connector_name(connector));
773                 } else {
774                         radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
775
776                         /* some oems have boards with separate digital and analog connectors
777                          * with a shared ddc line (often vga + hdmi)
778                          */
779                         if ((!radeon_connector->use_digital) && radeon_connector->shared_ddc) {
780                                 kfree(radeon_connector->edid);
781                                 radeon_connector->edid = NULL;
782                                 ret = connector_status_disconnected;
783                         } else
784                                 ret = connector_status_connected;
785
786                         /* This gets complicated.  We have boards with VGA + HDMI with a
787                          * shared DDC line and we have boards with DVI-D + HDMI with a shared
788                          * DDC line.  The latter is more complex because with DVI<->HDMI adapters
789                          * you don't really know what's connected to which port as both are digital.
790                          */
791                         if (radeon_connector->shared_ddc && (ret == connector_status_connected)) {
792                                 struct drm_device *dev = connector->dev;
793                                 struct radeon_device *rdev = dev->dev_private;
794                                 struct drm_connector *list_connector;
795                                 struct radeon_connector *list_radeon_connector;
796                                 list_for_each_entry(list_connector, &dev->mode_config.connector_list, head) {
797                                         if (connector == list_connector)
798                                                 continue;
799                                         list_radeon_connector = to_radeon_connector(list_connector);
800                                         if (list_radeon_connector->shared_ddc &&
801                                             (list_radeon_connector->ddc_bus->rec.i2c_id ==
802                                              radeon_connector->ddc_bus->rec.i2c_id)) {
803                                                 /* cases where both connectors are digital */
804                                                 if (list_connector->connector_type != DRM_MODE_CONNECTOR_VGA) {
805                                                         /* hpd is our only option in this case */
806                                                         if (!radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
807                                                                 kfree(radeon_connector->edid);
808                                                                 radeon_connector->edid = NULL;
809                                                                 ret = connector_status_disconnected;
810                                                         }
811                                                 }
812                                         }
813                                 }
814                         }
815                 }
816         }
817
818         if ((ret == connector_status_connected) && (radeon_connector->use_digital == true))
819                 goto out;
820
821         /* find analog encoder */
822         if (radeon_connector->dac_load_detect) {
823                 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
824                         if (connector->encoder_ids[i] == 0)
825                                 break;
826
827                         obj = drm_mode_object_find(connector->dev,
828                                                    connector->encoder_ids[i],
829                                                    DRM_MODE_OBJECT_ENCODER);
830                         if (!obj)
831                                 continue;
832
833                         encoder = obj_to_encoder(obj);
834
835                         encoder_funcs = encoder->helper_private;
836                         if (encoder_funcs->detect) {
837                                 if (ret != connector_status_connected) {
838                                         ret = encoder_funcs->detect(encoder, connector);
839                                         if (ret == connector_status_connected) {
840                                                 radeon_connector->use_digital = false;
841                                         }
842                                 }
843                                 break;
844                         }
845                 }
846         }
847
848         if ((ret == connector_status_connected) && (radeon_connector->use_digital == false) &&
849             encoder) {
850                 ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
851         }
852
853 out:
854         /* updated in get modes as well since we need to know if it's analog or digital */
855         radeon_connector_update_scratch_regs(connector, ret);
856         return ret;
857 }
858
859 /* okay need to be smart in here about which encoder to pick */
860 struct drm_encoder *radeon_dvi_encoder(struct drm_connector *connector)
861 {
862         int enc_id = connector->encoder_ids[0];
863         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
864         struct drm_mode_object *obj;
865         struct drm_encoder *encoder;
866         int i;
867         for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
868                 if (connector->encoder_ids[i] == 0)
869                         break;
870
871                 obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
872                 if (!obj)
873                         continue;
874
875                 encoder = obj_to_encoder(obj);
876
877                 if (radeon_connector->use_digital == true) {
878                         if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
879                                 return encoder;
880                 } else {
881                         if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
882                             encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
883                                 return encoder;
884                 }
885         }
886
887         /* see if we have a default encoder  TODO */
888
889         /* then check use digitial */
890         /* pick the first one */
891         if (enc_id) {
892                 obj = drm_mode_object_find(connector->dev, enc_id, DRM_MODE_OBJECT_ENCODER);
893                 if (!obj)
894                         return NULL;
895                 encoder = obj_to_encoder(obj);
896                 return encoder;
897         }
898         return NULL;
899 }
900
901 static void radeon_dvi_force(struct drm_connector *connector)
902 {
903         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
904         if (connector->force == DRM_FORCE_ON)
905                 radeon_connector->use_digital = false;
906         if (connector->force == DRM_FORCE_ON_DIGITAL)
907                 radeon_connector->use_digital = true;
908 }
909
910 static int radeon_dvi_mode_valid(struct drm_connector *connector,
911                                   struct drm_display_mode *mode)
912 {
913         struct drm_device *dev = connector->dev;
914         struct radeon_device *rdev = dev->dev_private;
915         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
916
917         /* XXX check mode bandwidth */
918
919         /* clocks over 135 MHz have heat issues with DVI on RV100 */
920         if (radeon_connector->use_digital &&
921             (rdev->family == CHIP_RV100) &&
922             (mode->clock > 135000))
923                 return MODE_CLOCK_HIGH;
924
925         if (radeon_connector->use_digital && (mode->clock > 165000)) {
926                 if ((radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I) ||
927                     (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D) ||
928                     (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_HDMI_TYPE_B))
929                         return MODE_OK;
930                 else
931                         return MODE_CLOCK_HIGH;
932         }
933         return MODE_OK;
934 }
935
936 struct drm_connector_helper_funcs radeon_dvi_connector_helper_funcs = {
937         .get_modes = radeon_dvi_get_modes,
938         .mode_valid = radeon_dvi_mode_valid,
939         .best_encoder = radeon_dvi_encoder,
940 };
941
942 struct drm_connector_funcs radeon_dvi_connector_funcs = {
943         .dpms = drm_helper_connector_dpms,
944         .detect = radeon_dvi_detect,
945         .fill_modes = drm_helper_probe_single_connector_modes,
946         .set_property = radeon_connector_set_property,
947         .destroy = radeon_connector_destroy,
948         .force = radeon_dvi_force,
949 };
950
951 static void radeon_dp_connector_destroy(struct drm_connector *connector)
952 {
953         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
954         struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
955
956         if (radeon_connector->edid)
957                 kfree(radeon_connector->edid);
958         if (radeon_dig_connector->dp_i2c_bus)
959                 radeon_i2c_destroy(radeon_dig_connector->dp_i2c_bus);
960         kfree(radeon_connector->con_priv);
961         drm_sysfs_connector_remove(connector);
962         drm_connector_cleanup(connector);
963         kfree(connector);
964 }
965
966 static int radeon_dp_get_modes(struct drm_connector *connector)
967 {
968         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
969         int ret;
970
971         ret = radeon_ddc_get_modes(radeon_connector);
972         return ret;
973 }
974
975 static enum drm_connector_status radeon_dp_detect(struct drm_connector *connector)
976 {
977         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
978         enum drm_connector_status ret = connector_status_disconnected;
979         struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
980
981         if (radeon_connector->edid) {
982                 kfree(radeon_connector->edid);
983                 radeon_connector->edid = NULL;
984         }
985
986         if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
987                 /* eDP is always DP */
988                 radeon_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
989                 if (radeon_dp_getdpcd(radeon_connector))
990                         ret = connector_status_connected;
991         } else {
992                 radeon_dig_connector->dp_sink_type = radeon_dp_getsinktype(radeon_connector);
993                 if (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
994                         if (radeon_dp_getdpcd(radeon_connector))
995                                 ret = connector_status_connected;
996                 } else {
997                         if (radeon_ddc_probe(radeon_connector))
998                                 ret = connector_status_connected;
999                 }
1000         }
1001
1002         radeon_connector_update_scratch_regs(connector, ret);
1003         return ret;
1004 }
1005
1006 static int radeon_dp_mode_valid(struct drm_connector *connector,
1007                                   struct drm_display_mode *mode)
1008 {
1009         struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1010         struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1011
1012         /* XXX check mode bandwidth */
1013
1014         if ((radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
1015             (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP))
1016                 return radeon_dp_mode_valid_helper(radeon_connector, mode);
1017         else
1018                 return MODE_OK;
1019 }
1020
1021 struct drm_connector_helper_funcs radeon_dp_connector_helper_funcs = {
1022         .get_modes = radeon_dp_get_modes,
1023         .mode_valid = radeon_dp_mode_valid,
1024         .best_encoder = radeon_dvi_encoder,
1025 };
1026
1027 struct drm_connector_funcs radeon_dp_connector_funcs = {
1028         .dpms = drm_helper_connector_dpms,
1029         .detect = radeon_dp_detect,
1030         .fill_modes = drm_helper_probe_single_connector_modes,
1031         .set_property = radeon_connector_set_property,
1032         .destroy = radeon_dp_connector_destroy,
1033         .force = radeon_dvi_force,
1034 };
1035
1036 void
1037 radeon_add_atom_connector(struct drm_device *dev,
1038                           uint32_t connector_id,
1039                           uint32_t supported_device,
1040                           int connector_type,
1041                           struct radeon_i2c_bus_rec *i2c_bus,
1042                           uint32_t igp_lane_info,
1043                           uint16_t connector_object_id,
1044                           struct radeon_hpd *hpd,
1045                           struct radeon_router *router)
1046 {
1047         struct radeon_device *rdev = dev->dev_private;
1048         struct drm_connector *connector;
1049         struct radeon_connector *radeon_connector;
1050         struct radeon_connector_atom_dig *radeon_dig_connector;
1051         uint32_t subpixel_order = SubPixelNone;
1052         bool shared_ddc = false;
1053
1054         /* fixme - tv/cv/din */
1055         if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1056                 return;
1057
1058         /* see if we already added it */
1059         list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1060                 radeon_connector = to_radeon_connector(connector);
1061                 if (radeon_connector->connector_id == connector_id) {
1062                         radeon_connector->devices |= supported_device;
1063                         return;
1064                 }
1065                 if (radeon_connector->ddc_bus && i2c_bus->valid) {
1066                         if (radeon_connector->ddc_bus->rec.i2c_id == i2c_bus->i2c_id) {
1067                                 radeon_connector->shared_ddc = true;
1068                                 shared_ddc = true;
1069                         }
1070                         if (radeon_connector->router_bus && router->valid &&
1071                             (radeon_connector->router.router_id == router->router_id)) {
1072                                 radeon_connector->shared_ddc = false;
1073                                 shared_ddc = false;
1074                         }
1075                 }
1076         }
1077
1078         radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
1079         if (!radeon_connector)
1080                 return;
1081
1082         connector = &radeon_connector->base;
1083
1084         radeon_connector->connector_id = connector_id;
1085         radeon_connector->devices = supported_device;
1086         radeon_connector->shared_ddc = shared_ddc;
1087         radeon_connector->connector_object_id = connector_object_id;
1088         radeon_connector->hpd = *hpd;
1089         radeon_connector->router = *router;
1090         if (router->valid) {
1091                 radeon_connector->router_bus = radeon_i2c_lookup(rdev, &router->i2c_info);
1092                 if (!radeon_connector->router_bus)
1093                         goto failed;
1094         }
1095         switch (connector_type) {
1096         case DRM_MODE_CONNECTOR_VGA:
1097                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1098                 drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1099                 if (i2c_bus->valid) {
1100                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1101                         if (!radeon_connector->ddc_bus)
1102                                 goto failed;
1103                 }
1104                 radeon_connector->dac_load_detect = true;
1105                 drm_connector_attach_property(&radeon_connector->base,
1106                                               rdev->mode_info.load_detect_property,
1107                                               1);
1108                 /* no HPD on analog connectors */
1109                 radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1110                 connector->polled = DRM_CONNECTOR_POLL_CONNECT;
1111                 break;
1112         case DRM_MODE_CONNECTOR_DVIA:
1113                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1114                 drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1115                 if (i2c_bus->valid) {
1116                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1117                         if (!radeon_connector->ddc_bus)
1118                                 goto failed;
1119                 }
1120                 radeon_connector->dac_load_detect = true;
1121                 drm_connector_attach_property(&radeon_connector->base,
1122                                               rdev->mode_info.load_detect_property,
1123                                               1);
1124                 /* no HPD on analog connectors */
1125                 radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1126                 break;
1127         case DRM_MODE_CONNECTOR_DVII:
1128         case DRM_MODE_CONNECTOR_DVID:
1129                 radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1130                 if (!radeon_dig_connector)
1131                         goto failed;
1132                 radeon_dig_connector->igp_lane_info = igp_lane_info;
1133                 radeon_connector->con_priv = radeon_dig_connector;
1134                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
1135                 drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
1136                 if (i2c_bus->valid) {
1137                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1138                         if (!radeon_connector->ddc_bus)
1139                                 goto failed;
1140                 }
1141                 subpixel_order = SubPixelHorizontalRGB;
1142                 drm_connector_attach_property(&radeon_connector->base,
1143                                               rdev->mode_info.coherent_mode_property,
1144                                               1);
1145                 if (ASIC_IS_AVIVO(rdev))
1146                         drm_connector_attach_property(&radeon_connector->base,
1147                                                       rdev->mode_info.underscan_property,
1148                                                       UNDERSCAN_AUTO);
1149                 if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1150                         radeon_connector->dac_load_detect = true;
1151                         drm_connector_attach_property(&radeon_connector->base,
1152                                                       rdev->mode_info.load_detect_property,
1153                                                       1);
1154                 }
1155                 break;
1156         case DRM_MODE_CONNECTOR_HDMIA:
1157         case DRM_MODE_CONNECTOR_HDMIB:
1158                 radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1159                 if (!radeon_dig_connector)
1160                         goto failed;
1161                 radeon_dig_connector->igp_lane_info = igp_lane_info;
1162                 radeon_connector->con_priv = radeon_dig_connector;
1163                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
1164                 drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
1165                 if (i2c_bus->valid) {
1166                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1167                         if (!radeon_connector->ddc_bus)
1168                                 goto failed;
1169                 }
1170                 drm_connector_attach_property(&radeon_connector->base,
1171                                               rdev->mode_info.coherent_mode_property,
1172                                               1);
1173                 if (ASIC_IS_AVIVO(rdev))
1174                         drm_connector_attach_property(&radeon_connector->base,
1175                                                       rdev->mode_info.underscan_property,
1176                                                       UNDERSCAN_AUTO);
1177                 subpixel_order = SubPixelHorizontalRGB;
1178                 break;
1179         case DRM_MODE_CONNECTOR_DisplayPort:
1180         case DRM_MODE_CONNECTOR_eDP:
1181                 radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1182                 if (!radeon_dig_connector)
1183                         goto failed;
1184                 radeon_dig_connector->igp_lane_info = igp_lane_info;
1185                 radeon_connector->con_priv = radeon_dig_connector;
1186                 drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type);
1187                 drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
1188                 if (i2c_bus->valid) {
1189                         /* add DP i2c bus */
1190                         if (connector_type == DRM_MODE_CONNECTOR_eDP)
1191                                 radeon_dig_connector->dp_i2c_bus = radeon_i2c_create_dp(dev, i2c_bus, "eDP-auxch");
1192                         else
1193                                 radeon_dig_connector->dp_i2c_bus = radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch");
1194                         if (!radeon_dig_connector->dp_i2c_bus)
1195                                 goto failed;
1196                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1197                         if (!radeon_connector->ddc_bus)
1198                                 goto failed;
1199                 }
1200                 subpixel_order = SubPixelHorizontalRGB;
1201                 drm_connector_attach_property(&radeon_connector->base,
1202                                               rdev->mode_info.coherent_mode_property,
1203                                               1);
1204                 if (ASIC_IS_AVIVO(rdev))
1205                         drm_connector_attach_property(&radeon_connector->base,
1206                                                       rdev->mode_info.underscan_property,
1207                                                       UNDERSCAN_AUTO);
1208                 break;
1209         case DRM_MODE_CONNECTOR_SVIDEO:
1210         case DRM_MODE_CONNECTOR_Composite:
1211         case DRM_MODE_CONNECTOR_9PinDIN:
1212                 if (radeon_tv == 1) {
1213                         drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
1214                         drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
1215                         radeon_connector->dac_load_detect = true;
1216                         drm_connector_attach_property(&radeon_connector->base,
1217                                                       rdev->mode_info.load_detect_property,
1218                                                       1);
1219                         drm_connector_attach_property(&radeon_connector->base,
1220                                                       rdev->mode_info.tv_std_property,
1221                                                       radeon_atombios_get_tv_info(rdev));
1222                         /* no HPD on analog connectors */
1223                         radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1224                 }
1225                 break;
1226         case DRM_MODE_CONNECTOR_LVDS:
1227                 radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1228                 if (!radeon_dig_connector)
1229                         goto failed;
1230                 radeon_dig_connector->igp_lane_info = igp_lane_info;
1231                 radeon_connector->con_priv = radeon_dig_connector;
1232                 drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
1233                 drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
1234                 if (i2c_bus->valid) {
1235                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1236                         if (!radeon_connector->ddc_bus)
1237                                 goto failed;
1238                 }
1239                 drm_connector_attach_property(&radeon_connector->base,
1240                                               dev->mode_config.scaling_mode_property,
1241                                               DRM_MODE_SCALE_FULLSCREEN);
1242                 subpixel_order = SubPixelHorizontalRGB;
1243                 break;
1244         }
1245
1246         if (radeon_connector->hpd.hpd == RADEON_HPD_NONE) {
1247                 if (i2c_bus->valid)
1248                         connector->polled = DRM_CONNECTOR_POLL_CONNECT;
1249         } else
1250                 connector->polled = DRM_CONNECTOR_POLL_HPD;
1251
1252         connector->display_info.subpixel_order = subpixel_order;
1253         drm_sysfs_connector_add(connector);
1254         return;
1255
1256 failed:
1257         drm_connector_cleanup(connector);
1258         kfree(connector);
1259 }
1260
1261 void
1262 radeon_add_legacy_connector(struct drm_device *dev,
1263                             uint32_t connector_id,
1264                             uint32_t supported_device,
1265                             int connector_type,
1266                             struct radeon_i2c_bus_rec *i2c_bus,
1267                             uint16_t connector_object_id,
1268                             struct radeon_hpd *hpd)
1269 {
1270         struct radeon_device *rdev = dev->dev_private;
1271         struct drm_connector *connector;
1272         struct radeon_connector *radeon_connector;
1273         uint32_t subpixel_order = SubPixelNone;
1274
1275         /* fixme - tv/cv/din */
1276         if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1277                 return;
1278
1279         /* see if we already added it */
1280         list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1281                 radeon_connector = to_radeon_connector(connector);
1282                 if (radeon_connector->connector_id == connector_id) {
1283                         radeon_connector->devices |= supported_device;
1284                         return;
1285                 }
1286         }
1287
1288         radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
1289         if (!radeon_connector)
1290                 return;
1291
1292         connector = &radeon_connector->base;
1293
1294         radeon_connector->connector_id = connector_id;
1295         radeon_connector->devices = supported_device;
1296         radeon_connector->connector_object_id = connector_object_id;
1297         radeon_connector->hpd = *hpd;
1298         switch (connector_type) {
1299         case DRM_MODE_CONNECTOR_VGA:
1300                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1301                 drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1302                 if (i2c_bus->valid) {
1303                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1304                         if (!radeon_connector->ddc_bus)
1305                                 goto failed;
1306                 }
1307                 radeon_connector->dac_load_detect = true;
1308                 drm_connector_attach_property(&radeon_connector->base,
1309                                               rdev->mode_info.load_detect_property,
1310                                               1);
1311                 /* no HPD on analog connectors */
1312                 radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1313                 connector->polled = DRM_CONNECTOR_POLL_CONNECT;
1314                 break;
1315         case DRM_MODE_CONNECTOR_DVIA:
1316                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1317                 drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1318                 if (i2c_bus->valid) {
1319                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1320                         if (!radeon_connector->ddc_bus)
1321                                 goto failed;
1322                 }
1323                 radeon_connector->dac_load_detect = true;
1324                 drm_connector_attach_property(&radeon_connector->base,
1325                                               rdev->mode_info.load_detect_property,
1326                                               1);
1327                 /* no HPD on analog connectors */
1328                 radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1329                 break;
1330         case DRM_MODE_CONNECTOR_DVII:
1331         case DRM_MODE_CONNECTOR_DVID:
1332                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
1333                 drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
1334                 if (i2c_bus->valid) {
1335                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1336                         if (!radeon_connector->ddc_bus)
1337                                 goto failed;
1338                 }
1339                 if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1340                         radeon_connector->dac_load_detect = true;
1341                         drm_connector_attach_property(&radeon_connector->base,
1342                                                       rdev->mode_info.load_detect_property,
1343                                                       1);
1344                 }
1345                 subpixel_order = SubPixelHorizontalRGB;
1346                 break;
1347         case DRM_MODE_CONNECTOR_SVIDEO:
1348         case DRM_MODE_CONNECTOR_Composite:
1349         case DRM_MODE_CONNECTOR_9PinDIN:
1350                 if (radeon_tv == 1) {
1351                         drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
1352                         drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
1353                         radeon_connector->dac_load_detect = true;
1354                         /* RS400,RC410,RS480 chipset seems to report a lot
1355                          * of false positive on load detect, we haven't yet
1356                          * found a way to make load detect reliable on those
1357                          * chipset, thus just disable it for TV.
1358                          */
1359                         if (rdev->family == CHIP_RS400 || rdev->family == CHIP_RS480)
1360                                 radeon_connector->dac_load_detect = false;
1361                         drm_connector_attach_property(&radeon_connector->base,
1362                                                       rdev->mode_info.load_detect_property,
1363                                                       radeon_connector->dac_load_detect);
1364                         drm_connector_attach_property(&radeon_connector->base,
1365                                                       rdev->mode_info.tv_std_property,
1366                                                       radeon_combios_get_tv_info(rdev));
1367                         /* no HPD on analog connectors */
1368                         radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1369                 }
1370                 break;
1371         case DRM_MODE_CONNECTOR_LVDS:
1372                 drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
1373                 drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
1374                 if (i2c_bus->valid) {
1375                         radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1376                         if (!radeon_connector->ddc_bus)
1377                                 goto failed;
1378                 }
1379                 drm_connector_attach_property(&radeon_connector->base,
1380                                               dev->mode_config.scaling_mode_property,
1381                                               DRM_MODE_SCALE_FULLSCREEN);
1382                 subpixel_order = SubPixelHorizontalRGB;
1383                 break;
1384         }
1385
1386         if (radeon_connector->hpd.hpd == RADEON_HPD_NONE) {
1387                 if (i2c_bus->valid)
1388                         connector->polled = DRM_CONNECTOR_POLL_CONNECT;
1389         } else
1390                 connector->polled = DRM_CONNECTOR_POLL_HPD;
1391         connector->display_info.subpixel_order = subpixel_order;
1392         drm_sysfs_connector_add(connector);
1393         return;
1394
1395 failed:
1396         drm_connector_cleanup(connector);
1397         kfree(connector);
1398 }