From e8b8c977734193adedf2b0f607d6252c78e86394 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Fri, 19 Oct 2007 21:25:45 -0700 Subject: [PATCH] Revert "kconfig: tristate choices with mixed tristate and boolean values" This reverts commit a5bf3d891a6a0fb5aa122792d965e3774108b923. David Brownell notes that this causes a regression visible in the drivers/usb/gadget Kconfig file: "That Kconfig hasn't changed (other than adding new drivers), and it's worked that way for several years now ... so the issue seems to be changes in menuconfig/kconfig/etc semantics. The issue is that when USB_GADGET=m, it's no longer possible to configure peripheral controller drivers as modules ... the controller drivers can now only be configured for static linkage. It should be making a choice of one of the controller drivers which could work on the target system, and allow that driver to be linked either as a module (ok iff USB_GADGET=m) or statically." Reverting this commit resolves the problem, and also fixes a second problem that David noticed: various dependent options couldn't be enabled. Tested-and-reported-by: David Brownell Cc: Randy Dunlap Cc: Jan Beulich , Cc: Andrew Morton , Cc: Sam Ravnborg , Cc: Roman Zippel Signed-off-by: Linus Torvalds --- Reading git-format-patch failed