From e163cc97f9ac169f00e86df57bee365e82e9c365 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Lothar=20Wa=C3=9Fmann?= Date: Wed, 7 Dec 2011 21:59:31 +0000 Subject: [PATCH] net/fec: fix the .remove code MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The .remove code is broken in several ways. - mdiobus_unregister() is called twice for the same object in case of dual FEC - phy_disconnect() is being called when the PHY is already disconnected - the requested IRQ(s) are not freed - fec_stop() is being called with the inteface already stopped All of those lead to kernel crashes if the remove function is actually used. Signed-off-by: Lothar Waßmann Tested-by: Shawn Guo Acked-by: Shawn Guo Signed-off-by: David S. Miller --- Reading git-format-patch failed