From c945cbcf453cb72dc2287fc4f7b63314f173b313 Mon Sep 17 00:00:00 2001 From: Manfred Schlaegl Date: Tue, 13 Aug 2013 04:17:05 -0700 Subject: [PATCH] leds: trigger: ledtrig-backlight: Fix invalid memory access in fb_event notification callback fb_notifier_callback is called on any event fired by fb_notifier_call_chain. Events may, or may not contain some data (fb_event.data). In case of FB_EVENT_BLANK fb_event.data contains a pointer to an integer holdingthe blank state. The Problem is, that in ledtrig-backlight.c - fb_notifier_callback the pointer to blank state is dereferenced BEFORE the event-type is checked. Obviously this leads to problems with other events than FB_EVENT_BLANK, where fb_event.data is undefined or NULL. It seems, that this problem existed ever since the driver was added. Like in drivers/video/backlight/backlight.c line 43 I would suggest to return immediately on events other than FB_EVENT_BLANK. Signed-off-by: Manfred Schlaegl Signed-off-by: Bryan Wu --- Reading git-format-patch failed