From 914ed44b17dc30ce0d783e8e23fce58a1a92412c Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Fri, 30 Mar 2012 11:24:11 -0500 Subject: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue This ASSERT is testing an if_flags flag value against a di_aformat enum value. di_aformat is never assigned XFS_IFINLINE. This happens to work for now, because XFS_IFINLINE has the same value as XFS_DINODE_FMT_LOCAL, and that's tested just before we call this function. However, I think the intention is to assert that we have read in the data, i.e. XFS_IFINLINE on if_flags, before we use if_data. This is done in other places through the code as well. Signed-off-by: Eric Sandeen Reviewed-by: Christoph Hellwig Signed-off-by: Ben Myers --- Reading git-format-patch failed