From 7ade67b5984d0a0434462fda733ab5138c63aae1 Mon Sep 17 00:00:00 2001 From: Marc Zyngier Date: Mon, 4 Nov 2013 16:55:22 +0000 Subject: [PATCH] arm64: move enabling of GIC before CPUs are set online Commit 53ae3acd (arm64: Only enable local interrupts after the CPU is marked online) moved the enabling of the GIC after the CPUs are marked online. This has some interesting effect: [...] [] gic_raise_softirq+0xf8/0x160 [] smp_send_reschedule+0x38/0x40 [] resched_task+0x84/0xc0 [] check_preempt_curr+0x58/0x98 [] ttwu_do_wakeup+0x1c/0xf4 [] ttwu_do_activate.constprop.84+0x64/0x70 [] try_to_wake_up+0x1d4/0x2b4 [] default_wake_function+0x10/0x18 [] __wake_up_common+0x60/0xa0 [] complete+0x48/0x64 [] secondary_start_kernel+0xe8/0x110 [...] Here, we end-up calling gic_raise_softirq without having initialized the interrupt controller for this CPU. While this goes unnoticed with GICv2 (the distributor is always accessible), it explodes with GICv3. The fix is to move the call to notify_cpu_starting before we set the secondary CPU online. Signed-off-by: Marc Zyngier Signed-off-by: Catalin Marinas --- Reading git-format-patch failed