From 48a30569732be782119960a47ca05417e7e07dab Mon Sep 17 00:00:00 2001 From: Michael Chan Date: Wed, 18 Sep 2013 01:50:39 -0700 Subject: [PATCH] cnic: Fix crash in cnic_bnx2x_service_kcq() commit 104a43edb264321a4d41850e98153b4fa8a9ef42 cnic: Use CHIP_NUM macros from bnx2x.h changed the code to use the bnx2x macro NO_FCOE() to determine if FCoE is supported or not. There is another place in cnic that is still using the old method to determine if FCoE is supported or not. The 2 methods may not yield the same result after the network interface is brought down and up. This will cause the crash as cnic_bnx2x_service_kcq() will access the uninitialized cp->kcq2. The fix is to consistently use the same macro CNIC_SUPPORTS_FCOE() which uses the bnx2x NO_FCOE() macro. As a follow-up, we can clean up the code to remove the old method as it is no longer needed. Signed-off-by: Michael Chan Signed-off-by: David S. Miller --- Reading git-format-patch failed