From 201fce21a67d74e9703127af0d6c6084003796bb Mon Sep 17 00:00:00 2001 From: Artem Bityutskiy Date: Fri, 10 Jul 2009 17:02:17 +0300 Subject: [PATCH] mtd: blkdevs: do not for get to get MTD devices Nowadays MTD devices have to be "get" before they can be used. This has to be done with 'put_mtd_device()'. The 'blktrans_open()' function did not do this and instead used 'try_module_get()'. Fixe this. Since 'put_mtd_device()' already gets the module, extra 'try_module_get()' is not needed. This fixes oops when one tries to use mtdbloc on tope of gluebi. Reported-by: Holger Brunck Signed-off-by: Artem Bityutskiy --- drivers/mtd/mtd_blkdevs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 9ff007c4962c..8a1941756de7 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -130,7 +130,7 @@ static int blktrans_open(struct inode *i, struct file *f) dev = i->i_bdev->bd_disk->private_data; tr = dev->tr; - if (!try_module_get(dev->mtd->owner)) + if (!get_mtd_device(NULL, dev->mtd->index)) goto out; if (!try_module_get(tr->owner)) @@ -144,7 +144,7 @@ static int blktrans_open(struct inode *i, struct file *f) ret = 0; if (tr->open && (ret = tr->open(dev))) { dev->mtd->usecount--; - module_put(dev->mtd->owner); + put_mtd_device(dev->mtd); out_tr: module_put(tr->owner); } @@ -166,7 +166,7 @@ static int blktrans_release(struct inode *i, struct file *f) if (!ret) { dev->mtd->usecount--; - module_put(dev->mtd->owner); + put_mtd_device(dev->mtd); module_put(tr->owner); } -- 2.47.3