From 0ef63e48f0247a9f9b9ffeef0f2641ac880728ab Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Mon, 18 Jun 2012 22:30:51 -0700 Subject: [PATCH] hwmon: (ntc_thermistor) Ensure that data->name string is terminated Fix Coverity warning: Calling strncpy with a maximum size argument of 20 bytes on destination array "data->name" of size 20 bytes might leave the destination string unterminated. Fix by replacing strncpy() with strlcpy() and by using sizeof() to determine the maximum string length. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare --- drivers/hwmon/ntc_thermistor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c index 6da9696e1827..74a6c58d0218 100644 --- a/drivers/hwmon/ntc_thermistor.c +++ b/drivers/hwmon/ntc_thermistor.c @@ -351,7 +351,7 @@ static int __devinit ntc_thermistor_probe(struct platform_device *pdev) data->dev = &pdev->dev; data->pdata = pdata; - strncpy(data->name, pdev->id_entry->name, PLATFORM_NAME_SIZE); + strlcpy(data->name, pdev->id_entry->name, sizeof(data->name)); switch (pdev->id_entry->driver_data) { case TYPE_NCPXXWB473: -- 2.39.2