From 0ab7710a06401f8cac1d49bac5e66d25f3e6e4e1 Mon Sep 17 00:00:00 2001 From: Tom Rini Date: Wed, 1 Oct 2025 14:30:57 -0600 Subject: [PATCH] clk: sophgo: Fix a warning about void returns value The cv1800b_clk_setfield function returns void, but was doing "return writel(...);" and while seemingly having a void function return a void function is not a warning, when readl is a macro this problem is shown. Correct the code to instead simply call writel. Signed-off-by: Tom Rini Reviewed-by: Yao Zi --- drivers/clk/sophgo/clk-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sophgo/clk-common.h b/drivers/clk/sophgo/clk-common.h index a9e83d0d689..a18673f397c 100644 --- a/drivers/clk/sophgo/clk-common.h +++ b/drivers/clk/sophgo/clk-common.h @@ -70,7 +70,7 @@ cv1800b_clk_setfield(void *base, struct cv1800b_clk_regfield *field, u32 val) u32 new_val = (readl(base + field->offset) & ~mask) | ((val << field->shift) & mask); - return writel(new_val, base + field->offset); + writel(new_val, base + field->offset); } #endif /* __CLK_SOPHGO_COMMON_H__ */ -- 2.47.3