From: Herbert Xu Date: Wed, 6 May 2009 06:15:47 +0000 (+0800) Subject: crypto: testmgr - Dynamically allocate xbuf and axbuf X-Git-Tag: v2.6.31-rc1~352^2~13 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f8b0d4d09dc9d0a73fcdcf6c2724650529ec417d;p=pandora-kernel.git crypto: testmgr - Dynamically allocate xbuf and axbuf We currently allocate temporary memory that is used for testing statically. This renders the testing engine non-reentrant. As algorithms may nest, i.e., one may construct another in order to carry out a part of its operation, this is unacceptable. For example, it has been reported that an AEAD implementation allocates a cipher in its setkey function, which causes it to fail during testing as the temporary memory is overwritten. This patch replaces the static memory with dynamically allocated buffers. We need a maximum of 16 pages so this slightly increases the chances of an algorithm failing due to memory shortage. However, as testing usually occurs at registration, this shouldn't be a big problem. Reported-by: Shasi Pulijala Signed-off-by: Herbert Xu --- Reading git-diff-tree failed