From: Ben Hutchings Date: Mon, 2 Jul 2012 22:03:02 +0000 (+0100) Subject: sfc: Use dev_kfree_skb() in efx_end_loopback() X-Git-Tag: v3.6-rc1~125^2~120^2~4 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e3ed2bdfc4a5dcdcdf74141e88af9990dc141a4b;p=pandora-kernel.git sfc: Use dev_kfree_skb() in efx_end_loopback() Fix CID 102619 in the Coverity report on Linux. efx_end_loopback() iterates over an array of skb pointers of which some may be null (if efx_begin_loopback() failed). It should not use dev_kfree_skb_irq(), which requires non-null pointers. In practice this is safe because it does not run in interrupt context and therefore always ends up calling dev_kfree_skb(), which does allow null pointers. But we should make that explicit. Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed