From: Xi Wang Date: Fri, 4 Jan 2013 08:22:57 +0000 (-0500) Subject: nfs: fix null checking in nfs_get_option_str() X-Git-Tag: v3.8-rc3~14^2~4 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e25fbe380c4e3c09afa98bcdcd9d3921443adab8;p=pandora-kernel.git nfs: fix null checking in nfs_get_option_str() The following null pointer check is broken. *option = match_strdup(args); return !option; The pointer `option' must be non-null, and thus `!option' is always false. Use `!*option' instead. The bug was introduced in commit c5cb09b6f8 ("Cleanup: Factor out some cut-and-paste code."). Signed-off-by: Xi Wang Cc: stable@vger.kernel.org Signed-off-by: Trond Myklebust --- Reading git-diff-tree failed