From: Andrew Goodbody Date: Thu, 31 Jul 2025 10:51:22 +0000 (+0100) Subject: mmc: octeontx_hsmmc: Remove impossible test X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bde84072d007629a75ff746f986b80e4cba5424e;p=pandora-u-boot.git mmc: octeontx_hsmmc: Remove impossible test In octeontx_mmc_io_drive_setup drive and slew are tested for being less than 0 but they are declared as uint fields so this test must always fail. Just remove the test. This issue was found by Smatch. Signed-off-by: Andrew Goodbody --- diff --git a/drivers/mmc/octeontx_hsmmc.c b/drivers/mmc/octeontx_hsmmc.c index ffc8d4c7874..bb4fb29424b 100644 --- a/drivers/mmc/octeontx_hsmmc.c +++ b/drivers/mmc/octeontx_hsmmc.c @@ -2828,9 +2828,6 @@ static void octeontx_mmc_io_drive_setup(struct mmc *mmc) struct octeontx_mmc_slot *slot = mmc_to_slot(mmc); union mio_emm_io_ctl io_ctl; - if (slot->drive < 0 || slot->slew < 0) - return; - io_ctl.u = 0; io_ctl.s.drive = slot->drive; io_ctl.s.slew = slot->slew;