From: Randy Dunlap Date: Tue, 22 Mar 2011 23:30:29 +0000 (-0700) Subject: backlight: apple_bl depends on ACPI X-Git-Tag: v2.6.39-rc1~360 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b372412e159897c20ce2ad100f51c5d94ae98845;p=pandora-kernel.git backlight: apple_bl depends on ACPI apple_bl uses ACPI interfaces (data & code), so it should depend on ACPI. drivers/video/backlight/apple_bl.c:142: warning: 'struct acpi_device' declared inside parameter list drivers/video/backlight/apple_bl.c:142: warning: its scope is only this definition or declaration, which is probably not what you want drivers/video/backlight/apple_bl.c:201: warning: 'struct acpi_device' declared inside parameter list drivers/video/backlight/apple_bl.c:215: error: variable 'apple_bl_driver' has initializer but incomplete type drivers/video/backlight/apple_bl.c:216: error: unknown field 'name' specified in initializer ... Signed-off-by: Randy Dunlap Acked-by: Matthew Garrett Cc: Richard Purdie Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 39fff49da19d..0c9373bedd1f 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -246,10 +246,10 @@ config BACKLIGHT_MAX8925 config BACKLIGHT_APPLE tristate "Apple Backlight Driver" - depends on X86 + depends on X86 && ACPI help If you have an Intel-based Apple say Y to enable a driver for its - backlight + backlight. config BACKLIGHT_TOSA tristate "Sharp SL-6000 Backlight Driver"