From: Eric W. Biederman Date: Tue, 7 Oct 2014 23:22:52 +0000 (-0700) Subject: mnt: Move the clear of MNT_LOCKED from copy_tree to it's callers. X-Git-Tag: omap-for-v3.20/drop-legacy-3517~45^2~13 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8486a7882b5ba906992fd78bbfcefaae7fe285cc;p=pandora-kernel.git mnt: Move the clear of MNT_LOCKED from copy_tree to it's callers. Clear MNT_LOCKED in the callers of copy_tree except copy_mnt_ns, and collect_mounts. In copy_mnt_ns it is necessary to create an exact copy of a mount tree, so not clearing MNT_LOCKED is important. Similarly collect_mounts is used to take a snapshot of the mount tree for audit logging purposes and auditing using a faithful copy of the tree is important. This becomes particularly significant when we start setting MNT_LOCKED on rootfs to prevent it from being unmounted. Signed-off-by: "Eric W. Biederman" --- diff --git a/fs/namespace.c b/fs/namespace.c index 15d0328bd035..e8d1ffa7f132 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -1613,7 +1613,6 @@ struct mount *copy_tree(struct mount *mnt, struct dentry *dentry, if (IS_ERR(q)) return q; - q->mnt.mnt_flags &= ~MNT_LOCKED; q->mnt_mountpoint = mnt->mnt_mountpoint; p = mnt; Reading git-diff-tree failed