From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Fri, 1 Aug 2025 11:49:48 +0000 (+0100)
Subject: mtd: ubi: Remove test that always fails
X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=75b7ef1caf19d467ee8a7e69eb5eccb6a45e1715;p=pandora-u-boot.git

mtd: ubi: Remove test that always fails

When checking the VID header of a static volume there is an early test
for data_size == 0 so testing for that condition again is guaranteed to
fail. Just remove this piece of code.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---

diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
index 45699b4a477..2ec968c85ff 100644
--- a/drivers/mtd/ubi/io.c
+++ b/drivers/mtd/ubi/io.c
@@ -936,12 +936,7 @@ static int validate_vid_hdr(const struct ubi_device *ubi,
 				ubi_err(ubi, "bad data_size");
 				goto bad;
 			}
-		} else if (lnum == used_ebs - 1) {
-			if (data_size == 0) {
-				ubi_err(ubi, "bad data_size at last LEB");
-				goto bad;
-			}
-		} else {
+		} else if (lnum != used_ebs - 1) {
 			ubi_err(ubi, "too high lnum");
 			goto bad;
 		}