From: Sumit Semwal Date: Sat, 21 Feb 2015 03:30:17 +0000 (+0530) Subject: staging: android: ion: fix wrong init of dma_buf_export_info X-Git-Tag: omap-for-v4.2/o2_dc~22^2 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=72449cb47b0104c32ff8fb9380ade9113375d8d1;p=pandora-kernel.git staging: android: ion: fix wrong init of dma_buf_export_info Fixes: 817bd7253291 ("dma-buf: cleanup dma_buf_export() to make it easily extensible") Stupid copy-paste from me in the above patch leads to the following static checker warning: drivers/staging/android/ion/ion.c:1112 ion_share_dma_buf() error: potentially dereferencing uninitialized 'buffer'. drivers/staging/android/ion/ion.c 1103 struct dma_buf *ion_share_dma_buf(struct ion_client *client, 1104 struct ion_handle *handle) 1105 { 1106 struct ion_buffer *buffer; ^^^^^^ 1107 struct dma_buf *dmabuf; 1108 bool valid_handle; 1109 DEFINE_DMA_BUF_EXPORT_INFO(exp_info); 1110 1111 exp_info.ops = &dma_buf_ops; 1112 exp_info.size = buffer->size; ^^^^^^ 1113 exp_info.flags = O_RDWR; 1114 exp_info.priv = buffer; ^^^^^^ And here also. 1115 This patch corrects this stupidity. Reported-by: Dan Carpenter Reviewed-by: Dan Carpenter Acked-by: Greg Kroah-Hartman Signed-off-by: Sumit Semwal --- Reading git-diff-tree failed