From: Andrew Goodbody Date: Wed, 1 Oct 2025 10:05:10 +0000 (+0100) Subject: video: nexell: unsigned parameter cannot be negative X-Git-Tag: v2026.04-rc4~18^2~16 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=548e9a254c7d0bd9796decfea43d7759070c7312;p=pandora-u-boot.git video: nexell: unsigned parameter cannot be negative The parameter 'alpha' is declared as an unsigned type so cannot be negative. The code to test it as being less than zero will always fail and so is redundant and should be removed. This issue was found by Smatch. Signed-off-by: Andrew Goodbody Reviewed-by: Stefan Bosch Signed-off-by: Minkyu Kang --- diff --git a/drivers/video/nexell/soc/s5pxx18_soc_mlc.c b/drivers/video/nexell/soc/s5pxx18_soc_mlc.c index c8cf833f308..2c8348bf633 100644 --- a/drivers/video/nexell/soc/s5pxx18_soc_mlc.c +++ b/drivers/video/nexell/soc/s5pxx18_soc_mlc.c @@ -1641,8 +1641,6 @@ void nx_mlc_set_layer_alpha256(u32 module_index, u32 layer, u32 alpha) u32 register_data; register struct nx_mlc_register_set *pregister; - if (alpha < 0) - alpha = 0; if (alpha > 255) alpha = 255;