From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Tue, 5 Aug 2025 11:23:06 +0000 (+0100)
Subject: net: fec_mxc: Set error code on error exit
X-Git-Tag: v2025.10-rc2~6^2~3
X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=53158c8cf269f05c2d25769024cb0c363aac5e7a;p=pandora-u-boot.git

net: fec_mxc: Set error code on error exit

In fecmxc_probe if a timeout is detected when resetting the chip no
error code is set before taking the error exit. This could lead to a
silent failure. Instead set an error code.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 54b08482b91..9ac72d25ef6 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -1344,6 +1344,7 @@ static int fecmxc_probe(struct udevice *dev)
 	while (readl(&priv->eth->ecntrl) & FEC_ECNTRL_RESET) {
 		if (get_timer(start) > (CONFIG_SYS_HZ * 5)) {
 			printf("FEC MXC: Timeout resetting chip\n");
+			ret = -ETIMEDOUT;
 			goto err_timeout;
 		}
 		udelay(10);