From: Linus Torvalds Date: Sun, 7 Aug 2011 21:07:03 +0000 (-0700) Subject: arm: remove "optimized" SHA1 routines X-Git-Tag: v3.1-rc1~4 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4d4487140d34c1b9b321889d2d209321b0da6643;p=pandora-kernel.git arm: remove "optimized" SHA1 routines Since commit 1eb19a12bd22 ("lib/sha1: use the git implementation of SHA-1"), the ARM SHA1 routines no longer work. The reason? They depended on the larger 320-byte workspace, and now the sha1 workspace is just 16 words (64 bytes). So the assembly version would overwrite the stack randomly. The optimized asm version is also probably slower than the new improved C version, so there's no reason to keep it around. At least that was the case in git, where what appears to be the same assembly language version was removed two years ago because the optimized C BLK_SHA1 code was faster. Reported-and-tested-by: Joachim Eastwood Cc: Andreas Schwab Cc: Nicolas Pitre Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed