From: Mariusz Kozlowski Date: Tue, 9 Oct 2007 08:34:06 +0000 (+0200) Subject: [ALSA] sound: snd_register_device_for_dev fix X-Git-Tag: v2.6.24-rc1~832^2~24 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2469049e728ee0542d6617f81311a18a14e73826;p=pandora-kernel.git [ALSA] sound: snd_register_device_for_dev fix snd_register_device_for_dev() can oops when device_create() returns ERR_PTR(err). Scenario: preg->dev = device_create(...); /* fails */ if (preg->dev) /* contains ERR_PTR(err) */ dev_set_drvdata(preg->dev, private_data); and dev_set_drvdata() looks like this: static inline void dev_set_drvdata (struct device *dev, void *data) { dev->driver_data = data; <--- boom } This patch should prevent that. Signed-off-by: Mariusz Kozlowski Signed-off-by: Andrew Morton Signed-off-by: Takashi Iwai Signed-off-by: Jaroslav Kysela --- Reading git-diff-tree failed