From: Laurentiu Palcu Date: Tue, 2 Jun 2015 10:36:51 +0000 (+0300) Subject: power_supply: bq25890: make chip_id int X-Git-Tag: omap-for-v4.3/legacy-v2-signed~178^2~11 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=23fa43a28d00bca79b28e145a34c0c7dcafd72bc;p=pandora-kernel.git power_supply: bq25890: make chip_id int Smatch static checker correctly detected an impossible condition because chip_id was declared as u8, instead of int: drivers/power/bq25890_charger.c:843 bq25890_probe() warn: impossible condition '(bq->chip_id < 0) => (0-255 < 0)' Also, while at it, fix the return value too. Signed-off-by: Laurentiu Palcu Reported-by: Dan Carpenter Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- Reading git-diff-tree failed