From: Lee Jones Date: Thu, 10 Jul 2014 08:07:06 +0000 (+0100) Subject: backlight: jornada720: Minimise code duplication and handle errors better X-Git-Tag: omap-for-v3.17/fixes-against-rc2~127^2~3 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1e3b09701223afdff3b0353f87b566e7848bb24a;p=pandora-kernel.git backlight: jornada720: Minimise code duplication and handle errors better Rickard Strandqvi's ran a code analysis application which found that jornada_lcd_get_contrast(() and jornada_lcd_set_contrast() contained some code duplication (calling the same functions during various code execution paths) and failed to return errors in a consistent manner. This patch aims to simplify the code, coercing it into behaving at a level expected of a driver in the Linux kernel. Suggested-by: Rickard Strandqvist Acked-by: Jingoo Han Reviewed-by: Rickard Strandqvist Signed-off-by: Lee Jones --- Reading git-diff-tree failed