From: Steven Whitehouse Date: Mon, 3 Sep 2007 10:01:33 +0000 (+0100) Subject: [GFS2] Clean up gfs2_trans_add_revoke() X-Git-Tag: v2.6.24-rc1~1405^2~11 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1ad38c437fa33f85ba4b6a85ea8c5478ee72d5bd;p=pandora-kernel.git [GFS2] Clean up gfs2_trans_add_revoke() The following alters gfs2_trans_add_revoke() to take a struct gfs2_bufdata as an argument. This eliminates the memory allocation which was previously required by making use of the already existing struct gfs2_bufdata. It makes some sanity checks to ensure that the gfs2_bufdata has been removed from all the lists before its recycled as a revoke structure. This saves one memory allocation and one free per revoke structure. Also as a result, and to simplify the locking, since there is no longer any blocking code in gfs2_trans_add_revoke() we must hold the log lock whenever this function is called. This reduces the amount of times we take and unlock the log lock. Signed-off-by: Steven Whitehouse --- Reading git-diff-tree failed