From: Joe Perches Date: Wed, 6 Aug 2014 23:10:29 +0000 (-0700) Subject: checkpatch: warn on unnecessary else after return or break X-Git-Tag: cleanup-for-v3.18~96^2~29 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=032a4c0f9a77ce565355c6e191553e853ba66f09;p=pandora-kernel.git checkpatch: warn on unnecessary else after return or break Using an else following a break or return can unnecessarily indent code blocks. ie: for (i = 0; i < 100; i++) { int foo = bar(); if (foo < 1) break; else usleep(1); } is generally better written as: for (i = 0; i < 100; i++) { int foo = bar(); if (foo < 1) break; usleep(1); } Warn when a bare else statement is preceded by a break or return indented 1 tab more than the else. Signed-off-by: Joe Perches Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed