From 577bd8ba2b844aa11aa694a43943a57a09a973d1 Mon Sep 17 00:00:00 2001 From: Grazvydas Ignotas Date: Mon, 23 May 2016 00:44:47 +0300 Subject: [PATCH] regulator: core: don't crash if set_voltage fails it was calling list_voltage() with uninitialized selector --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 2dd98387bc40..38d0c2c4d65b 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1745,7 +1745,7 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev, ret = rdev->desc->ops->set_voltage(rdev, min_uV, max_uV, &selector); - if (rdev->desc->ops->list_voltage) + if (ret >= 0 && rdev->desc->ops->list_voltage) selector = rdev->desc->ops->list_voltage(rdev, selector); else -- 2.39.2