ipr: Fix regression when loading firmware
authorGabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Thu, 25 Feb 2016 16:54:20 +0000 (13:54 -0300)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 1 Apr 2016 00:54:35 +0000 (01:54 +0100)
commit7e9f9e9eadd767c38a27742f11fe4b78e2dc0042
tree2b969642af119a30248a34aa0ea9371c2ca1b941
parentcaf4c8db59e82f8bc3ed516e25d32f488c7db868
ipr: Fix regression when loading firmware

commit 21b81716c6bff24cda52dc75588455f879ddbfe9 upstream.

Commit d63c7dd5bcb9 ("ipr: Fix out-of-bounds null overwrite") removed
the end of line handling when storing the update_fw sysfs attribute.
This changed the userpace API because it started refusing writes
terminated by a line feed, which broke the update tools we already have.

This patch re-adds that handling, so both a write terminated by a line
feed or not can make it through with the update.

Fixes: d63c7dd5bcb9 ("ipr: Fix out-of-bounds null overwrite")
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Cc: Insu Yun <wuninsu@gmail.com>
Acked-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/scsi/ipr.c