libata: Align ata_device's id on a cacheline
authorHarvey Hunt <harvey.hunt@imgtec.com>
Wed, 24 Feb 2016 15:16:43 +0000 (15:16 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 1 Apr 2016 00:54:35 +0000 (01:54 +0100)
commit2d5a6d0db3c83f5883b542fd3f79a2a80d319b14
tree76967efcfc2189af8db9726507a2fdd03172c40d
parentbb96b5354a62154d0aca4b2015a5b3eee68a4ac5
libata: Align ata_device's id on a cacheline

commit 4ee34ea3a12396f35b26d90a094c75db95080baa upstream.

The id buffer in ata_device is a DMA target, but it isn't explicitly
cacheline aligned. Due to this, adjacent fields can be overwritten with
stale data from memory on non coherent architectures. As a result, the
kernel is sometimes unable to communicate with an ATA device.

Fix this by ensuring that the id buffer is cacheline aligned.

This issue is similar to that fixed by Commit 84bda12af31f
("libata: align ap->sector_buf").

Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/linux/libata.h