af_key: fix buffer overread in parse_exthdrs()
authorEric Biggers <ebiggers@google.com>
Sat, 30 Dec 2017 00:15:23 +0000 (18:15 -0600)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 3 Mar 2018 15:50:52 +0000 (15:50 +0000)
commitac047b312a2945eea68a40f397bc0eebfa55f34d
treeb4c9b74cc6bfc0109268b1551bfff7bf83ffcc11
parent5211e8d11e9560907b0c577d8d4cfe1054c0c7b7
af_key: fix buffer overread in parse_exthdrs()

commit 4e765b4972af7b07adcb1feb16e7a525ce1f6b28 upstream.

If a message sent to a PF_KEY socket ended with an incomplete extension
header (fewer than 4 bytes remaining), then parse_exthdrs() read past
the end of the message, into uninitialized memory.  Fix it by returning
-EINVAL in this case.

Reproducer:

#include <linux/pfkeyv2.h>
#include <sys/socket.h>
#include <unistd.h>

int main()
{
int sock = socket(PF_KEY, SOCK_RAW, PF_KEY_V2);
char buf[17] = { 0 };
struct sadb_msg *msg = (void *)buf;

msg->sadb_msg_version = PF_KEY_V2;
msg->sadb_msg_type = SADB_DELETE;
msg->sadb_msg_len = 2;

write(sock, buf, 17);
}

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/key/af_key.c