From e8edca6f7f92234202d6dd163c118ef495244d7c Mon Sep 17 00:00:00 2001 From: Ming Lei Date: Fri, 30 May 2014 10:49:29 +0800 Subject: [PATCH] block: virtio_blk: don't hold spin lock during world switch Firstly, it isn't necessary to hold lock of vblk->vq_lock when notifying hypervisor about queued I/O. Secondly, virtqueue_notify() will cause world switch and it may take long time on some hypervisors(such as, qemu-arm), so it isn't good to hold the lock and block other vCPUs. On arm64 quad core VM(qemu-kvm), the patch can increase I/O performance a lot with VIRTIO_RING_F_EVENT_IDX enabled: - without the patch: 14K IOPS - with the patch: 34K IOPS fio script: [global] direct=1 bsrange=4k-4k timeout=10 numjobs=4 ioengine=libaio iodepth=64 filename=/dev/vdc group_reporting=1 [f1] rw=randread Cc: Rusty Russell Cc: "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org Signed-off-by: Ming Lei Acked-by: Rusty Russell Cc: stable@kernel.org # 3.13+ Signed-off-by: Jens Axboe --- Reading git-format-patch failed