From de9e8f3f4086b1e6ba302487074fb707f1a95fc7 Mon Sep 17 00:00:00 2001 From: Herbert Xu Date: Sat, 7 Sep 2013 12:27:11 +1000 Subject: [PATCH] macvlan: Move skb_clone check closer to call Currently macvlan calls skb_clone in macvlan_broadcast but checks for a NULL return in macvlan_broadcast_one instead. This is needlessly confusing and may lead to bugs introduced later. This patch moves the error check to where the skb_clone call is. The only other caller of macvlan_broadcast_one never passes in a NULL value so it doesn't need the check either. Signed-off-by: Herbert Xu Thanks, Reviewed-by: Simon Horman Signed-off-by: David S. Miller --- Reading git-format-patch failed