From b946a9ff1b218ae01a7995983838f0103f178160 Mon Sep 17 00:00:00 2001 From: Caleb Connolly Date: Fri, 11 Apr 2025 17:03:36 +0200 Subject: [PATCH] dfu: scsi: don't call scsi_scan() Calling scsi_scan() results in all the block devices (and EFI block devices) being destroyed and re-created. This breaks the EFI filesystem drivers during capsule update. Remove the call, since boards really should be calling scsi_scan() themselves during board_init(). Reviewed-by: Ilias Apalodimas Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly Link: https://lore.kernel.org/r/20250411-b4-qcom-capsule-update-improvements-v2-3-27f6b2fcc4a9@linaro.org Signed-off-by: Casey Connolly --- drivers/dfu/dfu_scsi.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/dfu/dfu_scsi.c b/drivers/dfu/dfu_scsi.c index 7ec34a8f7e3..d99b05d23ac 100644 --- a/drivers/dfu/dfu_scsi.c +++ b/drivers/dfu/dfu_scsi.c @@ -342,11 +342,6 @@ int dfu_fill_entity_scsi(struct dfu_entity *dfu, char *devstr, char **argv, int return -EINVAL; } - if (scsi_scan(false)) { - pr_err("Couldn't init scsi device.\n"); - return -ENODEV; - } - ret = find_scsi_device(dfu->data.scsi.lun, &scsi); if (ret < 0) { pr_err("Couldn't find scsi device no. %d.\n", dfu->data.scsi.lun); -- 2.47.2