From ac1a1de31515d950f858ba47d2bba74ff9a2614d Mon Sep 17 00:00:00 2001 From: Ralf Baechle Date: Thu, 24 Nov 2011 23:08:49 +0000 Subject: [PATCH] NET: NETROM: When adding a route verify length of mnemonic string. struct nr_route_struct's mnemonic permits a string of up to 7 bytes to be used. If userland passes a not zero terminated string to the kernel adding a node to the routing table might result in the kernel attempting to read copy a too long string. Mnemonic is part of the NET/ROM routing protocol; NET/ROM routing table updates only broadcast 6 bytes. The 7th byte in the mnemonic array exists only as a \0 termination character for the kernel code's convenience. Fixed by rejecting mnemonic strings that have no terminating \0 in the first 7 characters. Do this test only NETROM_NODE to avoid breaking NETROM_NEIGH where userland might passing an uninitialized mnemonic field. Initial patch by Dan Carpenter . Signed-off-by: Ralf Baechle Cc: Dan Carpenter Cc: Walter Harms Cc: Thomas Osterried Acked-by: Dan Carpenter Signed-off-by: David S. Miller --- Reading git-format-patch failed