From a091d173e32b98fe372b5b02d4e25c81f1bc9dc1 Mon Sep 17 00:00:00 2001 From: Jerome Forissier Date: Tue, 4 Feb 2025 17:00:49 +0100 Subject: [PATCH] net: Kconfig: depend on DM_RNG for WGET_HTTPS net/lwip/wget.c/mbedtls_hardware_poll() is calling dm_rng_read() but dependency is not recorded anywhere that's why depend on DM_RNG when WGET_HTTPS is used. Suggested-by: Michal Simek Co-developed-by: Ilias Apalodimas Signed-off-by: Ilias Apalodimas Signed-off-by: Jerome Forissier Tested-by: Michal Simek --- cmd/Kconfig | 1 + net/lwip/wget.c | 11 ++++++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index 1f9b26928c4..a04fcaa0e08 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -2161,6 +2161,7 @@ config WGET_HTTPS depends on CMD_WGET depends on PROT_TCP_LWIP depends on MBEDTLS_LIB + depends on DM_RNG select SHA256 select RSA select ASYMMETRIC_KEY_TYPE diff --git a/net/lwip/wget.c b/net/lwip/wget.c index 9aec75f9bed..14f27d42998 100644 --- a/net/lwip/wget.c +++ b/net/lwip/wget.c @@ -433,10 +433,15 @@ bool wget_validate_uri(char *uri) if (!strncmp(uri, "http://", strlen("http://"))) { prefix_len = strlen("http://"); - } else if (!strncmp(uri, "https://", strlen("https://"))) { - prefix_len = strlen("https://"); + } else if (CONFIG_IS_ENABLED(WGET_HTTPS)) { + if (!strncmp(uri, "https://", strlen("https://"))) { + prefix_len = strlen("https://"); + } else { + log_err("only http(s):// is supported\n"); + return false; + } } else { - log_err("only http(s):// is supported\n"); + log_err("only http:// is supported\n"); return false; } -- 2.39.5