From 80509de89db6ffc702c93b8a2ff111cb8ff81b67 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Ville=20Syrj=C3=A4l=C3=A4?= Date: Tue, 25 May 2010 23:32:05 +0300 Subject: [PATCH] gpu: pvr: Reduce code duplication MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit pvr_signal_sync_event() can be used twice with just a tiny modification to the list handling. Signed-off-by: Ville Syrjälä Reviewed-by: Topi Pohjolainen --- pvr/pvr_events.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/pvr/pvr_events.c b/pvr/pvr_events.c index d6449c8..a26506b 100644 --- a/pvr/pvr_events.c +++ b/pvr/pvr_events.c @@ -25,7 +25,7 @@ static void pvr_signal_sync_event(struct pvr_pending_sync_event *e, e->event.tv_sec = now->tv_sec; e->event.tv_usec = now->tv_usec; - list_add_tail(&e->base.link, &e->base.file_priv->event_list); + list_move_tail(&e->base.link, &e->base.file_priv->event_list); wake_up_interruptible(&e->base.file_priv->event_wait); } @@ -61,10 +61,9 @@ int pvr_sync_event_req(struct PVRSRV_FILE_PRIVATE_DATA *priv, priv->event_space -= sizeof(e->event); + list_add_tail(&e->base.link, &sync_wait_list); if (is_render_complete(sync_info->psSyncData)) pvr_signal_sync_event(e, &now); - else - list_add_tail(&e->base.link, &sync_wait_list); spin_unlock_irqrestore(&event_lock, flags); @@ -203,12 +202,7 @@ void pvr_handle_sync_events(void) if (!is_render_complete(e->event.sync_info->psSyncData)) continue; - e->event.tv_sec = now.tv_sec; - e->event.tv_usec = now.tv_usec; - - list_move_tail(&e->base.link, &e->base.file_priv->event_list); - - wake_up_interruptible(&e->base.file_priv->event_wait); + pvr_signal_sync_event(e, &now); } spin_unlock_irqrestore(&event_lock, flags); -- 2.47.2