From 59bc1d89d6a4d67c94a9b70fa81bda1d5b04f0cb Mon Sep 17 00:00:00 2001 From: Lauri Kasanen Date: Sun, 20 Apr 2014 20:29:33 +0300 Subject: [PATCH] drm/radeon: Inline r100_mm_rreg, -wreg, v3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This was originally un-inlined by Andi Kleen in 2011 citing size concerns. Indeed, a first attempt at inlining it grew radeon.ko by 7%. However, 2% of cpu is spent in this function. Simply inlining it gave 1% more fps in Urban Terror. v2: We know the minimum MMIO size. Adding it to the if allows the compiler to optimize the branch out, improving both performance and size. The v2 patch decreases radeon.ko size by 2%. I didn't re-benchmark, but common sense says perf is now more than 1% better. v3: Also change _wreg, make the threshold a define. Inlining _wreg increased the size a bit compared to v2, so now radeon.ko is only 1% smaller. Signed-off-by: Lauri Kasanen Reviewed-by: Christian König Signed-off-by: Alex Deucher --- Reading git-format-patch failed