From 4b9717c6868f2f98b02fbe87a885cfa48a5b9946 Mon Sep 17 00:00:00 2001 From: Andrew Goodbody Date: Thu, 26 Jun 2025 17:38:54 +0100 Subject: [PATCH] cmd: abootimg: Prevent use of unintialised variable Initialise vhdr to prevent its use when uninitialised. This issue was found with Smatch. Fixes: 636da2039aea (android: boot: support boot image header version 3 and 4) Signed-off-by: Andrew Goodbody Link: https://lore.kernel.org/r/20250625-abootimg_fix-v4-1-df7af00e87b0@linaro.org [mkorpershoek: fixed trivial typo in commit msg] Signed-off-by: Mattijs Korpershoek --- cmd/abootimg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/abootimg.c b/cmd/abootimg.c index 44de00fb9c9..6fb52153786 100644 --- a/cmd/abootimg.c +++ b/cmd/abootimg.c @@ -96,7 +96,7 @@ static int abootimg_get_dtb_load_addr(int argc, char *const argv[]) return CMD_RET_USAGE; struct andr_image_data img_data = {0}; const struct andr_boot_img_hdr_v0 *hdr; - const struct andr_vnd_boot_img_hdr *vhdr; + const struct andr_vnd_boot_img_hdr *vhdr = NULL; hdr = map_sysmem(abootimg_addr(), sizeof(*hdr)); if (get_avendor_bootimg_addr() != -1) -- 2.47.2