From 4a79ebbdd0231a4afcd758314b3852501694e44f Mon Sep 17 00:00:00 2001 From: Ben Hutchings Date: Sun, 8 Oct 2017 14:48:44 +0100 Subject: [PATCH] ext3: preserve i_mode if ext2_set_acl() fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Based on Ernesto A. Fernández's fix for ext2 (commit fe26569eb919), from which the following description is taken: > When changing a file's acl mask, ext2_set_acl() will first set the group > bits of i_mode to the value of the mask, and only then set the actual > extended attribute representing the new acl. > > If the second part fails (due to lack of space, for example) and the file > had no acl attribute to begin with, the system will from now on assume > that the mask permission bits are actual group permission bits, potentially > granting access to the wrong users. > > Prevent this by only changing the inode mode after the acl has been set. Cc: Ernesto A. Fernández Cc: Jan Kara Signed-off-by: Ben Hutchings --- Reading git-format-patch failed