From 42a71ef97b7ac31ae8f929c36048fec5cd201a49 Mon Sep 17 00:00:00 2001 From: Julia Lawall Date: Thu, 21 Aug 2014 07:06:06 -0500 Subject: [PATCH] mfd: menelaus: Fix error return code Convert a zero return value on error to a negative one, as returned elsewhere in the function. Additionally, converted 1 << 7 to BIT(7) at the suggestion of Lee Jones. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Julia Lawall Signed-off-by: Lee Jones --- Reading git-format-patch failed